starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Error in menu #12641

New Issue
Closed
opened 2026-01-31 03:20:56 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 03:20:56 +00:00
Owner
Copy Link

Originally created by @PawelGPL on GitHub (Feb 18, 2021).

I noticed a small error on the menu: in item "Settings" there is "Ctrl Alt ," shortcut instead of "Ctrl ," (open settings.json).

Environment

Microsoft Windows Version 10.0.19042.804

Steps to reproduce

Expected behavior

Actual behavior

Originally created by @PawelGPL on GitHub (Feb 18, 2021). I noticed a small error on the menu: in item "Settings" there is "Ctrl Alt ," shortcut instead of "Ctrl ," (open _settings.json_). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment Microsoft Windows Version 10.0.19042.804 # Steps to reproduce <!-- A description of how to trigger this bug. --> # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior <!-- What's actually happening? -->
claunia commented 2026-01-31 03:20:58 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 18, 2021):

Can you share your settings.json? Also, what keyboard layout are you using?

@zadjii-msft commented on GitHub (Feb 18, 2021): Can you share your `settings.json`? Also, what keyboard layout are you using?
claunia commented 2026-01-31 03:20:58 +00:00
Author
Owner
Copy Link

@PawelGPL commented on GitHub (Feb 18, 2021):

Default settings.json. It does not matter. Even after deleting this file there is the mentioned error in the menu. Clicking on a menu item works like shortcut "Ctrl ," not like "Ctrl Alt ,".
obraz

@PawelGPL commented on GitHub (Feb 18, 2021): Default _settings.json_. It does not matter. Even after deleting this file there is the mentioned error in the menu. Clicking on a menu item works like shortcut "Ctrl ," not like "Ctrl Alt ,". ![obraz](https://user-images.githubusercontent.com/52577731/108361586-f9172500-71f2-11eb-92c8-bc90a64b3204.png)
claunia commented 2026-01-31 03:20:58 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 18, 2021):

@PawelGPL What keyboard layout are you using? Do you need to press the AltGr key to type the , character?

@zadjii-msft commented on GitHub (Feb 18, 2021): @PawelGPL What keyboard layout are you using? Do you need to press the <kbd>AltGr</kbd> key to type the `,` character?
claunia commented 2026-01-31 03:20:59 +00:00
Author
Owner
Copy Link

@PawelGPL commented on GitHub (Feb 18, 2021):

I don't need to use Alt or AltGr to type , (comma).

@PawelGPL commented on GitHub (Feb 18, 2021): I don't need to use Alt or AltGr to type , (comma).
claunia commented 2026-01-31 03:20:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 18, 2021):

Hmm. Something weird is going on here.

#8967 reminded me that we actually do bind that keybinding by default:

  { "command": "openSettings", "keys": "ctrl+," },
  { "command": { "action": "openSettings", "target": "defaultsFile" }, "keys": "ctrl+alt+," },

But not to open the settings file - it's bound to opening the defaults file.

  • What version of the terminal are you using?
  • What keyboard layout are you using?
@zadjii-msft commented on GitHub (Feb 18, 2021): Hmm. Something weird is going on here. #8967 reminded me that we actually do bind that keybinding by default: ```json { "command": "openSettings", "keys": "ctrl+," }, { "command": { "action": "openSettings", "target": "defaultsFile" }, "keys": "ctrl+alt+," }, ``` But not to open the settings file - it's bound to opening the defaults file. * What version of the terminal are you using? * What keyboard layout are you using?
claunia commented 2026-01-31 03:20:59 +00:00
Author
Owner
Copy Link

@PawelGPL commented on GitHub (Feb 18, 2021):

I have current version - 1.53.2
I have exactly the same setting in default.json
I'm using US keyboard with specific Polish characters obtained by pressing with AltGr, e.g AltGr-c -> ć.
All works ok. except wrong description in menu:
Ctrl+, opens settings.json just like clicking in Settings in menu
Ctrl+Atl+, opens defaults.json

@PawelGPL commented on GitHub (Feb 18, 2021): I have current version - 1.53.2 I have exactly the same setting in _default.json_ I'm using US keyboard with specific Polish characters obtained by pressing with AltGr, e.g AltGr-c -> ć. All works ok. except wrong description in menu: Ctrl+, opens _settings.json_ just like clicking in _Settings_ in menu Ctrl+Atl+, opens _defaults.json_
claunia commented 2026-01-31 03:20:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 18, 2021):

Son of a gun they'll do it. If you paste that action:

  { "command": { "action": "openSettings", "target": "defaultsFile" }, "keys": "ctrl+alt+," },

into the actions on 1.5, it'll use that one as the help shortcut to use, not the actual settings action. I think that's already fixed on 1.6, but I don't know when or where we fixed that. We might have a dupe somewhere...

@zadjii-msft commented on GitHub (Feb 18, 2021): Son of a gun they'll do it. If you paste that action: ```json { "command": { "action": "openSettings", "target": "defaultsFile" }, "keys": "ctrl+alt+," }, ``` into the actions on 1.5, it'll use that one as the help shortcut to use, not the actual settings action. I think that's already fixed on 1.6, but I don't know when or where we fixed that. We might have a dupe somewhere...
claunia commented 2026-01-31 03:20:59 +00:00
Author
Owner
Copy Link

@PawelGPL commented on GitHub (Feb 18, 2021):

Btw. is it possible to install terminal without a MS Store? E.g. in Windows 8.1? Is there a standalone installer with an executable file?

@PawelGPL commented on GitHub (Feb 18, 2021): Btw. is it possible to install terminal without a MS Store? E.g. in Windows 8.1? Is there a standalone installer with an executable file?
claunia commented 2026-01-31 03:20:59 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 18, 2021):

Btw. is it possible to install terminal without a MS Store? E.g. in Windows 8.1? Is there a standalone installer with an executable file?

No, sorry.

@DHowett commented on GitHub (Feb 18, 2021): > Btw. is it possible to install terminal without a MS Store? E.g. in Windows 8.1? Is there a standalone installer with an executable file? No, sorry.
claunia commented 2026-01-31 03:21:00 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 18, 2021):

Alright, so looking through the history, I think this was broken in (the combo of #7802 and #8725) and was fixed in #8670. That PR didn't have an original issue tracking it, but rest assured, this is already fixed ☺️

@zadjii-msft commented on GitHub (Feb 18, 2021): Alright, so looking through the history, I think this was broken in (the combo of #7802 and #8725) and was fixed in #8670. That PR didn't have an original issue tracking it, but rest assured, this is already fixed ☺️
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Attention Needs-Tag-Fix Needs-Triage Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12641
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?