[Settings UI] Add a button to reset the settings to defaults #1265

@zadjii-msft commented on GitHub (May 22, 2019):

Out of curiosity, do you know which PR introduced a breaking change for the settings? The only two I can think of would be the color names one and the keybindings one. The first left the legacy de-serialization code, so the color tables would be gracefully updated. The latter had a conditional that included checking to see if no keybindings were found, and generating the defaults in that case.

@zadjii-msft commented on GitHub (May 22, 2019): Out of curiosity, do you know which PR introduced a breaking change for the settings? The only two I can think of would be the color names one and the keybindings one. The first left the legacy de-serialization code, so the color tables would be gracefully updated. The latter had a conditional that included checking to see if _no_ keybindings were found, and generating the defaults in that case.

claunia commented

@DHowett-MSFT commented on GitHub (May 22, 2019):

There should not have been any breaking changes in configuration since we released the first open-source version of Terminal. Are you referring to things like #934, #869, #742, #466 and friends that just change the defaults?

@DHowett-MSFT commented on GitHub (May 22, 2019): There should not have been any _breaking changes_ in configuration since we released the first open-source version of Terminal. Are you referring to things like #934, #869, #742, #466 and friends that just change the defaults?

claunia commented

@DHowett-MSFT commented on GitHub (May 22, 2019):

(accidental closure; please disregard)

@DHowett-MSFT commented on GitHub (May 22, 2019): (accidental closure; please disregard)

claunia commented

@justalemon commented on GitHub (May 23, 2019):

Out of curiosity, do you know which PR introduced a breaking change for the settings?

That was a misinterpreted example, I know that there have not been any breaking changes during the last days. I was thinking that in the future with the full implementation of features like icons and multiple WSL distros the configuration format and/or parameter names might change.

Plus, this feature is also useful for when the user changes the values and want to reset them to default.

@justalemon commented on GitHub (May 23, 2019): > Out of curiosity, do you know which PR introduced a breaking change for the settings? That was a misinterpreted example, I know that there have not been any breaking changes during the last days. I was thinking that in the future with the full implementation of features like icons and multiple WSL distros the configuration format and/or parameter names might change. Plus, this feature is also useful for when the user changes the values and want to reset them to default.

claunia commented

@zadjii-msft commented on GitHub (May 23, 2019):

I think the long-term intention here is to have a cascading settings model, where there's a static "default settings" file, and the user's settings are in a separate file, which is applied on top of the defaults. In that scenario, the "reset to defaults" flow would just be deleting everything in your user settings. This work is being tracked in #754.

Additionally, there's other work being done to add an actual settings dialog, which will allow for changing the settings without needing to edit the file directly. This seems like a great request for that UI :)

@zadjii-msft commented on GitHub (May 23, 2019): I think the _long-term_ intention here is to have a cascading settings model, where there's a static "default settings" file, and the user's settings are in a separate file, which is applied on top of the defaults. In that scenario, the "reset to defaults" flow would just be deleting everything in your user settings. This work is being tracked in #754. Additionally, there's other work being done to add an actual settings dialog, which will allow for changing the settings without needing to edit the file directly. This seems like a great request for that UI :)

claunia commented

@WSLUser commented on GitHub (May 23, 2019):

here's other work being done to add an actual settings dialog, which will allow for changing the settings without needing to edit the file directly

I think https://github.com/microsoft/vscode would be the best place to look to. The Settings UI there is great and having a similar one (maybe little more simplistic) for the Terminal would be great. Honestly with all the json going on in the backend with Terminal, I'm curious just how much of what VSCode has can be directly ported.

@WSLUser commented on GitHub (May 23, 2019): > here's other work being done to add an actual settings dialog, which will allow for changing the settings without needing to edit the file directly I think https://github.com/microsoft/vscode would be the best place to look to. The Settings UI there is great and having a similar one (maybe little more simplistic) for the Terminal would be great. Honestly with all the json going on in the backend with Terminal, I'm curious just how much of what VSCode has can be directly ported.

claunia commented

@DHowett-MSFT commented on GitHub (May 23, 2019):

On account of the Terminal is not written in javascript or running in electron but that VSCode is, none of it. 😄

@DHowett-MSFT commented on GitHub (May 23, 2019): On account of the Terminal is not written in javascript or running in electron but that VSCode is, none of it. :smile:

claunia commented

@WSLUser commented on GitHub (May 23, 2019):

Well I knew the bulk of the code there wouldn't be useful due to those reasons but thought the json files may be of use. I took a look at the core files in https://github.com/microsoft/vscode/blob/master/.vscode/ and have to agree they can't be used as is but they do provide a good example for anyone interested in improvements in this repo.

I did just try to look for the UI component for settings and nothing stands out immediately. If it's written in JS/TS then may not be useful though not sure if it's possible to convert to C ++ (don't really mess with the C family much, much prefer python).

@WSLUser commented on GitHub (May 23, 2019): Well I knew the bulk of the code there wouldn't be useful due to those reasons but thought the json files may be of use. I took a look at the core files in https://github.com/microsoft/vscode/blob/master/.vscode/ and have to agree they can't be used as is but they do provide a good example for anyone interested in improvements in this repo. I did just try to look for the UI component for settings and nothing stands out immediately. If it's written in JS/TS then may not be useful though not sure if it's possible to convert to C ++ (don't really mess with the C family much, much prefer python).

claunia commented

@mrmlnc commented on GitHub (Jun 22, 2019):

Just my two cents.

Version: 0.2.1715.0

Accidentally or intentionally, I can delete the contents of the settings file (profiles.json). Unfortunately, I can't get the content back without manually deleting the file.

It would be nice to add a reset button to the dialog:

@mrmlnc commented on GitHub (Jun 22, 2019): Just my two cents. ``` Version: 0.2.1715.0 ``` Accidentally or intentionally, I can delete the contents of the settings file (`profiles.json`). Unfortunately, I can't get the content back without manually deleting the file. It would be nice to add a reset button to the dialog: <img width="415" alt="Annotation 2019-06-22 165036" src="https://user-images.githubusercontent.com/7034281/59964774-df997380-950d-11e9-9262-d511ea7c299b.png">

claunia commented

@aaroneg commented on GitHub (Aug 29, 2019):

I would personally favor a menu item below "settings" and above "Feedback" to reset settings to default, especially while we're in preview releases. I'm not concerned about breaking changes, and I know how to just delete profiles.json, but the workflow is inconvenient, and removing it seems to be the only way to get Terminal to recognize a new WSL distro unless i want to built a profile for that myself, which isn't a super exciting prospect for me. It also allows Terminal to put new settings in the file like 'copyOnSelect' in the correct place so i can be lazy and just swap that from false to true without having to guess where i should place that in the file.

@aaroneg commented on GitHub (Aug 29, 2019): I would personally favor a menu item below "settings" and above "Feedback" to reset settings to default, **especially** while we're in preview releases. I'm not concerned about breaking changes, and I know how to just delete profiles.json, but the workflow is inconvenient, and removing it seems to be the only way to get Terminal to recognize a new WSL distro unless i want to built a profile for that myself, which isn't a super exciting prospect for me. It also allows Terminal to put new settings in the file like 'copyOnSelect' in the correct place so i can be lazy and just swap that from false to true without having to guess where i should place that in the file.

claunia commented

@gulshan commented on GitHub (Sep 25, 2019):

Has there anything changed with the latest release? The "cascading settings" issue #754 is closed now. Can I just delete the settings file to reset to default?

@gulshan commented on GitHub (Sep 25, 2019): Has there anything changed with the latest release? The "cascading settings" issue #754 is closed now. Can I just delete the settings file to reset to default?

claunia commented