starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Light mode in settings UI only #12662

New Issue
Closed
opened 2026-01-31 03:21:26 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 03:21:26 +00:00
Owner
Copy Link

Originally created by @Lombra on GitHub (Feb 20, 2021).

Description of the new feature/enhancement

Since my shells are all dark, it makes sense to use dark mode to get the dark title bar, however Windows' idea of dark mode design means the new settings UI is an eyesore. I would like to have the settings UI use light mode.

Originally created by @Lombra on GitHub (Feb 20, 2021). # Description of the new feature/enhancement Since my shells are all dark, it makes sense to use dark mode to get the dark title bar, however Windows' idea of dark mode design means the new settings UI is an eyesore. I would like to have the settings UI use light mode.
claunia commented 2026-01-31 03:21:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 22, 2021):

Okay, sure. I'll slap this into the megathread for "theming", #3327. Something like settingsUi.requestedTheme: light|dark|system. Why not.

@zadjii-msft commented on GitHub (Feb 22, 2021): Okay, sure. I'll slap this into the megathread for "theming", #3327. Something like `settingsUi.requestedTheme: light|dark|system`. Why not.
claunia commented 2026-01-31 03:21:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 6, 2023):

Note

Walkthrough

  • Start by adding a new Theme object for the settings UI:
    • SettingsTheme in Theme.idl, quite similar to WindowTheme in the same file
    • Add a single ElementTheme RequestedTheme to that runtimeclass.
    • In MTSMSettings.h, define a new MTSM_THEME_SETTINGS_SETTINGS, again taking cues from the tab row version. The key for this one should just be "settings"
    • Add a THEME_OBJECT(SettingsTheme, MTSM_THEME_SETTINGS_SETTINGS); to Theme.h
    • Add the sui theme to the other places theme objects appear in Theme.cpp as well.
  • Actually use this new setting
    • MainPage::_UpdateBackgroundForMica is probably the right place for this, as it's already trying to set the RequestedTheme for the settings page.
    • Instead, use the settings.requestedTheme, if it is set.
@zadjii-msft commented on GitHub (Feb 6, 2023): > **Note** > ## Walkthrough * [ ] Start by adding a new Theme object for the settings UI: * [ ] `SettingsTheme` in `Theme.idl`, quite similar to `WindowTheme` in the same file * [ ] Add a single `ElementTheme RequestedTheme` to that `runtimeclass`. * [ ] In `MTSMSettings.h`, define a new `MTSM_THEME_SETTINGS_SETTINGS`, again taking cues from the tab row version. The key for this one should just be `"settings"` * [ ] Add a `THEME_OBJECT(SettingsTheme, MTSM_THEME_SETTINGS_SETTINGS);` to `Theme.h` * [ ] Add the sui theme to the other places theme objects appear in Theme.cpp as well. * [ ] Actually use this new setting * [ ] `MainPage::_UpdateBackgroundForMica` is probably the right place for this, as it's already trying to set the `RequestedTheme` for the settings page. * [ ] Instead, use the `settings.requestedTheme`, if it is set.
claunia commented 2026-01-31 03:21:29 +00:00
Author
Owner
Copy Link

@bundgaard commented on GitHub (Oct 3, 2023):

Hello,

I am looking into this at the moment, but I hit a snag, where I am unsure if I should proceed or you might have some pointers to a better solution.

Just some background on my machine, I am running Windows 11 Pro Version 10.0.22621 Build 22621.
To make it work on my machine I had to remove the isMicaAvailable check in MainPage.cpp function ::_UpdateBackgroundForMica(). I tested to print out the value from the DwmGetWindowAttribute() and it always returns DWMSBT_NONE, therefore I removed the check for Mica.

I assume the isMicaAvailable check is there for a reason for backward compatibility?

Also I will remove the DebugOutputStringW() and the switch case, if we proceed with this.

@bundgaard commented on GitHub (Oct 3, 2023): Hello, I am looking into this at the moment, but I hit a snag, where I am unsure if I should proceed or you might have some pointers to a better solution. Just some background on my machine, I am running **Windows 11 Pro Version 10.0.22621 Build 22621**. To make it work on my machine I had to remove the `isMicaAvailable` check in MainPage.cpp function ```::_UpdateBackgroundForMica()```. I tested to print out the value from the DwmGetWindowAttribute() and it always returns `DWMSBT_NONE`, therefore I removed the check for Mica. I assume the `isMicaAvailable` check is there for a reason for backward compatibility? Also I will remove the DebugOutputStringW() and the switch case, if we proceed with this.
claunia commented 2026-01-31 03:21:29 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 3, 2023):

I assume the isMicaAvailable check is there for a reason for backward compatibility?

That was introduced in https://github.com/microsoft/terminal/pull/14675. That might have more context

(it's almost 5pm here so I can take a look deeper in the morning)

@zadjii-msft commented on GitHub (Oct 3, 2023): > I assume the isMicaAvailable check is there for a reason for backward compatibility? That was introduced in https://github.com/microsoft/terminal/pull/14675. That might have more context (it's almost 5pm here so I can take a look deeper in the morning)
claunia commented 2026-01-31 03:21:29 +00:00
Author
Owner
Copy Link

@Stromlight commented on GitHub (May 11, 2024):

Description of the new feature/enhancement

Since my shells are all dark, it makes sense to use dark mode to get the dark title bar, however Windows' idea of dark mode design means the new settings UI is an eyesore. I would like to have the settings UI use light mode.

I don't think dark and white mode had any good feature so far I use lots of app but I don't find it's better use then brightness.instead of dark and white mode what about adding overview of app so user can get must out of it .

@Stromlight commented on GitHub (May 11, 2024): > # Description of the new feature/enhancement > > Since my shells are all dark, it makes sense to use dark mode to get the dark title bar, however Windows' idea of dark mode design means the new settings UI is an eyesore. I would like to have the settings UI use light mode. I don't think dark and white mode had any good feature so far I use lots of app but I don't find it's better use then brightness.instead of dark and white mode what about adding overview of app so user can get must out of it .
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Area-Theming Help Wanted In-PR Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12662
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?