starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Accessibility regressions in the 21H1 inbox console #12678

New Issue
Closed
opened 2026-01-31 03:22:02 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 03:22:02 +00:00
Owner
Copy Link

Originally created by @codeofdusk on GitHub (Feb 21, 2021).

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] 19043.844
Windows Terminal version (if applicable): inbox conhost

Any other software? NVDA

Steps to reproduce

  1. Open inbox conhost.
  2. Press NVDA+control+z to open the Python console.
  3. Enter nav.is21H1Plus

Expected behavior

True is returned, as in OpenConsole commit 12b12d5b07.

Actual behavior

False is returned, as in 20H2 inbox, indicating a regression from #4495.

Additional context

For testing, I've replaced conhost with OpenConsole on my system, but reverted to inbox before applying the 21H1 update. Perhaps Windows Update didn't install the new inbox conhost on my system?

Originally created by @codeofdusk on GitHub (Feb 21, 2021). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] 19043.844 Windows Terminal version (if applicable): inbox conhost Any other software? NVDA ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> 1. Open inbox conhost. 2. Press NVDA+control+z to open the Python console. 3. Enter `nav.is21H1Plus` # Expected behavior `True` is returned, as in OpenConsole commit 12b12d5b078bb1ff2e7b3a1fd190cad889ef4225. <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior `False` is returned, as in 20H2 inbox, indicating a regression from #4495. <!-- What's actually happening? --> # Additional context For testing, I've replaced conhost with OpenConsole on my system, but reverted to inbox before applying the 21H1 update. Perhaps Windows Update didn't install the new inbox conhost on my system?
claunia added the Needs-TriageNeeds-Tag-Fix labels 2026-01-31 03:22:02 +00:00
claunia commented 2026-01-31 03:22:03 +00:00
Author
Owner
Copy Link

@codeofdusk commented on GitHub (Feb 21, 2021):

Cc @carlos-zamora.

@codeofdusk commented on GitHub (Feb 21, 2021): Cc @carlos-zamora.
claunia commented 2026-01-31 03:22:04 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 22, 2021):

Can you check the file version (right click, properties) for conhost.exe?

I am not sure how NVDA’s is21H1 function determines whether it is in fact 21H1... but I didn’t believe we had control over that.

Certainly we have made 0 changes to conhost in 21H1. I wasn’t even aware there was a 21H1 publicly available.

@DHowett commented on GitHub (Feb 22, 2021): Can you check the file version (right click, properties) for conhost.exe? I am not sure how NVDA’s `is21H1` function determines whether it is in fact 21H1... but I didn’t believe we had control over that. Certainly we have made 0 changes to conhost in 21H1. I wasn’t even aware there _was_ a 21H1 publicly available.
claunia commented 2026-01-31 03:22:04 +00:00
Author
Owner
Copy Link

@codeofdusk commented on GitHub (Feb 22, 2021):

See the implementation of is21H1Plus here.

21H1 inbox on my system is acting as if #4495 was never merged (obviously false) or regressed between the above-linked commit and shipment in Windows.

@codeofdusk commented on GitHub (Feb 22, 2021): See the implementation of `is21H1Plus` [here](https://github.com/nvaccess/nvda/blob/master/source/NVDAObjects/UIA/winConsoleUIA.py#L351). 21H1 inbox on my system is acting as if #4495 was never merged (obviously false) or regressed between the above-linked commit and shipment in Windows.
claunia commented 2026-01-31 03:22:04 +00:00
Author
Owner
Copy Link

@codeofdusk commented on GitHub (Feb 22, 2021):

Version number is 10.0.19641.746

@codeofdusk commented on GitHub (Feb 22, 2021): Version number is 10.0.19641.746
claunia commented 2026-01-31 03:22:04 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 22, 2021):

That doesn’t seem right. I’ll need to check the build when I get back to the office tomorrow, but 19641 corresponds to a version of Windows from two development cycles ago, numerically, and would not contain any of our recent UIA fixes.

Just so you know: 21H1 is a patch release from the servicing team, and they did not contact us about releasing any conhost changes. I have no reason to believe that the code in conhost 21H1 is any different from 20H1, which was the last non-patch upgrade that brought in a whole new tree of Windows code indiscriminately.

@DHowett commented on GitHub (Feb 22, 2021): That doesn’t seem right. I’ll need to check the build when I get back to the office tomorrow, but 19641 corresponds to a version of Windows from two development cycles ago, numerically, and would not contain any of our recent UIA fixes. Just so you know: 21H1 is a patch release from the servicing team, and they did not contact us about releasing any conhost changes. I have no reason to believe that the code in conhost 21H1 is any different from _20H1_, which was the last non-patch upgrade that brought in a whole new tree of Windows code indiscriminately.
claunia commented 2026-01-31 03:22:05 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 22, 2021):

The versions of Windows that take your computer down for 10-75 minutes and reboot three times tend to contain the entire development tree from the OS repository before they’re snapped. The builds that increment the UBR or patch version, or the ones that increment the main version by 1 (so, from 19041 to 19042 or 19043) are servicing updates that have hand-selected features backported into them. Since we were not hand-selected for those releases, no conhost changes are present in 20H2 or 21H1.

@DHowett commented on GitHub (Feb 22, 2021): The versions of Windows that take your computer down for 10-75 minutes and reboot three times tend to contain the entire development tree from the OS repository before they’re snapped. The builds that increment the UBR or patch version, or the ones that increment the main version by 1 (so, from 19041 to 19042 or 19043) are servicing updates that have hand-selected features backported into them. Since we were not hand-selected for those releases, no conhost changes are present in 20H2 or 21H1.
claunia commented 2026-01-31 03:22:05 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 22, 2021):

Discussed this with @codeofdusk off GitHub. The changes we were targeting for "21H1" did not get selected for the build that was released in the early half of 2021. We'll regroup here, but there's no regression per se. Just a lack of ... progression? I guess?

@DHowett commented on GitHub (Feb 22, 2021): Discussed this with @codeofdusk off GitHub. The changes we were targeting for "21H1" did not get selected for the build that was released in the early half of 2021. We'll regroup here, but there's no _regression_ per se. Just a lack of ... progression? I guess?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12678
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?