starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

DimensionsTests related to largest window fail on Core editions #1275

New Issue
Closed
opened 2026-01-30 22:20:46 +00:00 by claunia · 1 comment
claunia commented 2026-01-30 22:20:46 +00:00
Owner
Copy Link

Originally created by @miniksa on GitHub (May 23, 2019).

Originally assigned to: @miniksa on GitHub.

Ported from internal gates failures:

The following five tests are failing on Core editions:

DimensionsTests::TestSetConsoleScreenBufferSize#metadataSet2
DimensionsTests::TestSetConsoleScreenBufferSize#metadataSet1
DimensionsTests::TestSetConsoleScreenBufferSize#metadataSet0

DimensionsTests::TestSetConsoleWindowInfo#metadataSet0
DimensionsTests::TestSetConsoleWindowInfo#metadataSet1

I've investigated the issue and root caused it to PR 3129098 (prior to GitHub).

The problem is that on Core editions, the proposed font preferences and committed font choice stored in SCREEN_INFORMATION do not get synchronized with the actual font usage inside the rendering engine.

The reason this was working previously is because SCREEN_INFORMATION::GetScreenFontSize() was querying the render engine directly for the current font size.

@zadjii-msft realized that this seemed a bit silly given that SCREEN_INFORMATION already had a _currentFont which is supposed to hold the font selected for that screen post synchronization with the renderer. He therefore removed the supposedly duplicate lookup and I signed off on it thinking that it was a sensible thing to do. Turns out, it's only true on Desktop editions.

The solutions here would be:

  1. Return GetScreenFontSize() to look up the font sizing information from the renderer directly
  2. Figure out why the synchronization isn't happening between SCREEN_INFORMATION and the active rendering engine for Core editions and make it happen again
    • And maybe also make it harder for this to be a problem in the future by adjusting the set-up phase to fail with an error if synchronization doesn't happen prior to the first paint calls.

I prefer option 2, of course. The de-duplication was righteous; it just had a pitfall.

Originally created by @miniksa on GitHub (May 23, 2019). Originally assigned to: @miniksa on GitHub. Ported from internal gates failures: The following five tests are failing on Core editions: DimensionsTests::TestSetConsoleScreenBufferSize#metadataSet2 DimensionsTests::TestSetConsoleScreenBufferSize#metadataSet1 DimensionsTests::TestSetConsoleScreenBufferSize#metadataSet0 DimensionsTests::TestSetConsoleWindowInfo#metadataSet0 DimensionsTests::TestSetConsoleWindowInfo#metadataSet1 I've investigated the issue and root caused it to PR 3129098 (prior to GitHub). The problem is that on Core editions, the proposed font preferences and committed font choice stored in `SCREEN_INFORMATION` do not get synchronized with the actual font usage inside the rendering engine. The reason this was working previously is because `SCREEN_INFORMATION::GetScreenFontSize()` was querying the render engine directly for the current font size. @zadjii-msft realized that this seemed a bit silly given that `SCREEN_INFORMATION` already had a `_currentFont` which is supposed to hold the font selected for that screen post synchronization with the renderer. He therefore removed the supposedly duplicate lookup and I signed off on it thinking that it was a sensible thing to do. Turns out, it's only true on Desktop editions. The solutions here would be: 1. Return `GetScreenFontSize()` to look up the font sizing information from the renderer directly 2. Figure out why the synchronization isn't happening between `SCREEN_INFORMATION` and the active rendering engine for Core editions and make it happen again - And maybe also make it harder for this to be a problem in the future by adjusting the set-up phase to fail with an error if synchronization doesn't happen prior to the first paint calls. I prefer option 2, of course. The de-duplication was righteous; it just had a pitfall.
claunia added the Product-ConhostArea-RenderingIssue-BugNeeds-Tag-Fix labels 2026-01-30 22:20:46 +00:00
claunia commented 2026-01-30 22:20:47 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (May 31, 2019):

I completed this on the OS side today. It needs to replicate out.

@miniksa commented on GitHub (May 31, 2019): I completed this on the OS side today. It needs to replicate out.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Needs-Tag-Fix Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1275
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?