starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

WriteConsoleOutputWOutsideBuffer test fails occasionally #1282

New Issue
Open
opened 2026-01-30 22:20:58 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 22:20:58 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (May 23, 2019).

@miniksa do you know why this test keeps failing?
https://dev.azure.com/ms/Terminal/_build/results?buildId=16264


Passed   BasicWriteConsoleOutputATest
Win32BoolSucceeded(SetConsoleWindowInfo(consoleOutputHandle, true, &window)) - Value (6)
Failed   WriteConsoleOutputWOutsideBuffer
Error Message:
 Win32BoolSucceeded(SetConsoleWindowInfo(consoleOutputHandle, true, &window)) - Value (6)
Stack Trace:
at OutputTests::WriteConsoleOutputWOutsideBuffer() in d:\a\1\s\src\host\ft_host\api_outputtests.cpp:line 140
Standard Output Messages:
 Win32BoolSucceeded(CloseHandle(_hConsole)): Removing our test screen buffer.
 Restoring v1/v2 console state to original '1'
 Win32BoolFailed(RegSetValueExW(_consoleKey.get(), pwszForceV2ValueName, 0, REG_DWORD, (LPBYTE)&_dwForceV2Original, sizeof(_dwForceV2Original)))
 AreEqual(ERROR_SUCCESS, lstatus)
 Backing up v1/v2 console state.
 Win32BoolFailed(lstatus): Assert querying ForceV2 key was successful.
 Setting v1/v2 console state to desired '1'
 Win32BoolFailed(RegSetValueExW(_consoleKey.get(), pwszForceV2ValueName, 0, REG_DWORD, (LPBYTE)&ForceV2StateDesired, sizeof(ForceV2StateDesired)))
 SUCCEEDED(RuntimeParameters::TryGetValue(L"TestDeploymentDir", value))
 SUCCEEDED(StringCchCopyW(str, cchNeeded, (WCHAR*)value.GetBuffer()))
 Win32BoolSucceeded(nullptr != hJob)
 Win32BoolSucceeded(SetInformationJobObject(hJob.get(), JobObjectExtendedLimitInformation, &JobLimits, sizeof(JobLimits)))
 Win32BoolSucceeded(CreateProcessW(nullptr, str, nullptr, nullptr, FALSE, CREATE_NEW_CONSOLE | CREATE_SUSPENDED, nullptr, nullptr, &si, pi.addressof()))
 Win32BoolSucceeded(AssignProcessToJobObject(hJob.get(), pi.hProcess))
 Win32BoolSucceeded(-1 != ResumeThread(pi.hThread))
 IsLessThan(dwTotalWait, _dwMaxMillisecondsToWaitOnStartup)
 IsNotNull(pPidList)
 Win32BoolSucceeded(QueryInformationJobObject(hJob.get(), JobObjectBasicProcessIdList, pPidList, cbRequired, nullptr))
 AreEqual(pids.NumberOfAssignedProcesses, pPidList->NumberOfProcessIdsInList)
 AreNotEqual(0u, dwFindPid)
 Win32BoolSucceeded(FreeConsole())
 Win32BoolSucceeded(AttachConsole(dwFindPid))
 AreEqual(0, err)
 AreEqual(0, err)
 AreNotEqual(_hConsole, INVALID_HANDLE_VALUE): Creating our test screen buffer.
 Win32BoolSucceeded(SetConsoleActiveScreenBuffer(_hConsole)): Applying test screen buffer to console
 ***********	WriteConsoleOutputWOutsideBuffer - Test Start		***********
 
 Win32BoolSucceeded(SetConsoleWindowInfo(consoleOutputHandle, true, &window)) - Value (6)
 
 ***********	WriteConsoleOutputWOutsideBuffer - Test End		***********
 ***********	WriteConsoleOutputWOutsideBuffer - Test Failed	***********

Originally posted by @zadjii-msft in https://github.com/microsoft/terminal/pull/924#issuecomment-494911471

Originally created by @zadjii-msft on GitHub (May 23, 2019). @miniksa do you know why this test keeps failing? https://dev.azure.com/ms/Terminal/_build/results?buildId=16264 ``` Passed BasicWriteConsoleOutputATest Win32BoolSucceeded(SetConsoleWindowInfo(consoleOutputHandle, true, &window)) - Value (6) Failed WriteConsoleOutputWOutsideBuffer Error Message: Win32BoolSucceeded(SetConsoleWindowInfo(consoleOutputHandle, true, &window)) - Value (6) Stack Trace: at OutputTests::WriteConsoleOutputWOutsideBuffer() in d:\a\1\s\src\host\ft_host\api_outputtests.cpp:line 140 Standard Output Messages: Win32BoolSucceeded(CloseHandle(_hConsole)): Removing our test screen buffer. Restoring v1/v2 console state to original '1' Win32BoolFailed(RegSetValueExW(_consoleKey.get(), pwszForceV2ValueName, 0, REG_DWORD, (LPBYTE)&_dwForceV2Original, sizeof(_dwForceV2Original))) AreEqual(ERROR_SUCCESS, lstatus) Backing up v1/v2 console state. Win32BoolFailed(lstatus): Assert querying ForceV2 key was successful. Setting v1/v2 console state to desired '1' Win32BoolFailed(RegSetValueExW(_consoleKey.get(), pwszForceV2ValueName, 0, REG_DWORD, (LPBYTE)&ForceV2StateDesired, sizeof(ForceV2StateDesired))) SUCCEEDED(RuntimeParameters::TryGetValue(L"TestDeploymentDir", value)) SUCCEEDED(StringCchCopyW(str, cchNeeded, (WCHAR*)value.GetBuffer())) Win32BoolSucceeded(nullptr != hJob) Win32BoolSucceeded(SetInformationJobObject(hJob.get(), JobObjectExtendedLimitInformation, &JobLimits, sizeof(JobLimits))) Win32BoolSucceeded(CreateProcessW(nullptr, str, nullptr, nullptr, FALSE, CREATE_NEW_CONSOLE | CREATE_SUSPENDED, nullptr, nullptr, &si, pi.addressof())) Win32BoolSucceeded(AssignProcessToJobObject(hJob.get(), pi.hProcess)) Win32BoolSucceeded(-1 != ResumeThread(pi.hThread)) IsLessThan(dwTotalWait, _dwMaxMillisecondsToWaitOnStartup) IsNotNull(pPidList) Win32BoolSucceeded(QueryInformationJobObject(hJob.get(), JobObjectBasicProcessIdList, pPidList, cbRequired, nullptr)) AreEqual(pids.NumberOfAssignedProcesses, pPidList->NumberOfProcessIdsInList) AreNotEqual(0u, dwFindPid) Win32BoolSucceeded(FreeConsole()) Win32BoolSucceeded(AttachConsole(dwFindPid)) AreEqual(0, err) AreEqual(0, err) AreNotEqual(_hConsole, INVALID_HANDLE_VALUE): Creating our test screen buffer. Win32BoolSucceeded(SetConsoleActiveScreenBuffer(_hConsole)): Applying test screen buffer to console *********** WriteConsoleOutputWOutsideBuffer - Test Start *********** Win32BoolSucceeded(SetConsoleWindowInfo(consoleOutputHandle, true, &window)) - Value (6) *********** WriteConsoleOutputWOutsideBuffer - Test End *********** *********** WriteConsoleOutputWOutsideBuffer - Test Failed *********** ``` _Originally posted by @zadjii-msft in https://github.com/microsoft/terminal/pull/924#issuecomment-494911471_
claunia added the Help WantedProduct-ConhostIssue-BugNeeds-Tag-FixArea-Build labels 2026-01-30 22:20:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Help Wanted Issue-Bug Needs-Tag-Fix Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1282
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?