starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add option to disable the tab switcher popup while keeping tab switcher nextTab semantics #12874

New Issue
Open
opened 2026-01-31 03:27:39 +00:00 by claunia · 13 comments
claunia commented 2026-01-31 03:27:39 +00:00
Owner
Copy Link

Originally created by @mg-christian-esser on GitHub (Mar 5, 2021).

Description of the new feature/enhancement

Having configured "tabSwitcherMode": "mru" I can not find an option to hide the (in my opinion distracting) tab switcher popup.

What I want is just MRU semantics on nextTab (especially when/if #9330 gets fixed) and no UI popup flashing by. If that can be achieved with "tabSwitcherMode": "disabled" that would be preferred.

Proposed technical implementation details (optional)

Assuming the tab switcher is the only way to get MRU semantics when using nextTab, a new configuration key to control visibility of the tab switcher popup, e.g. "showTabSwitcherInterface": true|false (default: true).

Originally created by @mg-christian-esser on GitHub (Mar 5, 2021). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> Having configured `"tabSwitcherMode": "mru"` I can not find an option to hide the (in my opinion distracting) tab switcher popup. What I want is just MRU semantics on `nextTab` (especially when/if #9330 gets fixed) and no UI popup flashing by. If that can be achieved with `"tabSwitcherMode": "disabled"` that would be preferred. # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. --> Assuming the tab switcher is the only way to get MRU semantics when using `nextTab`, a new configuration key to control visibility of the tab switcher popup, e.g. `"showTabSwitcherInterface": true|false` (default: `true`).
claunia added the Issue-TaskProduct-TerminalArea-UserInterface labels 2026-01-31 03:27:39 +00:00
claunia commented 2026-01-31 03:27:40 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Mar 5, 2021):

Huh, a new option named "mruNoUI" ? That's gonna confuse bunch of people.

@skyline75489 commented on GitHub (Mar 5, 2021): Huh, a new option named "mruNoUI" ? That's gonna confuse bunch of people.
claunia commented 2026-01-31 03:27:40 +00:00
Author
Owner
Copy Link

@mg-christian-esser commented on GitHub (Mar 8, 2021):

I agree it's confusing. Perhaps it's having the nextTab MRU behavior tied to the tab switcher is that is the main issue.

@mg-christian-esser commented on GitHub (Mar 8, 2021): I agree it's confusing. Perhaps it's having the `nextTab` MRU behavior tied to the tab switcher is that is the main issue.
claunia commented 2026-01-31 03:27:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 8, 2021):

I would love to implement MRU switching without the UI.

However, that's a much harder problem than you might expect. The way our keybindings are currently hooked up, if you were to do a nextTab action in MRU order, without the UI, then we'd have no good way of not updating the MRU stack while pressing the keys. (I'm now realizing this is hard to explain in text).

Basically, as you perform nextTab actions, we'll update the MRU stack. The UI lets us not actually perform the nextTab action until you release all the keys. So while you're using the UI, we're not updating the stack. If there wasn't a UI, then we'd update the stack immediately. So if you have four tabs, [a, b, c, d], and tried to switch from a to b, the stack would now be [b, a, c, d]. The next MRU nextTab would get you a again. So you'd only be able to flip between the two most recent tabs.

Obviously this isn't great, and we want to fix that. That's just the long-winded explanation of why we haven't yet.

@zadjii-msft commented on GitHub (Mar 8, 2021): I would _love_ to implement MRU switching without the UI. _However_, that's a much harder problem than you might expect. The way our keybindings are currently hooked up, if you were to do a `nextTab` action in MRU order, without the UI, then we'd have no good way of _not_ updating the MRU stack while pressing the keys. (I'm now realizing this is hard to explain in text). Basically, as you perform nextTab actions, we'll update the MRU stack. The UI lets us _not_ actually perform the nextTab action until you release all the keys. So while you're using the UI, we're not updating the stack. If there wasn't a UI, then we'd update the stack immediately. So if you have four tabs, `[a, b, c, d]`, and tried to switch from `a` to `b`, the stack would now be `[b, a, c, d]`. The _next_ MRU nextTab would get you _`a` again_. So you'd only be able to flip between the two most recent tabs. Obviously this isn't great, and we want to fix that. That's just the long-winded explanation of why we haven't yet.
claunia commented 2026-01-31 03:27:40 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Mar 8, 2021):

Would it be possible to let the tab switcher popup get the focus and handle the keyboard events but keep it invisible? I imagine that might cause surprising effects for accessibility software.

@KalleOlaviNiemitalo commented on GitHub (Mar 8, 2021): Would it be possible to let the tab switcher popup get the focus and handle the keyboard events but keep it invisible? I imagine that might cause surprising effects for accessibility software.
claunia commented 2026-01-31 03:27:40 +00:00
Author
Owner
Copy Link

@mg-christian-esser commented on GitHub (Mar 10, 2021):

Basically, as you perform nextTab actions, we'll update the MRU stack. The UI lets us not actually perform the nextTab action until you release all the keys. So while you're using the UI, we're not updating the stack. If there wasn't a UI, then we'd update the stack immediately. So if you have four tabs, [a, b, c, d], and tried to switch from a to b, the stack would now be [b, a, c, d]. The next MRU nextTab would get you a again. So you'd only be able to flip between the two most recent tabs.

Obviously this isn't great, and we want to fix that. That's just the long-winded explanation of why we haven't yet.

Without actually reading the code I think the explanation makes sense. But it feels far from ideal to have the UI work around limitations in the keybinding code.

@mg-christian-esser commented on GitHub (Mar 10, 2021): > Basically, as you perform nextTab actions, we'll update the MRU stack. The UI lets us _not_ actually perform the nextTab action until you release all the keys. So while you're using the UI, we're not updating the stack. If there wasn't a UI, then we'd update the stack immediately. So if you have four tabs, `[a, b, c, d]`, and tried to switch from `a` to `b`, the stack would now be `[b, a, c, d]`. The _next_ MRU nextTab would get you _`a` again_. So you'd only be able to flip between the two most recent tabs. > > Obviously this isn't great, and we want to fix that. That's just the long-winded explanation of why we haven't yet. Without actually reading the code I think the explanation makes sense. But it feels far from ideal to have the UI work around limitations in the keybinding code.
claunia commented 2026-01-31 03:27:40 +00:00
Author
Owner
Copy Link

@mg-christian-esser commented on GitHub (Mar 10, 2021):

Thinking a bit more about this, perhaps it's actually the look of UI itself that is the problem for me. Instead of showing a popup how about highlighting the tab (perhaps using the effect as when you hover a tab) that the user would switch to upon release of the hotkey?

@mg-christian-esser commented on GitHub (Mar 10, 2021): Thinking a bit more about this, perhaps it's actually the look of UI itself that is the problem for me. Instead of showing a popup how about highlighting the tab (perhaps using the effect as when you hover a tab) that the user would switch to upon release of the hotkey?
claunia commented 2026-01-31 03:27:41 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Mar 10, 2021):

I would love to implement MRU switching without the UI.

However, that's a much harder problem than you might expect. The way our keybindings are currently hooked up, if you were to do a nextTab action in MRU order, without the UI, then we'd have no good way of not updating the MRU stack while pressing the keys. (I'm now realizing this is hard to explain in text).

Basically, as you perform nextTab actions, we'll update the MRU stack. The UI lets us not actually perform the nextTab action until you release all the keys. So while you're using the UI, we're not updating the stack. If there wasn't a UI, then we'd update the stack immediately. So if you have four tabs, [a, b, c, d], and tried to switch from a to b, the stack would now be [b, a, c, d]. The next MRU nextTab would get you a again. So you'd only be able to flip between the two most recent tabs.

Obviously this isn't great, and we want to fix that. That's just the long-winded explanation of why we haven't yet.

@zadjii-msft - probably we can unify this one with https://github.com/microsoft/terminal/issues/9330. Both have the same theme: decouple between the switch order and if the tab switcher should be visible or not.

@KalleOlaviNiemitalo - I am not sure it is good approach to show invisible palette. We just need to capture anchor in the terminal page.

@zadjii-msft - can we do something like:

  • _UpdateMRUTab will do nothing if modifier key is pressed
  • KeyUpHandler: if the key is modifier (and there are no modifiers left) and the current tab is not in MRU top, then put it on top
    Of course thils will work, only if there is an anchor key for tab switching
@Don-Vito commented on GitHub (Mar 10, 2021): > > > I would _love_ to implement MRU switching without the UI. > > _However_, that's a much harder problem than you might expect. The way our keybindings are currently hooked up, if you were to do a `nextTab` action in MRU order, without the UI, then we'd have no good way of _not_ updating the MRU stack while pressing the keys. (I'm now realizing this is hard to explain in text). > > Basically, as you perform nextTab actions, we'll update the MRU stack. The UI lets us _not_ actually perform the nextTab action until you release all the keys. So while you're using the UI, we're not updating the stack. If there wasn't a UI, then we'd update the stack immediately. So if you have four tabs, `[a, b, c, d]`, and tried to switch from `a` to `b`, the stack would now be `[b, a, c, d]`. The _next_ MRU nextTab would get you _`a` again_. So you'd only be able to flip between the two most recent tabs. > > Obviously this isn't great, and we want to fix that. That's just the long-winded explanation of why we haven't yet. @zadjii-msft - probably we can unify this one with https://github.com/microsoft/terminal/issues/9330. Both have the same theme: decouple between the switch order and if the tab switcher should be visible or not. @KalleOlaviNiemitalo - I am not sure it is good approach to show invisible palette. We just need to capture anchor in the terminal page. @zadjii-msft - can we do something like: * _UpdateMRUTab will do nothing if modifier key is pressed * KeyUpHandler: if the key is modifier (and there are no modifiers left) and the current tab is not in MRU top, then put it on top Of course thils will work, only if there is an anchor key for tab switching
claunia commented 2026-01-31 03:27:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 10, 2021):

Meh, I'd almost leave the threads decoupled, just because each thread does have it's own problem it is trying to solve. Like we can add the args to #9390 without fixing the "no UI for MRU switching" issue. They're seemingly converging, but still we could fix this issue before we add the args to next/prevTab, then now we need to find out how to express globally "I want mru tab switching without the UI".

Of course this will work, only if there is an anchor key for tab switching

And that's maybe part of the issue. I feel like I remember someone wanting tab switching on something like F11 & F12.

@zadjii-msft commented on GitHub (Mar 10, 2021): Meh, I'd almost leave the threads decoupled, just because each thread does have it's own problem it is trying to solve. Like we can add the args to #9390 without fixing the "no UI for MRU switching" issue. They're seemingly converging, but still we could fix this issue before we add the args to `next/prevTab`, then now we need to find out how to express _globally_ "I want mru tab switching without the UI". > Of course this will work, only if there is an anchor key for tab switching And that's maybe part of the issue. I feel like I remember someone wanting tab switching on something like F11 & F12.
claunia commented 2026-01-31 03:27:41 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Mar 10, 2021):

And that's maybe part of the issue. I feel like I remember someone wanting tab switching on something like F11 & F12.

But this will not work with tab switcher today as well.

@Don-Vito commented on GitHub (Mar 10, 2021): > And that's maybe part of the issue. I feel like I remember someone wanting tab switching on something like F11 & F12. But this will not work with tab switcher today as well.
claunia commented 2026-01-31 03:27:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 10, 2021):

But this will not work with tab switcher today as well.

That's a good point. Yea that might work.

@zadjii-msft commented on GitHub (Mar 10, 2021): > But this will not work with tab switcher today as well. ![](https://media.giphy.com/media/3o7TKTDn976rzVgky4/giphy.gif) That's a good point. Yea that might work.
claunia commented 2026-01-31 03:27:42 +00:00
Author
Owner
Copy Link

@farhansolodev commented on GitHub (Jun 3, 2023):

_UpdateMRUTab will do nothing if modifier key is pressed
KeyUpHandler: if the key is modifier (and there are no modifiers left) and the current tab is not in MRU top, then put it on top
Of course thils will work, only if there is an anchor key for tab switching

Have there been any developments on this front?

@farhansolodev commented on GitHub (Jun 3, 2023): > _UpdateMRUTab will do nothing if modifier key is pressed > KeyUpHandler: if the key is modifier (and there are no modifiers left) and the current tab is not in MRU top, then put it on top > Of course thils will work, only if there is an anchor key for tab switching Have there been any developments on this front?
claunia commented 2026-01-31 03:27:42 +00:00
Author
Owner
Copy Link

@M43R commented on GitHub (May 5, 2024):

"I want mru tab switching without the UI", plz add this feature.

@M43R commented on GitHub (May 5, 2024): "I want mru tab switching without the UI", plz add this feature.
claunia commented 2026-01-31 03:27:42 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 6, 2024):

@M43R the best way to show your support for this issue is by hitting the 👍 button on this issue

image

That way, you avoid unnecessarily pinging everyone following this thread. Thanks!

@zadjii-msft commented on GitHub (May 6, 2024): @M43R the best way to show your support for this issue is by hitting the 👍 button on this issue ![image](https://user-images.githubusercontent.com/18356694/96140789-ef3c8880-0ec5-11eb-82e0-30ce4977b9a7.png) That way, you avoid unnecessarily pinging everyone following this thread. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12874
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?