Allow Profile Icon to reference an executable #12966

Closed
opened 2026-01-31 03:30:11 +00:00 by claunia · 4 comments
Owner

Originally created by @MarkIngramUK on GitHub (Mar 11, 2021).

Description of the new feature/enhancement

I've just added a profile for the "x64 Native Tools Command Prompt for VS2019", using the following:

        {
            "guid": "{70903acb-55e7-41c4-9480-70fae317ba9b}",
            "name": "VS Tools",
            "commandline": "%comspec% /k \"C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Auxiliary\\Build\\vcvars64.bat\""
        },

I would like to change the default icon to be the VS icon so I can quickly differentiate between that, and the regular cmd profile.

Proposed technical implementation details

Given a path to an executable, I suggest looking for the first available icon in the resources:

"icon": "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\Common7\\IDE\\devenv.exe"

devenv.exe contains 5 icons, so an additional option may be useful to allow an index or ID to be specified:

Load icon at index 2:

"icon": "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\Common7\\IDE\\devenv.exe,2"

Load icon with ID 1203:

"icon": "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\Common7\\IDE\\devenv.exe,@1203"
Originally created by @MarkIngramUK on GitHub (Mar 11, 2021). # Description of the new feature/enhancement I've just added a profile for the "x64 Native Tools Command Prompt for VS2019", using the following: ``` { "guid": "{70903acb-55e7-41c4-9480-70fae317ba9b}", "name": "VS Tools", "commandline": "%comspec% /k \"C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Auxiliary\\Build\\vcvars64.bat\"" }, ``` I would like to change the default icon to be the VS icon so I can quickly differentiate between that, and the regular `cmd` profile. # Proposed technical implementation details Given a path to an executable, I suggest looking for the first available icon in the resources: ``` "icon": "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\Common7\\IDE\\devenv.exe" ``` `devenv.exe` contains 5 icons, so an additional option may be useful to allow an index or ID to be specified: Load icon at index 2: ``` "icon": "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\Common7\\IDE\\devenv.exe,2" ``` Load icon with ID 1203: ``` "icon": "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\Common7\\IDE\\devenv.exe,@1203" ```
claunia added the Issue-FeatureResolution-Duplicate labels 2026-01-31 03:30:11 +00:00
Author
Owner

@Don-Vito commented on GitHub (Mar 11, 2021):

@MarkIngramUK - please see https://github.com/microsoft/terminal/issues/1504

@Don-Vito commented on GitHub (Mar 11, 2021): @MarkIngramUK - please see https://github.com/microsoft/terminal/issues/1504
Author
Owner

@MarkIngramUK commented on GitHub (Mar 11, 2021):

Apologies, I did try searching 🤦🏻‍♂️

@MarkIngramUK commented on GitHub (Mar 11, 2021): Apologies, I did try searching 🤦🏻‍♂️
Author
Owner

@zadjii-msft commented on GitHub (Mar 11, 2021):

/dup #1504

@zadjii-msft commented on GitHub (Mar 11, 2021): /dup #1504
Author
Owner

@ghost commented on GitHub (Mar 11, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Mar 11, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12966