starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[REGRESSION] Multi-click selection broken in main #12974

New Issue
Closed
opened 2026-01-31 03:30:23 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 03:30:23 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Mar 11, 2021).

Originally assigned to: @Don-Vito on GitHub.

IN RETROSPECT: I don't think this is right. We might have lost the case where there's no selection, and you double/triple click on a word

@Don-Vito as an fyi

Originally posted by @zadjii-msft in https://github.com/microsoft/terminal/pull/9403#r592604796

Originally created by @zadjii-msft on GitHub (Mar 11, 2021). Originally assigned to: @Don-Vito on GitHub. IN RETROSPECT: I don't think this is right. We might have lost the case where there's no selection, and you double/triple click on a word @Don-Vito as an fyi _Originally posted by @zadjii-msft in https://github.com/microsoft/terminal/pull/9403#r592604796_
claunia commented 2026-01-31 03:30:25 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Mar 11, 2021):

I may stage a revert for this until we can get it in and get it right.

I'd like to see manual test runs for the following scenarios:

  • single click = no selection
  • single click and drag = selection starting from first point
  • single click in unfocused pane and drag = focus pane, selection starting from first point
  • double-click = selects a whole word
  • triple-click = selects a whole line
  • double-click and drag = selects a whole word, drag selects whole words
  • triple-click and drag = selects a whole line, drag selects whole lines
  • Shift single-click = defines start point
  • second Shift single-click = defines end point
  • Shift double-click = selects entire word
  • Shift triple-click = selects entire line
  • Shift double-click and drag = selects entire word, drag selects whole words
  • Shift triple-click and drag = selects entire line, drag selects whole lines
@DHowett commented on GitHub (Mar 11, 2021): I may stage a revert for this until we can get it in and get it right. I'd like to see manual test runs for the following scenarios: * [ ] single click = no selection * [ ] single click and drag = selection starting from first point * [ ] single click in unfocused pane and drag = focus pane, selection starting from first point * [ ] double-click = selects a whole word * [ ] triple-click = selects a whole line * [ ] double-click and drag = selects a whole word, drag selects whole words * [ ] triple-click and drag = selects a whole line, drag selects whole lines * [ ] <kbd>Shift</kbd> single-click = defines start point * [ ] second <kbd>Shift</kbd> single-click = defines end point * [ ] <kbd>Shift</kbd> double-click = selects entire word * [ ] <kbd>Shift</kbd> triple-click = selects entire line * [ ] <kbd>Shift</kbd> double-click and drag = selects entire word, drag selects whole words * [ ] <kbd>Shift</kbd> triple-click and drag = selects entire line, drag selects whole lines
claunia commented 2026-01-31 03:30:26 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Mar 11, 2021):

@DHowett, @zadjii-msft - can you explain what is broken? I am quite sure I tested this case.

Also I am afraid that the selection was more broken before this fix.

@Don-Vito commented on GitHub (Mar 11, 2021): @DHowett, @zadjii-msft - can you explain what is broken? I am quite sure I tested this case. Also I am afraid that the selection was more broken before this fix.
claunia commented 2026-01-31 03:30:26 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Mar 11, 2021):

So, when I double-click select something on main, I get ... no selection :(

@DHowett commented on GitHub (Mar 11, 2021): So, when I double-click select something on `main`, I get ... no selection :(
claunia commented 2026-01-31 03:30:26 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Mar 11, 2021):

So, when I double-click select something on main, I get ... no selection :(

OK. I see. I will fix it today. and also run all the tests you mentioned.

The previous version is not working with shift+double-click, so it is equally broken.

Please assign to me

@Don-Vito commented on GitHub (Mar 11, 2021): > > > So, when I double-click select something on `main`, I get ... no selection :( OK. I see. I will fix it today. and also run all the tests you mentioned. The previous version is not working with shift+double-click, so it is equally broken. Please assign to me
claunia commented 2026-01-31 03:30:27 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Mar 11, 2021):

Thanks 😄

@DHowett commented on GitHub (Mar 11, 2021): Thanks :smile:
claunia commented 2026-01-31 03:30:27 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Mar 11, 2021):

I mean it should be a one-liner. I simply forgot that shift is not required for multi-selection :)

@Don-Vito commented on GitHub (Mar 11, 2021): I mean it should be a one-liner. I simply forgot that shift is not required for multi-selection :)
claunia commented 2026-01-31 03:30:27 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Mar 11, 2021):

Sorry for missing the scenario without shift 👼
Wondering if there is a good way to add UT for this one

@Don-Vito commented on GitHub (Mar 11, 2021): Sorry for missing the scenario without shift 👼 Wondering if there is a good way to add UT for this one
claunia commented 2026-01-31 03:30:27 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 11, 2021):

Yea the unittesting scenario for the TerminalControl binary is awful. Fixing that is what I'm actually working on today, because we've got to do something about it.

@zadjii-msft commented on GitHub (Mar 11, 2021): Yea the unittesting scenario for the TerminalControl binary is awful. Fixing that is what I'm actually working on today, because we've _got to do something about it_.
claunia commented 2026-01-31 03:30:27 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 14, 2021):

:tada:This issue was addressed in #9455, which has now been successfully released as Windows Terminal v1.7.1033.0.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:This issue was addressed in #9455, which has now been successfully released as `Windows Terminal v1.7.1033.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.7.1033.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 03:30:28 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 14, 2021):

:tada:This issue was addressed in #9455, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:This issue was addressed in #9455, which has now been successfully released as `Windows Terminal Preview v1.8.1032.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1032.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Issue-Bug Product-Terminal Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12974
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?