starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Ctrl+Insert does not copy the selected text from Command Palette #13067

New Issue
Closed
opened 2026-01-31 03:32:44 +00:00 by claunia · 11 comments
claunia commented 2026-01-31 03:32:44 +00:00
Owner
Copy Link

Originally created by @KalleOlaviNiemitalo on GitHub (Mar 17, 2021).

Environment

Windows build number: 10.0.19042.867
Windows Terminal version (if applicable): 1.6.10571.0

Steps to reproduce

  1. Delete any saved Windows Terminal settings.
  2. Start Windows Terminal.
  3. Use the mouse to select some text in the pane.
  4. Press Ctrl+Shift+P to open the command palette.
  5. Type abc.
  6. Press Ctrl+A to select the text abc.
  7. Press Ctrl+Insert.

Expected behavior

The text abc should be copied to the clipboard, and the command palette should remain open.

Actual behavior

The command palette closes, and the text that you selected in the pane is copied to the clipboard.

Notes

If you copy by pressing Ctrl+C instead of Ctrl+Insert, then it works as expected.

Originally created by @KalleOlaviNiemitalo on GitHub (Mar 17, 2021). # Environment ```none Windows build number: 10.0.19042.867 Windows Terminal version (if applicable): 1.6.10571.0 ``` # Steps to reproduce 1. Delete any saved Windows Terminal settings. 2. Start Windows Terminal. 3. Use the mouse to select some text in the pane. 4. Press Ctrl+Shift+P to open the command palette. 5. Type `abc`. 6. Press Ctrl+A to select the text `abc`. 7. Press Ctrl+Insert. # Expected behavior The text `abc` should be copied to the clipboard, and the command palette should remain open. # Actual behavior The command palette closes, and the text that you selected in the pane is copied to the clipboard. # Notes If you copy by pressing Ctrl+C instead of Ctrl+Insert, then it works as expected.
claunia commented 2026-01-31 03:32:46 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Mar 17, 2021):

I see, https://github.com/microsoft/terminal/pull/9056 added special handling for Ctrl+C and Ctrl+V in the command palette, but not for Ctrl+Insert and Shift+Insert.

@KalleOlaviNiemitalo commented on GitHub (Mar 17, 2021): I see, <https://github.com/microsoft/terminal/pull/9056> added special handling for Ctrl+C and Ctrl+V in the command palette, but not for Ctrl+Insert and Shift+Insert.
claunia commented 2026-01-31 03:32:46 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 17, 2021):

Wait holy what now - Does ctrl+Ins just work (pretty much) everywhere in the OS? I did not know that. TIL! That sems like an easy enough fix.

@zadjii-msft commented on GitHub (Mar 17, 2021): Wait holy _what now_ - Does <kbd>ctrl+Ins</kbd> just work (pretty much) everywhere in the OS? I did _not_ know that. TIL! That sems like an easy enough fix.
claunia commented 2026-01-31 03:32:46 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Mar 17, 2021):

Wikipedia lists Ctrl+Insert copying as being part of the IBM Common User Access standard.

@KalleOlaviNiemitalo commented on GitHub (Mar 17, 2021): Wikipedia lists Ctrl+Insert copying as being part of the [IBM Common User Access](https://en.wikipedia.org/wiki/IBM_Common_User_Access) standard.
claunia commented 2026-01-31 03:32:46 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Mar 17, 2021):

We have got to figure out what to do about key bindings and how they impact or do not impact certain scopes.

@DHowett commented on GitHub (Mar 17, 2021): We have _got_ to figure out what to do about key bindings and how they impact or do not impact certain scopes.
claunia commented 2026-01-31 03:32:46 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Mar 17, 2021):

I'm inclined to reject a pull request at this point that adds a fourth band-aid to the command palette (AND THE SEARCH BOX) by introducing another "did the user press THIS key?" check.

@DHowett commented on GitHub (Mar 17, 2021): I'm inclined to reject a pull request at this point that adds a fourth band-aid to the command palette (AND THE SEARCH BOX) by introducing another "did the user press THIS key?" check.
claunia commented 2026-01-31 03:32:47 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Mar 17, 2021):

Maybe the precedence could depend on the action to which the key is bound.

@KalleOlaviNiemitalo commented on GitHub (Mar 17, 2021): Maybe the precedence could depend on the action to which the key is bound.
claunia commented 2026-01-31 03:32:47 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Mar 23, 2021):

What a headache. Everything starts with us not getting some keys in KeyDown handler (as they get handled by inner controls). As a result we register to PreviewKeyDown, that propagates top down. And this gives the key bindings a priority over the controls (e.g., ctrl+c key binding would get priority over ctrl+c in search box). To address this we have added special flows in the PreviewKeyDown handler, covering ctr+c, but not ctrl+insert (which I would expect to work if it was not bound).

As Dustin mentioned we need to find a good approach.

I really don't understand the decision not to bubble up some keys.

@Don-Vito commented on GitHub (Mar 23, 2021): What a headache. Everything starts with us not getting some keys in KeyDown handler (as they get handled by inner controls). As a result we register to PreviewKeyDown, that propagates top down. And this gives the key bindings a priority over the controls (e.g., ctrl+c key binding would get priority over ctrl+c in search box). To address this we have added special flows in the PreviewKeyDown handler, covering ctr+c, but not ctrl+insert (which I would expect to work if it was not bound). As Dustin mentioned we need to find a good approach. I really don't understand the decision not to bubble up some keys.
claunia commented 2026-01-31 03:32:47 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Mar 26, 2021):

If I am renaming a tab in Windows Terminal Preview 1.7.572.0 and press the Left arrow key when the insertion point is already at the beginning of the edit box, then it closes the edit box and commits the change as if I had pressed Enter. Is that a consequence of keys being bubbled up and the edit box deciding not to handle the key? If so, I hope this behavior won't spread to the command palette and the find box.

@KalleOlaviNiemitalo commented on GitHub (Mar 26, 2021): If I am renaming a tab in Windows Terminal Preview 1.7.572.0 and press the Left arrow key when the insertion point is already at the beginning of the edit box, then it closes the edit box and commits the change as if I had pressed Enter. Is that a consequence of keys being bubbled up and the edit box deciding not to handle the key? If so, I hope this behavior won't spread to the command palette and the find box.
claunia commented 2026-01-31 03:32:47 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Mar 26, 2021):

If I am renaming a tab in Windows Terminal Preview 1.7.572.0 and press the Left arrow key when the insertion point is already at the beginning of the edit box, then it closes the edit box and commits the change as if I had pressed Enter. Is that a consequence of keys being bubbled up and the edit box deciding not to handle the key? If so, I hope this behavior won't spread to the command palette and the find box.

@KalleOlaviNiemitalo - not sure how you find all these 😄. I think this one is unrelated, the Left key switches to another tab (I guess the TabView catches it and decides to switch to an adjacent), causing the renamer box to lose focus. If we want to fix this, we should probably open a separate ticket

@Don-Vito commented on GitHub (Mar 26, 2021): > > > If I am renaming a tab in Windows Terminal Preview 1.7.572.0 and press the Left arrow key when the insertion point is already at the beginning of the edit box, then it closes the edit box and commits the change as if I had pressed Enter. Is that a consequence of keys being bubbled up and the edit box deciding not to handle the key? If so, I hope this behavior won't spread to the command palette and the find box. @KalleOlaviNiemitalo - not sure how you find all these :smile:. I think this one is unrelated, the Left key switches to another tab (I guess the TabView catches it and decides to switch to an adjacent), causing the renamer box to lose focus. If we want to fix this, we should probably open a separate ticket
claunia commented 2026-01-31 03:32:47 +00:00
Author
Owner
Copy Link

@eleadufresne commented on GitHub (Nov 14, 2024):

Hello everyone! I'd like to address this issue by adding a conditional check for CTRL with either Insert or C for the copy action, similar to the approach used in PR #9056.

I noticed that Insert is just a virtual key (rather than a modifier), which means it doesn't trigger the same way on "KeyDown." So, while this doesn't solve the underlying issues mentioned in the comments, it should fix the copy behaviour in the command palette with minimal changes.

Please let me know if this direction works for you! If this sounds good, I can create a new branch and a draft PR. 😊

@eleadufresne commented on GitHub (Nov 14, 2024): Hello everyone! I'd like to address this issue by adding a conditional check for `CTRL` with either `Insert` or `C` for the copy action, similar to the approach used in [PR #9056](https://github.com/microsoft/terminal/pull/9056). I noticed that `Insert` is just a virtual key (rather than a modifier), which means it doesn't trigger the same way on "KeyDown." So, while this doesn't solve the underlying issues mentioned in the comments, it should fix the copy behaviour in the command palette with minimal changes. Please let me know if this direction works for you! If this sounds good, I can create a new branch and a draft PR. 😊
claunia commented 2026-01-31 03:32:48 +00:00
Author
Owner
Copy Link

@JodhwaniMadhur commented on GitHub (Nov 20, 2024):

I would also like to take this up.

@JodhwaniMadhur commented on GitHub (Nov 20, 2024): I would also like to take this up.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CmdPal good first issue Help Wanted In-PR Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13067
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?