Remove base layer from settings UI #13084

Open
opened 2026-01-31 03:33:24 +00:00 by claunia · 0 comments
Owner

Originally created by @cinnamon-msft on GitHub (Mar 18, 2021).

Originally assigned to: @carlos-zamora on GitHub.

Description of the new feature/enhancement

After discussing with the team, we believe it makes sense to keep base layer as a JSON setting only and see if people request later to be able to apply settings to all profiles with the UI.

We need to remove the base layer page as well as the reset button tooltip functionality that says "Reset to base layer value". We can't remove the reset button entirely because there's a tooltip for when settings override JSON fragments.

image

Additional explanation of why we're doing this

Proposed technical implementation details (optional)

Originally created by @cinnamon-msft on GitHub (Mar 18, 2021). Originally assigned to: @carlos-zamora on GitHub. <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement After discussing with the team, we believe it makes sense to keep base layer as a JSON setting only and see if people request later to be able to apply settings to all profiles with the UI. We need to remove the base layer page as well as the reset button tooltip functionality that says "Reset to base layer value". We can't remove the reset button entirely because there's a tooltip for when settings override JSON fragments. ![image](https://user-images.githubusercontent.com/48369326/111676530-7f675c80-87db-11eb-9684-8373905c8927.png) [Additional explanation of why we're doing this](https://github.com/microsoft/terminal/issues/9539#issuecomment-803038683) # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. -->
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13084