starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

toggleShaderEffects stops functioning after cycling toggleFocusMode #13149

New Issue
Closed
opened 2026-01-31 03:34:59 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 03:34:59 +00:00
Owner
Copy Link

Originally created by @oising on GitHub (Mar 23, 2021).

Windows Terminal version (or Windows build number)

1.7.572.0

Other Software

No response

Steps to reproduce

  1. install custom shader (e.g. https://github.com/Hammster/windows-terminal-shaders )
  2. bind toggleShaderEffects and toggleFocusMode in settings
  3. toggle shader on
  4. toggle focus on
  5. toggle focus off
  6. toggle shader off
  7. toggle shader on -- this should fail (shader remains off and cannot be turned on). If it turns on, repeat from step 4 - it will fail the second or third time around.

This behavior seems tab-specific, as a new tab will allow the sequence above to be repeated (until that new tab is also unresponsive to toggling shader on/off).

Expected Behavior

shader toggle should always work.

Actual Behavior

shader toggle stops working.

Originally created by @oising on GitHub (Mar 23, 2021). ### Windows Terminal version (or Windows build number) 1.7.572.0 ### Other Software _No response_ ### Steps to reproduce 1) install custom shader (e.g. https://github.com/Hammster/windows-terminal-shaders ) 2) bind toggleShaderEffects and toggleFocusMode in settings 3) toggle shader on 4) toggle focus on 5) toggle focus off 6) toggle shader off 7) toggle shader on -- this should fail (shader remains off and cannot be turned on). If it turns on, repeat from step 4 - it will fail the second or third time around. This behavior seems tab-specific, as a new tab will allow the sequence above to be repeated (until that new tab is also unresponsive to toggling shader on/off). ### Expected Behavior shader toggle should always work. ### Actual Behavior shader toggle stops working.
claunia commented 2026-01-31 03:35:02 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 29, 2021):

Holy crap yea I was able to repro this. What the heck? There's no way that these should interact with each other at all!

FYI I think I hit it by doing 4, 6, 5, 7 - that's the sequence that finally did it for me.

Also for future note:


        { "command": "toggleShaderEffects", "keys": "ctrl+r", "name": "Toggle pixel shader effects" },
        { "command": "toggleFocusMode", "keys": "ctrl+f" },
@zadjii-msft commented on GitHub (Mar 29, 2021): Holy crap yea I was able to repro this. What the heck? There's no way that these should interact with each other _at all_! FYI I think I hit it by doing 4, 6, 5, 7 - that's the sequence that finally did it for me. Also for future note: ```json { "command": "toggleShaderEffects", "keys": "ctrl+r", "name": "Toggle pixel shader effects" }, { "command": "toggleFocusMode", "keys": "ctrl+f" }, ```
claunia commented 2026-01-31 03:35:03 +00:00
Author
Owner
Copy Link

@oising commented on GitHub (Mar 29, 2021):

@zadjii-msft Ok, good -- glad you could repro it. Definitely a heisenbug.

@oising commented on GitHub (Mar 29, 2021): @zadjii-msft Ok, good -- glad you could repro it. Definitely a _heisenbug_.
claunia commented 2026-01-31 03:35:04 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 24, 2022):

Hm. I think this has gone away on newer builds/? At least the old repro case doesn't seem to repro it for me anymore...

@zadjii-msft commented on GitHub (Aug 24, 2022): Hm. I think this has gone away on newer builds/? At least the old repro case doesn't seem to repro it for me anymore...
claunia commented 2026-01-31 03:35:05 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 28, 2022):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Aug 28, 2022): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 03:35:06 +00:00
Author
Owner
Copy Link

@oising commented on GitHub (Oct 11, 2022):

Hah! A rare occurrence.

@oising commented on GitHub (Oct 11, 2022): Hah! A rare occurrence.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Needs-Attention Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13149
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?