Fonts in font face dropdown are not alphabetized #13157

Closed
opened 2026-01-31 03:35:12 +00:00 by claunia · 5 comments
Owner

Originally created by @cinnamon-msft on GitHub (Mar 23, 2021).

Windows Terminal version (or Windows build number)

1.8.771.0

Other Software

No response

Steps to reproduce

Open the settings UI
Navigate to the appearance section for a profile
Click on the dropdown for font face

Also have a variety of fonts installed(?)

Expected Behavior

Fonts are listed in alphabetical order by their name

Actual Behavior

Fonts appear to be in a somewhat random order

font-face-screenshot
Originally created by @cinnamon-msft on GitHub (Mar 23, 2021). ### Windows Terminal version (or Windows build number) 1.8.771.0 ### Other Software _No response_ ### Steps to reproduce Open the settings UI Navigate to the appearance section for a profile Click on the dropdown for font face Also have a variety of fonts installed(?) ### Expected Behavior Fonts are listed in alphabetical order by their name ### Actual Behavior Fonts appear to be in a somewhat random order <img width="868" alt="font-face-screenshot" src="https://user-images.githubusercontent.com/48369326/112214690-ba530100-8bdc-11eb-8996-4ffc5307ccef.png">
Author
Owner

@carlos-zamora commented on GitHub (Mar 24, 2021):

This is actually a really easy fix.

da24f7d939/src/cascadia/TerminalSettingsEditor/Profiles.cpp (L155-L160)

We're already "sorting" the fonts, but at one point, I switched from storing a list of hstrings to a list of Fonts. It's just a matter of adding some kind of comparator to that sort call.

@carlos-zamora commented on GitHub (Mar 24, 2021): This is actually a really easy fix. https://github.com/microsoft/terminal/blob/da24f7d9390a71648a81f17fc1eefc6e2d27bcbf/src/cascadia/TerminalSettingsEditor/Profiles.cpp#L155-L160 We're already "sorting" the fonts, but at one point, I switched from storing a list of `hstring`s to a list of `Font`s. It's just a matter of adding some kind of comparator to that `sort` call.
Author
Owner

@smholvoet commented on GitHub (Mar 30, 2021):

Was digging through issues trying to find a "font autocomplete" issue, and wound up here 🤷‍♂️

I noticed @cinnamon-msft's screenshot has a dropdown containing all the font faces, whilst mine just has a textbox:

image

I'm obviously still able to manually enter a font face, but autofill makes way more sense.

I'm running the latest preview version (1.7.572.0), so I'm guessing this feature will be contained in one of the future releases (1.8.771.0)... or is this a genuine 🐛 bug?

@smholvoet commented on GitHub (Mar 30, 2021): Was digging through issues trying to find a "font autocomplete" issue, and wound up here 🤷‍♂️ I noticed @cinnamon-msft's screenshot has a dropdown containing all the font faces, whilst mine just has a textbox: ![image](https://user-images.githubusercontent.com/13507392/112984253-f4814d00-915e-11eb-8780-e37c0ad87cf1.png) I'm obviously still able to manually enter a font face, but autofill makes way more sense. I'm running the latest preview version (1.7.572.0), so I'm guessing this feature will be contained in one of the future releases (1.8.771.0)... or is this a genuine 🐛 bug?
Author
Owner

@zadjii-msft commented on GitHub (Mar 30, 2021):

@smholvoet The font face input was only changed to a ComboBox in #9275, which hasn't shipped to any official builds yet

@zadjii-msft commented on GitHub (Mar 30, 2021): @smholvoet The font face input was only changed to a ComboBox in #9275, which hasn't shipped to _any_ official builds yet
Author
Owner

@smholvoet commented on GitHub (Mar 30, 2021):

@zadjii-msft alright, thanks for clarifying 👌

@smholvoet commented on GitHub (Mar 30, 2021): @zadjii-msft alright, thanks for clarifying 👌
Author
Owner

@ghost commented on GitHub (Apr 14, 2021):

:tada:This issue was addressed in #9653, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:This issue was addressed in #9653, which has now been successfully released as `Windows Terminal Preview v1.8.1032.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1032.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13157