starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

psysh (readline?) broken with tee #13200

New Issue
Closed
opened 2026-01-31 03:36:29 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 03:36:29 +00:00
Owner
Copy Link

Originally created by @chx on GitHub (Mar 26, 2021).

Windows Terminal version (or Windows build number)

1.6.10571.0

Other Software

psysh , Ubuntu tee

Steps to reproduce

  1. sudo apt install php-cli
  2. wget https://psysh.org/psysh ; chmod +x psysh
  3. ./psysh works normally
  4. ./psysh |tee foo

Observe no prompt and up arrow prints control characters. This was working with WSL1 a few days ago.

Expected Behavior

Well I wasn't expecting tee to completely break the terminal... I wouldn't be surprised if https://github.com/microsoft/terminal/issues/6096 https://github.com/microsoft/terminal/issues/4243 were the same.

Note it's possible to reproduce this without tee although it is way more complicated, you need Drupal and drush and drush-launcher but when running drush php (which executes an integrated psysh) via the launcher it is similarly broken vs vendor/bin/drush php is not broken.

I ran python |tee foo and got the same control characters although there at least the prompt didn't disappear.

Actual Behavior

Broken readline behavior.

Originally created by @chx on GitHub (Mar 26, 2021). ### Windows Terminal version (or Windows build number) 1.6.10571.0 ### Other Software psysh , Ubuntu tee ### Steps to reproduce 1. sudo apt install php-cli 1. wget https://psysh.org/psysh ; chmod +x psysh 1. ./psysh works normally 1. ./psysh |tee foo Observe no prompt and up arrow prints control characters. This was working with WSL1 a few days ago. ### Expected Behavior Well I wasn't expecting tee to completely break the terminal... I wouldn't be surprised if https://github.com/microsoft/terminal/issues/6096 https://github.com/microsoft/terminal/issues/4243 were the same. Note it's possible to reproduce this without tee although it is way more complicated, you need Drupal and drush and drush-launcher but when running `drush php` (which executes an integrated psysh) via the launcher it is similarly broken vs `vendor/bin/drush php` is not broken. I ran `python |tee foo` and got the same control characters although there at least the prompt didn't disappear. ### Actual Behavior Broken readline behavior.
claunia added the Needs-TriageNeeds-Tag-Fix labels 2026-01-31 03:36:29 +00:00
claunia commented 2026-01-31 03:36:30 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Mar 26, 2021):

Do you also see the same behaviour with cmd.exe?

@skyline75489 commented on GitHub (Mar 26, 2021): Do you also see the same behaviour with cmd.exe?
claunia commented 2026-01-31 03:36:30 +00:00
Author
Owner
Copy Link

@chx commented on GitHub (Mar 26, 2021):

What's the equivalent of tee for cmd?

@chx commented on GitHub (Mar 26, 2021): What's the equivalent of tee for cmd?
claunia commented 2026-01-31 03:36:30 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Mar 26, 2021):

No I mean you can run wsl.exe in cmd.exe to access the WSL environment, if that's what you're using. Or you can run ssh.exe and ssh into a Linux machine.

@skyline75489 commented on GitHub (Mar 26, 2021): No I mean you can run `wsl.exe` in cmd.exe to access the WSL environment, if that's what you're using. Or you can run `ssh.exe` and ssh into a Linux machine.
claunia commented 2026-01-31 03:36:31 +00:00
Author
Owner
Copy Link

@chx commented on GitHub (Mar 26, 2021):

Yes, I did win+r cmd and there I can reproduce there as well, every case I tried is reproducible. Closing here and filing with WSL2 instead.

@chx commented on GitHub (Mar 26, 2021): Yes, I did win+r cmd and there I can reproduce there as well, every case I tried is reproducible. Closing here and filing with WSL2 instead.
claunia commented 2026-01-31 03:36:31 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Mar 26, 2021):

This could still be on us! We actually own the terminal and the traditional Windows console.

There's a chance, however, that this is simply an application decision. Psysh or readline may be disabling some tty management that it would have otherwise done because it's not connected to a terminal any longer¹. I know that readline-based things don't love to be piped.

This actually reproduces in Linux straight-up, without the console or WSL:
image

¹ When its output is piped to tee, it can only detect that it's connected to a pipe; it can't tell that the other end of that pipe is also a terminal.

@DHowett commented on GitHub (Mar 26, 2021): This could still be on us! We actually own the terminal _and the traditional Windows console_. There's a chance, however, that this is simply an application decision. Psysh or readline may be disabling some tty management that it would have otherwise done because it's not connected to a terminal any longer¹. I know that readline-based things don't _love_ to be piped. This actually reproduces in Linux straight-up, without the console _or_ WSL: ![image](https://user-images.githubusercontent.com/189190/112659399-56217e80-8e22-11eb-9ffa-ac523df2c6e0.png) ¹ When its output is piped to tee, it can only detect that it's connected to a pipe; it can't tell that the other end of that pipe is also a terminal.
claunia commented 2026-01-31 03:36:31 +00:00
Author
Owner
Copy Link

@chx commented on GitHub (Mar 26, 2021):

@DHowett the big problem really is that somehow Drush Launcher is broken vs when running Drush , I just managed to replicate the behavior with tee ... for sure those are not broken on normal Linux. It's just waaaay more complicated to replicate that way. :/ I can try to write up replicate steps using perhaps docker to avoid installing half the world :/

@chx commented on GitHub (Mar 26, 2021): @DHowett the big problem really is that somehow Drush Launcher is broken vs when running Drush , I just managed to replicate the behavior with tee ... for sure those are not broken on normal Linux. It's just waaaay more complicated to replicate that way. :/ I can try to write up replicate steps using perhaps docker to avoid installing half the world :/
claunia commented 2026-01-31 03:36:31 +00:00
Author
Owner
Copy Link

@chx commented on GitHub (Mar 26, 2021):

Please try the Dockerfile at https://gist.github.com/chx/59de0d688e8e5ec17712d4665805bcc7 (this was copied and minimally adjusted from https://github.com/skilld-labs/docker-php/blob/master/php74/Dockerfile so thanks for that )

Once you have built it like docker build -t ghtest . you can compare docker run --rm -it ghtest /srv/vendor/bin/drush php to docker run --rm -it ghtest /usr/local/bin/drush php

@chx commented on GitHub (Mar 26, 2021): Please try the Dockerfile at https://gist.github.com/chx/59de0d688e8e5ec17712d4665805bcc7 (this was copied and minimally adjusted from https://github.com/skilld-labs/docker-php/blob/master/php74/Dockerfile so thanks for that ) Once you have built it like `docker build -t ghtest .` you can compare `docker run --rm -it ghtest /srv/vendor/bin/drush php` to `docker run --rm -it ghtest /usr/local/bin/drush php`
claunia commented 2026-01-31 03:36:31 +00:00
Author
Owner
Copy Link

@chx commented on GitHub (Mar 28, 2021):

OK I have been finally told that this is 100% not Windows Terminal fault. Sorry for the noise again, it's such a maze of intertwining components. I reopened https://github.com/drush-ops/drush-launcher/issues/90 and will work on that.

@chx commented on GitHub (Mar 28, 2021): OK I have been finally told that this is 100% not Windows Terminal fault. Sorry for the noise again, it's such a maze of intertwining components. I reopened https://github.com/drush-ops/drush-launcher/issues/90 and will work on that.
claunia commented 2026-01-31 03:36:32 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Mar 28, 2021):

Thanks for following up!

@DHowett commented on GitHub (Mar 28, 2021): Thanks for following up!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13200
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?