starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

conhost.exe heap corruption in COOKED_READ_DATA::_handlePostCharInputLoop #13281

New Issue
Open
opened 2026-01-31 03:38:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 03:38:36 +00:00
Owner
Copy Link

Originally created by @emmett-b on GitHub (Apr 2, 2021).

Originally assigned to: @zadjii-msft on GitHub.

Windows Terminal version (or Windows build number)

Windows Terminal 1.6.10571.0
OS Build 21343.10000

Other Software

My awful cmd wrapper (attempt at a terminal emulator) written in a weekend 3 years ago. A pyramid of hacks that seems to fuzz the new conhost enough to make it crash. Wasn't crashing before, apparently until I upgraded to Windows 10 insider dev channel.

Steps to reproduce

Not clear yet but my cmd wrapper has multiple threads calling into ReadConsoleOutput, GetConsoleScreenBufferInfo, WriteConsoleInput many times. Looks like it's triggered by successive calls to GetConsoleScreenBufferInfo and then WriteConsoleInput.

Expected Behavior

no crash

Actual Behavior

Heap corruption. Attaching a debugger showed that it was crashing during a call to free which ended up in ntdll!RtlpHeapFindListLookupEntry. I then enabled app verifier for conshost.exe and then it crashed in memcpy called by COOKED_READ_DATA::_handlePostCharInputLoop. So this likely where the heap corruption happens.

Originally created by @emmett-b on GitHub (Apr 2, 2021). Originally assigned to: @zadjii-msft on GitHub. ### Windows Terminal version (or Windows build number) Windows Terminal 1.6.10571.0 OS Build 21343.10000 ### Other Software My awful cmd wrapper (attempt at a terminal emulator) written in a weekend 3 years ago. A pyramid of hacks that seems to fuzz the new conhost enough to make it crash. Wasn't crashing before, apparently until I upgraded to Windows 10 insider dev channel. ### Steps to reproduce Not clear yet but my cmd wrapper has multiple threads calling into ReadConsoleOutput, GetConsoleScreenBufferInfo, WriteConsoleInput many times. Looks like it's triggered by successive calls to GetConsoleScreenBufferInfo and then WriteConsoleInput. ### Expected Behavior no crash ### Actual Behavior Heap corruption. Attaching a debugger showed that it was crashing during a call to free which ended up in ntdll!RtlpHeapFindListLookupEntry. I then enabled app verifier for conshost.exe and then it crashed in memcpy called by COOKED_READ_DATA::_handlePostCharInputLoop. So this likely where the heap corruption happens.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Input Issue-Bug Needs-Tag-Fix Priority-1 Product-Conhost Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13281
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?