starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add icon to profile title on settings UI #13286

New Issue
Open
opened 2026-01-31 03:38:48 +00:00 by claunia · 25 comments
claunia commented 2026-01-31 03:38:48 +00:00
Owner
Copy Link

Originally created by @cinnamon-msft on GitHub (Apr 2, 2021).

Description of the new feature/enhancement

If would be cool if we displayed the icon of the profile at the top of the profile page on the settings UI.

profile-icon

Proposed technical implementation details (optional)

Originally created by @cinnamon-msft on GitHub (Apr 2, 2021). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement If would be cool if we displayed the icon of the profile at the top of the profile page on the settings UI. <img width="1166" alt="profile-icon" src="https://user-images.githubusercontent.com/48369326/113440923-33531500-93a2-11eb-94c0-d0bea883a9f5.png"> <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. -->
claunia commented 2026-01-31 03:38:49 +00:00
Author
Owner
Copy Link

@vastatio-xoxo commented on GitHub (Apr 27, 2021):

Hi, do you have any UI mockups (for dimensions, spacings etc) for the icon?

@vastatio-xoxo commented on GitHub (Apr 27, 2021): Hi, do you have any UI mockups (for dimensions, spacings etc) for the icon?
claunia commented 2026-01-31 03:38:50 +00:00
Author
Owner
Copy Link

@HimanshuMahto commented on GitHub (Oct 18, 2023):

Hey can you assign this to me

@HimanshuMahto commented on GitHub (Oct 18, 2023): Hey can you assign this to me
claunia commented 2026-01-31 03:38:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 18, 2023):

@HimanshuMahto Let us know if you need any help ☺️

@zadjii-msft commented on GitHub (Oct 18, 2023): @HimanshuMahto Let us know if you need any help ☺️
claunia commented 2026-01-31 03:38:50 +00:00
Author
Owner
Copy Link

@HimanshuMahto commented on GitHub (Oct 18, 2023):

Since I'm new to this can you help me @zadjii-msft

@HimanshuMahto commented on GitHub (Oct 18, 2023): Since I'm new to this can you help me @zadjii-msft
claunia commented 2026-01-31 03:38:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 18, 2023):

Sure thing! I'd start by looking at #10046. That was an earlier attempt to do this, which we ultimately reverted in #10124. We had to revert that due to some crash when you saved the settings, but I'm thinking that crash is probably no longer applicable?

Now, the thing is, we've kinda re-written the settings UI since that original PR. It's still structurally pretty much the same, but there's been some minor changes to account for the Windows 11 style differences. You'll probably still want to put the icon in:
1745857407/src/cascadia/TerminalSettingsEditor/MainPage.xaml (L67-L98)

@zadjii-msft commented on GitHub (Oct 18, 2023): Sure thing! I'd start by looking at #10046. That was an earlier attempt to do this, which we ultimately reverted in #10124. We had to revert that due to some crash when you saved the settings, but I'm thinking that crash is probably no longer applicable? Now, the thing is, we've kinda re-written the settings UI since that original PR. It's still structurally pretty much the same, but there's been some minor changes to account for the Windows 11 style differences. You'll probably still want to put the icon in: https://github.com/microsoft/terminal/blob/174585740759f3e473c5a4efe3207a20d2c78511/src/cascadia/TerminalSettingsEditor/MainPage.xaml#L67-L98
claunia commented 2026-01-31 03:38:50 +00:00
Author
Owner
Copy Link

@HimanshuMahto commented on GitHub (Oct 19, 2023):

okay, I got it. hey, Can I get your contact so that I can ask you questions in person if you don't mind? @zadjii-msft

@HimanshuMahto commented on GitHub (Oct 19, 2023): okay, I got it. hey, Can I get your contact so that I can ask you questions in person if you don't mind? @zadjii-msft
claunia commented 2026-01-31 03:38:51 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 19, 2023):

To be totally honest - I'd prefer to keep discussion on GitHub. Reasons include (but aren't limited to):

  1. I'm terrible at replying to mails. There's just too much volume, and I'm known to read an email, not immediately reply, then forget about it. I'm somehow better about replying to GitHub
  2. No one should judge anyone for asking questions. Ever. How could anyone ever learn anything without starting by asking questions?
  3. If you have questions about contributing to the Terminal (or really any part of our dev stack here), then chances are, others will too. Better to leave an archive of notes for future people to learn from too ☺️
@zadjii-msft commented on GitHub (Oct 19, 2023): To be totally honest - I'd prefer to keep discussion on GitHub. Reasons include (but aren't limited to): 1. I'm terrible at replying to mails. There's just too much volume, and I'm known to read an email, not immediately reply, then forget about it. I'm somehow better about replying to GitHub 2. No one should judge anyone for asking questions. Ever. How could anyone ever learn anything without starting by asking questions? 3. If you have questions about contributing to the Terminal (or really any part of our dev stack here), then chances are, others will too. Better to leave an archive of notes for future people to learn from too ☺️
claunia commented 2026-01-31 03:38:51 +00:00
Author
Owner
Copy Link

@HimanshuMahto commented on GitHub (Oct 20, 2023):

okay, thanks for the advice.

@HimanshuMahto commented on GitHub (Oct 20, 2023): okay, thanks for the advice.
claunia commented 2026-01-31 03:38:52 +00:00
Author
Owner
Copy Link

@HimanshuMahto commented on GitHub (Oct 20, 2023):

Hey, @zadjii-msft I'm new to this and don't know how to run and see the changes though I have installed powershell pro tools and powershell in the VS code and did try to run the code but it wasn't showing anything. Can you please help me. I know its a silly question but I don't know how to do it and want to learn want to contribute to this.

@HimanshuMahto commented on GitHub (Oct 20, 2023): Hey, @zadjii-msft I'm new to this and don't know how to run and see the changes though I have installed powershell pro tools and powershell in the VS code and did try to run the code but it wasn't showing anything. Can you please help me. I know its a silly question but I don't know how to do it and want to learn want to contribute to this.
claunia commented 2026-01-31 03:38:52 +00:00
Author
Owner
Copy Link

@HimanshuMahto commented on GitHub (Oct 21, 2023):

Hey @zadjii-msft @DHowett @cinnamon-msft need a help

@HimanshuMahto commented on GitHub (Oct 21, 2023): Hey @zadjii-msft @DHowett @cinnamon-msft need a help
claunia commented 2026-01-31 03:38:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 24, 2023):

@HimanshuMahto Did you try following these steps in the README?

Once you've got the code checked out and the tools installed, the easiest way to test the code is to open up OpenConsole.sln, set the config to
image
(or x86 if you're on an x86 machine for some reason)

and hit the big green play button to start debugging.

@zadjii-msft commented on GitHub (Oct 24, 2023): @HimanshuMahto Did you try following [these steps](https://github.com/microsoft/terminal#developer-guidance) in the README? Once you've got the code checked out and the tools installed, the easiest way to test the code is to open up OpenConsole.sln, set the config to ![image](https://github.com/microsoft/terminal/assets/18356694/1ccb0259-4a28-4ca6-8808-0fa03c02eae3) (or x86 if you're on an x86 machine for some reason) and hit the big green play button to start debugging.
claunia commented 2026-01-31 03:38:53 +00:00
Author
Owner
Copy Link

@HimanshuMahto commented on GitHub (Oct 24, 2023):

Got it @zadjii-msft. Thanks a lot i will start working on it.

@HimanshuMahto commented on GitHub (Oct 24, 2023): Got it @zadjii-msft. Thanks a lot i will start working on it.
claunia commented 2026-01-31 03:38:53 +00:00
Author
Owner
Copy Link

@HimanshuMahto commented on GitHub (Oct 25, 2023):

Hey, @zadjii-msft, I tried what you said but its still not working.
Screenshot 2023-10-25 210800

@HimanshuMahto commented on GitHub (Oct 25, 2023): Hey, @zadjii-msft, I tried what you said but its still not working. ![Screenshot 2023-10-25 210800](https://github.com/microsoft/terminal/assets/93067059/eb805907-731e-4eaf-a696-98cb257bce92)
claunia commented 2026-01-31 03:38:53 +00:00
Author
Owner
Copy Link

@rohiitgit commented on GitHub (Mar 10, 2024):

Hii, seems like the last person was unsuccessful at this. Can you assign this to me? It will be my first issue.

@rohiitgit commented on GitHub (Mar 10, 2024): Hii, seems like the last person was unsuccessful at this. Can you assign this to me? It will be my first issue.
claunia commented 2026-01-31 03:38:54 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 11, 2024):

You can just go ahead and start working on things without necessarily being assigned. Usually we really only use the Assignees field if someone on the core team has to be the one to deal with an issue 😝

@zadjii-msft commented on GitHub (Mar 11, 2024): You can just go ahead and start working on things without necessarily being assigned. Usually we really only use the Assignees field if someone on the core team has to be the one to deal with an issue 😝
claunia commented 2026-01-31 03:38:54 +00:00
Author
Owner
Copy Link

@Kore-rep commented on GitHub (Apr 17, 2024):

Hi @zadjii-msft, pretty much done with the implementation of this (i.e. just kinda copying your old code across). Did you ever manage to overcome the resolution scaling issues? The font icons look fine, but the powershell icon, when scaled up to a height of 28 looks quite horrible.

@Kore-rep commented on GitHub (Apr 17, 2024): Hi @zadjii-msft, pretty much done with the implementation of this (i.e. just kinda copying your old code across). Did you ever manage to overcome the resolution scaling issues? The font icons look fine, but the powershell icon, when scaled up to a height of 28 looks quite horrible.
claunia commented 2026-01-31 03:38:54 +00:00
Author
Owner
Copy Link

@aditya-sahu commented on GitHub (Nov 25, 2024):

@Kore-rep Are you still working on this?
Can I start working on this if you're not working?

@aditya-sahu commented on GitHub (Nov 25, 2024): @Kore-rep Are you still working on this? Can I start working on this if you're not working?
claunia commented 2026-01-31 03:38:55 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 25, 2024):

Sorry, I think I missed that earlier message 😅

I never really looked into the image scaling. It sounds like something I looked at briefly, where IconPathConverter always loads icons at a fixed size:

ae90d52bb1/src/cascadia/UIHelpers/IconPathConverter.cpp (L335-L336)
ae90d52bb1/src/cascadia/UIHelpers/IconPathConverter.cpp (L158-L160)

but I can't be sure. I'd reckon it's probably more valuable to put out a PR with this change as it is now. That'd force our hands to make sure we fix that :P

@zadjii-msft commented on GitHub (Nov 25, 2024): Sorry, I think I missed that earlier message 😅 I never really looked into the image scaling. It _sounds_ like something I looked at briefly, where `IconPathConverter` always loads icons at a fixed size: https://github.com/microsoft/terminal/blob/ae90d52bb18fc7ad1d509aa81c7df71ada0e3b1f/src/cascadia/UIHelpers/IconPathConverter.cpp#L335-L336 https://github.com/microsoft/terminal/blob/ae90d52bb18fc7ad1d509aa81c7df71ada0e3b1f/src/cascadia/UIHelpers/IconPathConverter.cpp#L158-L160 but I can't be sure. I'd reckon it's probably more valuable to put out a PR with this change as it is now. That'd force our hands to make sure we fix that :P
claunia commented 2026-01-31 03:38:55 +00:00
Author
Owner
Copy Link

@Kore-rep commented on GitHub (Nov 25, 2024):

Hi @aditya-sahu, I've opened a PR with my changes, feel free to make any changes you want to for that. I never resolved the image scaling issue, or did any particular refactoring to make things nicer, its a pretty barebones implementation

https://github.com/microsoft/terminal/pull/18244

@Kore-rep commented on GitHub (Nov 25, 2024): Hi @aditya-sahu, I've opened a PR with my changes, feel free to make any changes you want to for that. I never resolved the image scaling issue, or did any particular refactoring to make things nicer, its a pretty barebones implementation https://github.com/microsoft/terminal/pull/18244
claunia commented 2026-01-31 03:38:55 +00:00
Author
Owner
Copy Link

@Vaishhhnavi77 commented on GitHub (Feb 24, 2025):

is this issue still open to contribute?

@Vaishhhnavi77 commented on GitHub (Feb 24, 2025): is this issue still open to contribute?
claunia commented 2026-01-31 03:38:55 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 24, 2025):

yes.

@DHowett commented on GitHub (Feb 24, 2025): yes.
claunia commented 2026-01-31 03:38:55 +00:00
Author
Owner
Copy Link

@Hacker0P commented on GitHub (Mar 5, 2025):

Hi, I'd like to work on this issue. Can you assign it to me?

@Hacker0P commented on GitHub (Mar 5, 2025): Hi, I'd like to work on this issue. Can you assign it to me?
claunia commented 2026-01-31 03:38:56 +00:00
Author
Owner
Copy Link

@Hacker0P commented on GitHub (Mar 5, 2025):

Hi @DHowett , I’d like to work on this issue. Is it still open for contribution? If yes, I can start working on it right away!

@Hacker0P commented on GitHub (Mar 5, 2025): Hi @DHowett , I’d like to work on this issue. Is it still open for contribution? If yes, I can start working on it right away!
claunia commented 2026-01-31 03:38:56 +00:00
Author
Owner
Copy Link

@j4anvii commented on GitHub (Jun 27, 2025):

Hi @DHowett , I’d like to work on this issue. Is it still open for contribution? If yes, I can start working on it right away!

@j4anvii commented on GitHub (Jun 27, 2025): Hi @DHowett , I’d like to work on this issue. Is it still open for contribution? If yes, I can start working on it right away!
claunia commented 2026-01-31 03:38:56 +00:00
Author
Owner
Copy Link

@shivam-dhir commented on GitHub (Jan 22, 2026):

Hi, I would love to work on this issue

@shivam-dhir commented on GitHub (Jan 22, 2026): Hi, I would love to work on this issue
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI good first issue Help Wanted In-PR Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13286
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?