starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[BASH] Settings UI: Two issues in automatic profile naming #13319

New Issue
Closed
opened 2026-01-31 03:39:36 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 03:39:36 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Apr 6, 2021).

Windows Terminal version (or Windows build number)

1.8

Other Software

No response

Steps to reproduce

  • Add a new profile. The automatic name is (for example) "Profile 8".
  • Rename it to "Profile 9" (because you are trying to break Terminal, and for no other reason).
  • Add a new profile, which will be named "Profile 9".

Expected Behavior

No response

Actual Behavior

When you hit save, one disappears from the UI.

originated in 4/2 bug bash

Originally created by @DHowett on GitHub (Apr 6, 2021). ### Windows Terminal version (or Windows build number) 1.8 ### Other Software _No response_ ### Steps to reproduce * Add a new profile. The automatic name is (for example) "Profile 8". * Rename it to "Profile 9" (because you are trying to break Terminal, and for no other reason). * Add a new profile, which will be named "Profile 9". ### Expected Behavior _No response_ ### Actual Behavior When you hit save, one disappears from the UI. _originated in 4/2 bug bash_
claunia commented 2026-01-31 03:39:37 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 6, 2021):

Two issues?

@zadjii-msft commented on GitHub (Apr 6, 2021): _Two_ issues?
claunia commented 2026-01-31 03:39:37 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 6, 2021):

Duplication of the number, stomping of the entry. I also don't think it matters that much. There's easier ways to break Terminal 😄

@DHowett commented on GitHub (Apr 6, 2021): Duplication of the number, stomping of the entry. I also don't think it _matters_ that much. There's easier ways to break Terminal :smile:
claunia commented 2026-01-31 03:39:38 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Apr 7, 2021):

I'm marking this as help wanted. CascadiaSettings::CreateNewProfile() just needs to check if the newly generated name is taken, and, if it is, generate a new one.

Relevant code: 361877cf1b/src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (L222-L232)

Today, we're naming the new profile "Profile <num of profiles>". We should probably just try "Profile <num of profiles + 1>" and keep incrementing it until we find one that works? I'm mildly annoyed that from that point forward, all new profiles would be called "Profile <num of profiles + 1>" but there's no reason for that to be annoying haha.

@carlos-zamora commented on GitHub (Apr 7, 2021): I'm marking this as help wanted. `CascadiaSettings::CreateNewProfile()` just needs to check if the newly generated name is taken, and, if it is, generate a new one. Relevant code: https://github.com/microsoft/terminal/blob/361877cf1b1be2824f9f0373f1cf524b81cebb12/src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp#L222-L232 Today, we're naming the new profile "`Profile <num of profiles>`". We should probably just try "`Profile <num of profiles + 1>`" and keep incrementing it until we find one that works? I'm mildly annoyed that from that point forward, all new profiles would be called "Profile <num of profiles + 1>" but there's no reason for that to be annoying haha.
claunia commented 2026-01-31 03:39:38 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #9816, which has now been successfully released as Windows Terminal v1.8.1444.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #9816, which has now been successfully released as `Windows Terminal v1.8.1444.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1444.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 03:39:38 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #9816, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #9816, which has now been successfully released as `Windows Terminal Preview v1.9.1445.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1445.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI good first issue Help Wanted Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13319
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?