starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Theme change does not apply properly to settings UI #13321

New Issue
Closed
opened 2026-01-31 03:39:37 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 03:39:37 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Apr 6, 2021).

image

originated in 4/2 bug bash

Originally created by @DHowett on GitHub (Apr 6, 2021). ![image](https://user-images.githubusercontent.com/189190/113726044-82a68780-96b9-11eb-8d73-f3835ec36ea3.png) _originated in 4/2 bug bash_
claunia commented 2026-01-31 03:39:39 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Apr 7, 2021):

@zadjii-msft just to be clear, this is an "easy-starter" because you have to basically do what we did in https://github.com/microsoft/terminal/pull/9732 to the entire SUI?

@carlos-zamora commented on GitHub (Apr 7, 2021): @zadjii-msft just to be clear, this is an "easy-starter" because you have to basically do what we did in https://github.com/microsoft/terminal/pull/9732 to the entire SUI?
claunia commented 2026-01-31 03:39:39 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 7, 2021):

I think it's even easier than that. We probably don't need to do the whole recursive dance. We might be able to just set RequestedTheme on the MainPage itself. I only did the recursive-upwards thing because I presumed that TeachingTips were the same weird edge case that ContentDialogs were.

@zadjii-msft commented on GitHub (Apr 7, 2021): I think it's even easier than that. We probably don't need to do the whole recursive dance. We might be able to just set `RequestedTheme` on the `MainPage` itself. I only did the recursive-upwards thing because I presumed that TeachingTips were the same weird edge case that ContentDialogs were.
claunia commented 2026-01-31 03:39:39 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Apr 14, 2021):

I cannot reproduce it - any specific steps?

@Don-Vito commented on GitHub (Apr 14, 2021): I cannot reproduce it - any specific steps?
claunia commented 2026-01-31 03:39:39 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (May 15, 2021):

I was able to get a similar issue over in #9949. Couldn't get the resource to appear when the app's theme was different from the Windows OS theme.

Setting RequestedTheme on MainPage didn't fix it 😢

@carlos-zamora commented on GitHub (May 15, 2021): I was able to get a similar issue over in #9949. Couldn't get the resource to appear when the app's theme was different from the Windows OS theme. Setting `RequestedTheme` on `MainPage` didn't fix it 😢
claunia commented 2026-01-31 03:39:39 +00:00
Author
Owner
Copy Link

@Albert-Jokelin commented on GitHub (Aug 30, 2021):

Hey! Can I work on this?

@Albert-Jokelin commented on GitHub (Aug 30, 2021): Hey! Can I work on this?
claunia commented 2026-01-31 03:39:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 30, 2021):

@Albert-Jokelin Sure, go right ahead! Though, we maybe should have yanked Easy-Starter off this one... if "Setting RequestedTheme on MainPage didn't fix it", then I'm not really sure where to start with this.

@zadjii-msft commented on GitHub (Aug 30, 2021): @Albert-Jokelin Sure, go right ahead! Though, we maybe should have yanked `Easy-Starter` off this one... if "Setting `RequestedTheme` on `MainPage` didn't fix it", then I'm not really sure where to start with this.
claunia commented 2026-01-31 03:39:40 +00:00
Author
Owner
Copy Link

@Albert-Jokelin commented on GitHub (Aug 30, 2021):

I'll try my best and if I need any help, I'll reach out to you guys.

@Albert-Jokelin commented on GitHub (Aug 30, 2021): I'll try my best and if I need any help, I'll reach out to you guys.
claunia commented 2026-01-31 03:39:40 +00:00
Author
Owner
Copy Link

@Albert-Jokelin commented on GitHub (Aug 31, 2021):

@zadjii-msft I'm unable to recreate the issue. I'm running Windows 10 Home Ver. 20H2, Build: 19042.928

@Albert-Jokelin commented on GitHub (Aug 31, 2021): @zadjii-msft I'm unable to recreate the issue. I'm running Windows 10 Home Ver. 20H2, Build: 19042.928
claunia commented 2026-01-31 03:39:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 31, 2021):

Son of a gun, you're right. Huh. Wonder when that got fixed? Glad to know it is though! Thanks for helping check that one out!

@zadjii-msft commented on GitHub (Aug 31, 2021): Son of a gun, you're right. Huh. Wonder when that got fixed? Glad to know it is though! Thanks for helping check that one out!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Help Wanted Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13321
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?