People think the Color Scheme editor will change the current colors #13392

Closed
opened 2026-01-31 03:41:25 +00:00 by claunia · 12 comments
Owner

Originally created by @tony-stines on GitHub (Apr 11, 2021).

Windows Terminal version (or Windows build number)

10.0.21354 (Dev)

Other Software

No response

Steps to reproduce

  1. Launch Terminal
  2. Open Settings
  3. Color Schemes
  4. Select another color scheme from combo
  5. Click to Save
  6. Reopen Settings -> Color Scheme didn't applied

Expected Behavior

No response

Actual Behavior

Color Scheme.

Originally created by @tony-stines on GitHub (Apr 11, 2021). ### Windows Terminal version (or Windows build number) 10.0.21354 (Dev) ### Other Software _No response_ ### Steps to reproduce 1. Launch Terminal 2. Open Settings 3. Color Schemes 4. Select another color scheme from combo 5. Click to Save 6. Reopen Settings -> Color Scheme didn't applied ### Expected Behavior _No response_ ### Actual Behavior Color Scheme.
Author
Owner

@DHowett commented on GitHub (Apr 11, 2021):

What terminal version.

@DHowett commented on GitHub (Apr 11, 2021): What terminal version.
Author
Owner

@sphars commented on GitHub (Apr 14, 2021):

I'm seeing this issue as well. Just updated to v1.7.1033.0 (the new release). No matter what I try, I can't seem to apply a color scheme using the new Settings UI. It gets reset back to Campbell on each relaunch.

Edit: This issue with with the default color scheme. Changing the scheme under individual profiles does apply the scheme properly to that profile.

Edit 2: Looking at recent commits, looks like it might be fixed in #9764

@sphars commented on GitHub (Apr 14, 2021): I'm seeing this issue as well. Just updated to v1.7.1033.0 (the new release). No matter what I try, I can't seem to apply a color scheme using the new Settings UI. It gets reset back to Campbell on each relaunch. Edit: This issue with with the default color scheme. Changing the scheme under individual profiles does apply the scheme properly to that profile. Edit 2: Looking at recent commits, looks like it might be fixed in #9764
Author
Owner

@miwojc commented on GitHub (Apr 16, 2021):

Same issue. Version: 1.7.1033.0
Edit: Also would be nice to be able to get to settings json file with keyboard shortcut (as before graphical UI ctr ,) because graphical UI doesn't have all the options settings json has. thanks!

@miwojc commented on GitHub (Apr 16, 2021): Same issue. Version: 1.7.1033.0 Edit: Also would be nice to be able to get to settings json file with keyboard shortcut (as before graphical UI ctr ,) because graphical UI doesn't have all the options settings json has. thanks!
Author
Owner

@zadjii-msft commented on GitHub (Apr 20, 2021):

Wait HOLD UP.

Are you going to the "Color Schemes" page
image

or are you changing the "color scheme" of a given profile:
image

The first page is used for editing the color scheme itself. The second is for changing the appearance of the selected profile. The dropdown on the Color Schemes page is just used for selecting which scheme you want to edit. It doesn't apply that scheme to any profiles.

@zadjii-msft commented on GitHub (Apr 20, 2021): Wait HOLD UP. Are you going to the "Color Schemes" page ![image](https://user-images.githubusercontent.com/18356694/115410049-eea7e600-a1b7-11eb-825c-c12ca8a3535c.png) or are you changing the "color scheme" of a given profile: ![image](https://user-images.githubusercontent.com/18356694/115410168-05e6d380-a1b8-11eb-8a19-45f7acf4c6d1.png) The first page is used for _editing the color scheme itself_. The second is for changing the appearance of the selected profile. The dropdown on the Color Schemes page is just used for _selecting which scheme you want to edit_. It doesn't apply that scheme to any profiles.
Author
Owner

@sphars commented on GitHub (Apr 20, 2021):

@zadjii-msft You're totally correct, now that I've taken a look into that. Gotta say though, it's definitely confusing on first use. I would assume that the Color schemes page is for selecting a default color scheme for all profiles (and yes you could edit the colors as well). Then you can go into individual profiles and override to a different color scheme.

Perhaps it just needs some some clarification on what the Coloring schemes page does. Maybe selecting a default color scheme would be better suited under Appearance (if setting a default color scheme is a goal).

@sphars commented on GitHub (Apr 20, 2021): @zadjii-msft You're totally correct, now that I've taken a look into that. Gotta say though, it's definitely confusing on first use. I would assume that the Color schemes page is for selecting a default color scheme for all profiles (and yes you could edit the colors as well). Then you can go into individual profiles and override to a different color scheme. Perhaps it just needs some some clarification on what the Coloring schemes page does. Maybe selecting a default color scheme would be better suited under Appearance (if setting a default color scheme is a goal).
Author
Owner

@miwojc commented on GitHub (Apr 20, 2021):

Is it possible to change default theme that would apply to all profiles like via settings.json?

@miwojc commented on GitHub (Apr 20, 2021): Is it possible to change default theme that would apply to all profiles like via settings.json?
Author
Owner

@DHowett commented on GitHub (Apr 20, 2021):

Is it possible to change default theme that would apply to all profiles like via settings.json?

/cc @cinnamon-msft

@DHowett commented on GitHub (Apr 20, 2021): > Is it possible to change default theme that would apply to all profiles like via settings.json? /cc @cinnamon-msft
Author
Owner

@zadjii-msft commented on GitHub (Apr 20, 2021):

I'll make sure to pass that feedback along to the UI designers (and my "I" I mean @cinnamon-msft 😋)

I'll close the rest of this discussion about setting the default for all profiles as a /duplicate of #9539 - we're generally having that discussion in that thread.

@zadjii-msft commented on GitHub (Apr 20, 2021): I'll make sure to pass that feedback along to the UI designers (and my "I" I mean @cinnamon-msft 😋) I'll close the rest of this discussion about setting the default for all profiles as a /duplicate of #9539 - we're generally having that discussion in that thread.
Author
Owner

@ghost commented on GitHub (Apr 20, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Apr 20, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Author
Owner

@zadjii-msft commented on GitHub (Jan 10, 2022):

We're reopening this, because it's come up a bunch of times now. The design clearly needs some improvement in this regard.

TODO:

  • Do a competitive analysis, see what other terminals do for this UX. Clearly, we're doing something misleading

Ideas:

  • Just get rid of the scheme editor entirely, replace it with a ContentDialog in the Profiles>Appearances page
  • Maybe we should add a button to the color schemes page that says something like "Apply this scheme to all profiles".
  • Alternatively, we could add some help text to the top/bottom like "Trying to change the color scheme for a particular profile? Go change '[Profile > Appearance > Color scheme](in-app link to default appearances)'"

There were other suggestions too, just logging before 5pm.

@zadjii-msft commented on GitHub (Jan 10, 2022): We're reopening this, because it's come up a bunch of times now. The design clearly needs some improvement in this regard. TODO: * [ ] Do a competitive analysis, see what other terminals do for this UX. Clearly, we're doing something misleading Ideas: * Just get rid of the scheme editor entirely, replace it with a ContentDialog in the Profiles>Appearances page * Maybe we should add a button to the color schemes page that says something like "Apply this scheme to all profiles". * Alternatively, we could add some help text to the top/bottom like "Trying to change the color scheme for a particular profile? Go change '[Profile > Appearance > Color scheme](in-app link to default appearances)'" There were other suggestions too, just logging before 5pm.
Author
Owner

@zadjii-msft commented on GitHub (Aug 29, 2022):

Punting this for a release, since we feel like this wasn't wholly addressed in #13269

@zadjii-msft commented on GitHub (Aug 29, 2022): Punting this for a release, since we feel like this wasn't wholly addressed in #13269
Author
Owner

@ghost commented on GitHub (Sep 13, 2022):

:tada:This issue was addressed in #13269, which has now been successfully released as Windows Terminal Preview v1.16.252.🎉

Handy links:

@ghost commented on GitHub (Sep 13, 2022): :tada:This issue was addressed in #13269, which has now been successfully released as `Windows Terminal Preview v1.16.252`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.252) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13392