starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

doc/building.md Possibly Outdated #13398

New Issue
Closed
opened 2026-01-31 03:41:39 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 03:41:39 +00:00
Owner
Copy Link

Originally created by @akkaygin on GitHub (Apr 11, 2021).

/doc/building.md (9 April 2021)
When using Visual Studio, be sure to set up the path for code formatting. This can be done in Visual Studio by going to Tools > Options > Text Editor > C++ > Formatting and checking "Use custom clang-format.exe file" and choosing the clang-format.exe in the repository at /dep/llvm/clang-format.exe by clicking "browse" right under the check box.

/dep/llvm thus /dep/llvm/clang-format.exe does not exist in the last commit and README.md doesn't mention about this step. Either way one of these files needs to be updated.
(Additionally, do I need this file? If yes where can I find it?)
Thanks.

Originally created by @akkaygin on GitHub (Apr 11, 2021). >[/doc/building.md (9 April 2021)](https://github.com/microsoft/terminal/blob/b310b1cffc5df62f652ab1781d282ccfac3bb050/doc/building.md) When using Visual Studio, be sure to set up the path for code formatting. This can be done in Visual Studio by going to Tools > Options > Text Editor > C++ > Formatting and checking "Use custom clang-format.exe file" and choosing the clang-format.exe in the repository at /dep/llvm/clang-format.exe by clicking "browse" right under the check box. /dep/llvm thus /dep/llvm/clang-format.exe does not exist in the [last commit](https://github.com/microsoft/terminal/tree/b310b1cffc5df62f652ab1781d282ccfac3bb050) and [README.md](https://github.com/microsoft/terminal/blob/main/README.md#building-the-code) doesn't mention about this step. Either way one of these files needs to be updated. (Additionally, do I need this file? If yes where can I find it?) Thanks.
claunia added the Needs-TriageResolution-Fix-CommittedNeeds-Tag-FixIssue-Docs labels 2026-01-31 03:41:39 +00:00
claunia commented 2026-01-31 03:41:40 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Apr 12, 2021):

If you have successfully used runformat (see Building in Cmd), you should have clang-format.exe in packages/clang-format.win-x86.10.0.0/tools.

@skyline75489 commented on GitHub (Apr 12, 2021): If you have successfully used `runformat` (see [Building in Cmd](https://github.com/microsoft/terminal/blob/b310b1cffc5df62f652ab1781d282ccfac3bb050/doc/building.md#building-in-cmd)), you should have `clang-format.exe` in `packages/clang-format.win-x86.10.0.0/tools`.
claunia commented 2026-01-31 03:41:40 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 21, 2021):

Technically since VS ships with clang-format 10 or 11 it doesn't... actually matter that it's not using the specific one from our repo. Still, it's a bonus to make sure it keeps working. Thanks for the fix!

@DHowett commented on GitHub (Apr 21, 2021): Technically since VS _ships with clang-format 10 or 11_ it doesn't... actually matter that it's not using the specific one from our repo. Still, it's a bonus to make sure it keeps working. Thanks for the fix!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Docs Needs-Tag-Fix Needs-Triage Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13398
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?