starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Tab closes on middle button mousedown rather than full click #13458

New Issue
Closed
opened 2026-01-31 03:43:15 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 03:43:15 +00:00
Owner
Copy Link

Originally created by @lbmaian on GitHub (Apr 15, 2021).

Windows Terminal version (or Windows build number)

1.7.1033.0

Other Software

No response

Steps to reproduce

  1. Open a new tab
  2. Middle button mousedown on the tab itself

Expected Behavior

Tab does not close until middle button mouseup on the same tab occurs, i.e. a full middle button click action.

This is the most typical behavior for tab closing in tabbed applications (web browsers, IDEs, etc.).

Actual Behavior

Tab closes immediately on middle button mousedown, without waiting for middle button mouseup on the same tab.

Originally created by @lbmaian on GitHub (Apr 15, 2021). ### Windows Terminal version (or Windows build number) 1.7.1033.0 ### Other Software _No response_ ### Steps to reproduce 1. Open a new tab 2. Middle button mousedown on the tab itself ### Expected Behavior Tab does not close until middle button mouseup on the same tab occurs, i.e. a full middle button click action. This is the most typical behavior for tab closing in tabbed applications (web browsers, IDEs, etc.). ### Actual Behavior Tab closes immediately on middle button mousedown, without waiting for middle button mouseup on the same tab.
claunia commented 2026-01-31 03:43:17 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Apr 15, 2021):

Huh it is true. I can easily repro this. Perhaps we should move this to upstream repo.

@skyline75489 commented on GitHub (Apr 15, 2021): Huh it is true. I can easily repro this. Perhaps we should move this to upstream repo.
claunia commented 2026-01-31 03:43:17 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 15, 2021):

This might not be on WinUI. Looks like we're the one's that did it on PointerPressed, not PointerReleased. See TerminalPage::_OnTabClick

@zadjii-msft commented on GitHub (Apr 15, 2021): This might not be on WinUI. Looks like we're the one's that did it on PointerPressed, not PointerReleased. See `TerminalPage::_OnTabClick`
claunia commented 2026-01-31 03:43:17 +00:00
Author
Owner
Copy Link

@lbmaian commented on GitHub (Apr 15, 2021):

Also something to point out:

Most tabbed interfaces (including Chrome, Edge, Firefox, Visual Studio Code) require that mousedown happen on the button, then subsequent mouseup on the same button, allowing pointer to move outside the button while button is still held down as long as it returns to the button when the mouseup happens.

Others (including Notepad++) only require mouseup on the button, without requiring mousedown on that button, i.e. pointer can be off the button when mousedown happens, move pointer over button, then mouseup.

Aside: I found Visual Studio (not VS Code) tabs also close on middle mousedown.

@lbmaian commented on GitHub (Apr 15, 2021): Also something to point out: Most tabbed interfaces (including Chrome, Edge, Firefox, Visual Studio Code) require that mousedown happen on the button, then subsequent mouseup on the same button, allowing pointer to move outside the button while button is still held down as long as it returns to the button when the mouseup happens. Others (including Notepad++) only require mouseup on the button, without requiring mousedown on that button, i.e. pointer can be off the button when mousedown happens, move pointer over button, then mouseup. Aside: I found Visual Studio (not VS Code) tabs also close on middle mousedown.
claunia commented 2026-01-31 03:43:17 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #9842, which has now been successfully released as Windows Terminal v1.8.1444.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #9842, which has now been successfully released as `Windows Terminal v1.8.1444.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1444.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 03:43:18 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #9842, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #9842, which has now been successfully released as `Windows Terminal Preview v1.9.1445.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1445.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label good first issue Help Wanted Issue-Bug Needs-Tag-Fix Needs-Triage Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13458
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?