starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Terminal Settings UI] Change the option 'Open JSON file' to 'Advanced Settings' #13492

New Issue
Closed
opened 2026-01-31 03:44:08 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 03:44:08 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Apr 16, 2021).

Description of the new idea

In the terminal settings UI, there is an option 'Open JSON file' that helps us to configure the terminal in an advanced manner. However from a design perspective, the option label 'Open JSON file' looks quite unprofessional. It can be changed to something like 'Advanced settings' or 'Advanced mode'.

Let me support my argument with an example:
The Windows 10 settings app allows us to configure various aspects of Windows in a simplified manner, but the advanced settings are present in Control Panel. For these advanced settings, usually a link named 'Advanced properties' is provided on the Settings page(s) that takes us to their respective Control Panel applet. Note that they did not use the term 'Open Control Panel' or something like that.

Proposed technical implementation details

The option label 'Open JSON file' should be changed to 'Advanced settings'. This also makes it more consistent with other elements of Windows. This is a relatively small change but is a significant improvement. It guides the new users that the option contains those settings which cannot be normally configured through the UI.

Originally created by @ghost on GitHub (Apr 16, 2021). # Description of the new idea In the terminal settings UI, there is an option 'Open JSON file' that helps us to configure the terminal in an advanced manner. However from a design perspective, the option label 'Open JSON file' looks quite unprofessional. It can be changed to something like 'Advanced settings' or 'Advanced mode'. Let me support my argument with an example: The Windows 10 settings app allows us to configure various aspects of Windows in a simplified manner, but the advanced settings are present in Control Panel. For these advanced settings, usually a link named 'Advanced properties' is provided on the Settings page(s) that takes us to their respective Control Panel applet. Note that they did not use the term 'Open Control Panel' or something like that. # Proposed technical implementation details The option label 'Open JSON file' should be changed to 'Advanced settings'. This also makes it more consistent with other elements of Windows. This is a relatively small change but is a significant improvement. It guides the new users that the option contains those settings which cannot be normally configured through the UI.
claunia commented 2026-01-31 03:44:10 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 16, 2021):

I kinda disagree, and here's my reasoning. When you go to the Control Panel, you're still getting a UI experience. However, with the "advanced settings" of the terminal, all of a sudden another app is opening to edit a .json file. That's maybe a little unexpected now. There's already been an endless stream of users confused with the old experience, where clicking on Settings would open up Visual Studio to edit the json file. I think it's actually clearer to indicate to the user that you're going to be opening a json file when you click that button.

@zadjii-msft commented on GitHub (Apr 16, 2021): I kinda disagree, and here's my reasoning. When you go to the Control Panel, you're still getting a UI experience. However, with the "advanced settings" of the terminal, all of a sudden another app is opening to edit a .json file. That's maybe a little unexpected now. There's already been an endless stream of users confused with the old experience, where clicking on Settings would open up Visual Studio to edit the json file. I think it's actually clearer to indicate to the user that you're going to be opening a json file when you click that button.
claunia commented 2026-01-31 03:44:10 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 16, 2021):

But that is not much of an issue. I have two things to say:

  • Tools like Windows Terminal are mostly, if not completely, used by system administrators and developers. They will not get panicked if suddenly Notepad opens up with a .json file. And you say that the switch from Settings to Control Panel is justified because Control Panel provides a UI experience. But you forgot that Control Panel is meant for everyday home and office users, but Windows Terminal is not. I agree to the fact that they may feel uncomfortable if they suddenly see a .json file, but in reality they will not even open the Windows Terminal app. All the existing users of Windows Terminal know very well about the settings.json file.
  • And as far as new users are concerned, we do not expect them to make changes to the terminal using the .json file (and that's why we made the Settings page, right?). And unless we completely remove the settings.json file, it would always be unexpected to see the .json file. Since there is no plan to remove it in the near future, this issue is irrelevant as one would definitely have to use it some day or the other. And even if we don't change its name we will not be able to remove that confusion entirely.

I hope you got my point.

@ghost commented on GitHub (Apr 16, 2021): But that is not much of an issue. I have two things to say: - Tools like Windows Terminal are mostly, if not completely, used by system administrators and developers. They will not get panicked if suddenly Notepad opens up with a .json file. And you say that the switch from Settings to Control Panel is justified because Control Panel provides a UI experience. But you forgot that Control Panel is meant for everyday home and office users, but Windows Terminal is not. I agree to the fact that they may feel uncomfortable if they suddenly see a .json file, but in reality they will not even open the Windows Terminal app. All the existing users of Windows Terminal know very well about the settings.json file. - And as far as new users are concerned, we do not expect them to make changes to the terminal using the .json file (and that's why we made the Settings page, right?). And unless we completely remove the settings.json file, it would always be unexpected to see the .json file. Since there is no plan to remove it in the near future, this issue is irrelevant as one would definitely have to use it some day or the other. And even if we don't change its name we will not be able to remove that confusion entirely. I hope you got my point.
claunia commented 2026-01-31 03:44:10 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 29, 2021):

After discussion with the team we've decided that we're gonna keep it as "Open in JSON". VsCode, for example, has very similar functionality and naming. Thanks for the suggestion!

@zadjii-msft commented on GitHub (Apr 29, 2021): After discussion with the team we've decided that we're gonna keep it as "Open in JSON". VsCode, for example, has very similar functionality and naming. Thanks for the suggestion!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Question Needs-Triage Product-Terminal Resolution-Answered
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13492
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?