starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Ask/warn on closing last tab of split pane #13522

New Issue
Closed
opened 2026-01-31 03:44:54 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 03:44:54 +00:00
Owner
Copy Link

Originally created by @htcfreek on GitHub (Apr 17, 2021).

Description of the new feature/enhancement

I have split-pane-mode with one tab per pane enabled. Closing one of the tabs (the last tab of a pane) closes the whole window.

Better would be to warn/ask the user.

Left pane Right pane
one tab (powershell) one tab (cmd)

Proposed technical implementation details (optional)

On closing the last tab of a split pane the user should be asked what to do:

  • Close pane.
  • Close window.
  • Cancel.
Originally created by @htcfreek on GitHub (Apr 17, 2021). # Description of the new feature/enhancement I have split-pane-mode with one tab per pane enabled. Closing one of the tabs (the last tab of a pane) closes the whole window. Better would be to warn/ask the user. Left pane | Right pane ------------ | ------------- one tab (powershell) | one tab (cmd) # Proposed technical implementation details (optional) On closing the last tab of a split pane the user should be asked what to do: - Close pane. - Close window. - Cancel.
claunia added the Issue-FeatureNeeds-TriageNeeds-Tag-Fix labels 2026-01-31 03:44:54 +00:00
claunia commented 2026-01-31 03:44:55 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Apr 18, 2021):

@htcfreek - I guess there is some naming confusion:

  • We have application Window
  • One or more tab are displayed on the top of this Window (like in a browser)
  • Each tab contains one or more panes
  • Each pane contains a terminal

Given this terminology, is you ask is about "Prompt upon closing the last pane of the tab"?

@Don-Vito commented on GitHub (Apr 18, 2021): @htcfreek - I guess there is some naming confusion: * We have application Window * One or more tab are displayed on the top of this Window (like in a browser) * Each tab contains one or more panes * Each pane contains a terminal Given this terminology, is you ask is about "Prompt upon closing the last pane of the tab"?
claunia commented 2026-01-31 03:44:55 +00:00
Author
Owner
Copy Link

@htcfreek commented on GitHub (Apr 18, 2021):

@Don-Vito
I agree to you that I misunderstand the UX hierarchy (window > tabs > panes).
But then for me the window was closed with two panes open in the last tab.

wt-close-splitpane

  1. There should be a warning that both panes are destroyed on closing the tab/window.
  2. Maybe it's possible to make it more clear that there are more than one console open in this tab. (I have an idea and upload a mock up later.)
    image
@htcfreek commented on GitHub (Apr 18, 2021): @Don-Vito I agree to you that I misunderstand the UX hierarchy (window > tabs > panes). But then for me the window was closed with two panes open in the last tab. ![wt-close-splitpane](https://user-images.githubusercontent.com/61519853/115156176-4b55b480-a083-11eb-8263-981a367b2e9a.gif) 1. There should be a warning that both panes are destroyed on closing the tab/window. 2. Maybe it's possible to make it more clear that there are more than one console open in this tab. (I have an idea and upload a mock up later.) ![image](https://user-images.githubusercontent.com/61519853/115156384-4e9d7000-a084-11eb-8778-cfd6bbdde1a2.png)
claunia commented 2026-01-31 03:44:55 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Apr 18, 2021):

@htcfreek - Thanks for the screen capture! What you ask makes a lot of sense! I was asking about the terminology just to check if we have such request already. Please see if https://github.com/microsoft/terminal/issues/5301 already addresses the same idea.

@Don-Vito commented on GitHub (Apr 18, 2021): @htcfreek - Thanks for the screen capture! What you ask makes a lot of sense! I was asking about the terminology just to check if we have such request already. Please see if https://github.com/microsoft/terminal/issues/5301 already addresses the same idea.
claunia commented 2026-01-31 03:44:56 +00:00
Author
Owner
Copy Link

@htcfreek commented on GitHub (Apr 18, 2021):

@htcfreek - Thanks for the screen capture! What you ask makes a lot of sense! I was asking about the terminology just to check if we have such request already. Please see if #5301 already addresses the same idea.

@Don-Vito
Yes the issue addresses the same idea. I'll add a suggestion in the other issue.
Should I open a new issue for the suggestion of split-pane info and close my issue?

@htcfreek commented on GitHub (Apr 18, 2021): > @htcfreek - Thanks for the screen capture! What you ask makes a lot of sense! I was asking about the terminology just to check if we have such request already. Please see if #5301 already addresses the same idea. @Don-Vito Yes the issue addresses the same idea. I'll add a suggestion in the other issue. Should I open a new issue for the suggestion of split-pane info and close my issue?
claunia commented 2026-01-31 03:44:56 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Apr 18, 2021):

I believe that you can repurpose this issue for adding panes info to the Tab title. I remember of seeing similar idea in some discussion but I cannot find it right now.

@Don-Vito commented on GitHub (Apr 18, 2021): I believe that you can repurpose this issue for adding panes info to the Tab title. I remember of seeing similar idea in some discussion but I cannot find it right now.
claunia commented 2026-01-31 03:44:56 +00:00
Author
Owner
Copy Link

@htcfreek commented on GitHub (Apr 18, 2021):

Closing as duplicate of #9883 and #5301.

@htcfreek commented on GitHub (Apr 18, 2021): Closing as duplicate of #9883 and #5301.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Needs-Tag-Fix Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13522
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?