SettingsUI: keep "page" when changing profile #13587

Closed
opened 2026-01-31 03:46:40 +00:00 by claunia · 15 comments
Owner

Originally created by @vefatica on GitHub (Apr 22, 2021).

Description of the new feature/enhancement

I have seven profiles. Yesterday I was leisurely switching among them in the SettingsUI, essentially comparing them. It would have been a better experience if the UI stayed on the same "page" ("General", "Appearance", "Advanced") when I switched profiles instead of automatically going to "General".

Originally created by @vefatica on GitHub (Apr 22, 2021). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement I have seven profiles. Yesterday I was leisurely switching among them in the SettingsUI, essentially comparing them. It would have been a better experience if the UI stayed on the same "page" ("General", "Appearance", "Advanced") when I switched profiles instead of automatically going to "General". <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> <!-- A clear and concise description of what you want to happen. -->
Author
Owner

@zadjii-msft commented on GitHub (Apr 23, 2021):

So for the record, I experimented with this before!

https://github.com/microsoft/terminal/pull/8844#issuecomment-764925226

should going back to "Windows PowerShell" have Appearance selected?

So, I had it that way in 67e38a3, but that actually felt weird. Idk, it was definitely a subjective choice, but it felt like changing profiles should return to the general pivot. Reverting that would be easy. It would I guess also fix the "rename profile returns to the general pivot" problem

idk, I'm conflicted on this. It felt weird before, but it seems like it makes sense on paper. I'll leave it for the team to discuss. The fix is trivial.

<discussion>

@zadjii-msft commented on GitHub (Apr 23, 2021): So for the record, I experimented with this before! https://github.com/microsoft/terminal/pull/8844#issuecomment-764925226 > > should going back to "Windows PowerShell" have Appearance selected? > > So, I had it that way in [67e38a3](https://github.com/microsoft/terminal/commit/67e38a307cb5917a3644c38045ede40e1188c6a3), but that actually felt weird. Idk, it was definitely a subjective choice, but it _felt_ like changing profiles should return to the general pivot. Reverting that would be easy. It would I guess also fix the "rename profile returns to the general pivot" problem idk, I'm conflicted on this. It felt weird before, but it seems like it makes sense on paper. I'll leave it for the team to discuss. The fix is trivial. \<discussion>
Author
Owner

@vefatica commented on GitHub (Apr 23, 2021):

In my case, I wanted to compare the appearances of various profiles. Moving around among the profiles took twice the mouse clicks. Starting at "General" is arbitrary (might as well start elsewhere) and doesn't seem to serve any purpose.

@vefatica commented on GitHub (Apr 23, 2021): In my case, I wanted to compare the appearances of various profiles. Moving around among the profiles took twice the mouse clicks. Starting at "General" is arbitrary (might as well start elsewhere) and doesn't seem to serve any purpose.
Author
Owner

@zadjii-msft commented on GitHub (Apr 26, 2021):

Team consensus: lets do it.

@zadjii-msft commented on GitHub (Apr 26, 2021): Team consensus: lets do it.
Author
Owner

@vefatica commented on GitHub (Apr 26, 2021):

Suits me. Watch all the complaints. 😁

@vefatica commented on GitHub (Apr 26, 2021): Suits me. Watch all the complaints. 😁
Author
Owner

@DHowett commented on GitHub (Apr 26, 2021):

Team consensus: lets do it.

Suits me. Watch all the complaints. 😁

Sorry? "Let's do it" is common parlance for "let us implement the thing that has been requested"...

@DHowett commented on GitHub (Apr 26, 2021): > Team consensus: lets do it. > Suits me. Watch all the complaints. 😁 Sorry? "Let's do it" is common parlance for "let us implement the thing that has been requested"...
Author
Owner

@vefatica commented on GitHub (Apr 26, 2021):

I figured that. What's your point? Was I wrong to close the issue?

@vefatica commented on GitHub (Apr 26, 2021): I figured that. What's your point? Was I wrong to close the issue?
Author
Owner

@DHowett commented on GitHub (Apr 26, 2021):

Yeah! We're gonna use this issue to track completing the work to make the profiles page remember where it was. Why'd you close it? 😄

@DHowett commented on GitHub (Apr 26, 2021): Yeah! We're gonna use this issue to track completing the work to make the profiles page remember where it was. Why'd you close it? :smile:
Author
Owner

@vefatica commented on GitHub (Apr 26, 2021):

I figured a decision was the end. You don't always use an original suggestion to do the tracking, do you?

@vefatica commented on GitHub (Apr 26, 2021): I figured a decision was the end. You don't always use an original suggestion to do the tracking, do you?
Author
Owner

@zadjii-msft commented on GitHub (Apr 26, 2021):

You don't always use an original suggestion to do the tracking, do you?

Not always, but like 99.97% of the time we do. We usually only file our own versions for follow-ups. Like, #653 is the thread tracking adding support for quake mode, but #8888 is the thread for "everything related to quake mode after the initial PR". The only exceptions I can think of are #1564 and #5000

@zadjii-msft commented on GitHub (Apr 26, 2021): > You don't always use an original suggestion to do the tracking, do you? Not always, but like 99.97% of the time we do. We usually only file our own versions for follow-ups. Like, #653 is the thread tracking adding support for quake mode, but #8888 is the thread for "everything related to quake mode after the initial PR". The only exceptions I can think of are #1564 and #5000
Author
Owner

@DHowett commented on GitHub (Apr 26, 2021):

AHH! I understand. Sorry! Yeah, Mike's got it here. We love to use the original issue since it lets the suggester know how we're doing, too. 😄

@DHowett commented on GitHub (Apr 26, 2021): AHH! I understand. Sorry! Yeah, Mike's got it here. We love to use the original issue since it lets the suggester know how we're doing, too. :smile:
Author
Owner

@vefatica commented on GitHub (Apr 26, 2021):

Then what ... someone comes back here, notes that it has been implemented, and closes it? I don't see a lot of that but I admit that I'm not paying close attention to many issues.

@vefatica commented on GitHub (Apr 26, 2021): Then what ... someone comes back here, notes that it has been implemented, and closes it? I don't see a lot of that but I admit that I'm not paying close attention to many issues.
Author
Owner

@DHowett commented on GitHub (Apr 26, 2021):

So, we use these issues (user suggestions, user bug reports, user requests even) as the currency of work tracking in our project. We talk about them all the time -- "let's fix 376" or "9920 is a good idea, let's do it" and then use that issue mostly for the lifetime of the request.

We mention it in any pull request, too:

  • "Closes #XXXX" or "Fixes #XXXX" are two keywords GitHub picks up to automatically close the related bug when the pull request merges
  • "Related to #XXXX" adds a link between the bug and the PR so somebody who's interested in how the work is going can follow it.

Once the feature is complete and released, the commit and the changelog entry mentions the pull request number. Our release bot finds all issues "Closed" or "Fixed" by any PR mentioned in the changelog, and tells the original submitter that their submitted issue, request, etc. was addressed in whatever version mentioned it.

@DHowett commented on GitHub (Apr 26, 2021): So, we use these issues (user suggestions, user bug reports, user requests even) as the currency of work tracking in our project. We talk about them all the time -- "let's fix 376" or "9920 is a good idea, let's do it" and then use that issue _mostly_ for the lifetime of the request. We mention it in any pull request, too: * "Closes #XXXX" or "Fixes #XXXX" are two keywords GitHub picks up to automatically close the related bug when the pull request merges * "Related to #XXXX" adds a link between the bug and the PR so somebody who's interested in how the work is going can follow it. Once the feature is complete and _released_, the commit and the changelog entry mentions the pull request number. Our release bot finds all issues "Closed" or "Fixed" by any PR mentioned in the changelog, and tells the original submitter that their submitted issue, request, etc. was addressed in whatever version mentioned it.
Author
Owner

@DHowett commented on GitHub (Apr 26, 2021):

I realize that I set a bad precedent with your issues specifically. I've closed them early when I did not agree with them, only to come back and fix the issue anyway. That makes it look like we track the work elsewhere . . . and I'm sorry about that! 😄

@DHowett commented on GitHub (Apr 26, 2021): I realize that I set a bad precedent with your issues specifically. I've closed them early when I did not agree with them, only to come back and fix the issue anyway. That makes it look like we track the work elsewhere . . . and I'm sorry about that! :smile:
Author
Owner

@vefatica commented on GitHub (Apr 26, 2021):

OK, that sounds vaguely familiar. Thanks for the explanation.

@vefatica commented on GitHub (Apr 26, 2021): OK, that sounds vaguely familiar. Thanks for the explanation.
Author
Owner

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #10047, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #10047, which has now been successfully released as `Windows Terminal Preview v1.9.1445.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1445.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13587