starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Functional-Command Palette] - Case sensitive commands in Russian localization #13617

New Issue
Closed
opened 2026-01-31 03:47:29 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 03:47:29 +00:00
Owner
Copy Link

Originally created by @whatsupbros on GitHub (Apr 24, 2021).

User Experience:
Users of Russian Windows localization can be confused, because commands are case sensitive. So, "Новая вкладка" ("New tab") command cannot be found with "новая" ("new") input string in lowercase, but can be found with "Новая" ("New"), which preserves the case.

Test Environment:
App: Windows Terminal 1.7.1033.0
Feature: Command Palette
OS: Microsoft Windows [Version 10.0.19042.928]

Repro Steps:

  1. Open Windows terminal app
  2. Open Command Palette using shortcut (ctrl+shift+p)
  3. Search for New tab command in the search field in Russian, use "новая" search string for this and see the empty result:
    1
  4. Now use "Новая" instead, see the different result
    2

Expected:
Commands in Command Pallete to be case insensitive.
In fact, commands should be findable in English also, even is Russian localization of the OS.

So, both "new" or "новая" search strings should find "Новая вкладка" command (which is Russian translation for "New tab").

Originally created by @whatsupbros on GitHub (Apr 24, 2021). **User Experience:** Users of Russian Windows localization can be confused, because commands are case sensitive. So, "Новая вкладка" ("New tab") command cannot be found with "новая" ("new") input string in lowercase, but can be found with "Новая" ("New"), which preserves the case. **Test Environment:** App: Windows Terminal 1.7.1033.0 Feature: Command Palette OS: Microsoft Windows [Version 10.0.19042.928] **Repro Steps:** 1. Open Windows terminal app 2. Open Command Palette using shortcut (ctrl+shift+p) 3. Search for New tab command in the search field in Russian, use "новая" search string for this and see the empty result: ![1](https://user-images.githubusercontent.com/667976/115973186-6a58b880-a553-11eb-8be5-c95dab724dc0.png) 4. Now use "Новая" instead, see the different result ![2](https://user-images.githubusercontent.com/667976/115973191-6f1d6c80-a553-11eb-9108-899bb7f16423.png) **Expected:** Commands in Command Pallete to be case insensitive. In fact, commands should be findable in English also, even is Russian localization of the OS. So, both "new" or "новая" search strings should find "Новая вкладка" command (which is Russian translation for "New tab").
claunia commented 2026-01-31 03:47:31 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Apr 25, 2021):

@ZZa - thanks for reporting.

It looks that we added locale aware case-sensitivity for commands sorting, but not for command filtering. Inside FilteredCommand::_computeHighlightedName we have:

const auto lowerCaseSearchChar = std::towlower(searchChar);
...
auto isCurrentCharMatched = std::towlower(commandName[currentOffset]) == lowerCaseSearchChar;

In the code above std::towlower uses default locale that for some reason is not Russian locale.

@Don-Vito commented on GitHub (Apr 25, 2021): @ZZa - thanks for reporting. It looks that we added locale aware case-sensitivity for commands sorting, but not for command filtering. Inside `FilteredCommand::_computeHighlightedName` we have: ``` const auto lowerCaseSearchChar = std::towlower(searchChar); ... auto isCurrentCharMatched = std::towlower(commandName[currentOffset]) == lowerCaseSearchChar; ``` In the code above `std::towlower` uses default locale that for some reason is not Russian locale.
claunia commented 2026-01-31 03:47:31 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Apr 25, 2021):

Forgot to mention, that the trivial fix is to use the same approach we have for sorting (lstrcmpi) to compare chars.
(There are other approaches, but I think this one is both trivial and robust).

@zadjii-msft - please assign this to me (hope to fix it later on).

@Don-Vito commented on GitHub (Apr 25, 2021): Forgot to mention, that the trivial fix is to use the same approach we have for sorting (lstrcmpi) to compare chars. (There are other approaches, but I think this one is both trivial and robust). @zadjii-msft - please assign this to me (hope to fix it later on).
claunia commented 2026-01-31 03:47:31 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Apr 25, 2021):

OK.. it was kinda "one-liner", so I did it, though didn't test it in Russian.

@Don-Vito commented on GitHub (Apr 25, 2021): OK.. it was kinda "one-liner", so I did it, though didn't test it in Russian.
claunia commented 2026-01-31 03:47:31 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #9943, which has now been successfully released as Windows Terminal v1.8.1444.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #9943, which has now been successfully released as `Windows Terminal v1.8.1444.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1444.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 03:47:31 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #9943, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #9943, which has now been successfully released as `Windows Terminal Preview v1.9.1445.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1445.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CmdPal Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13617
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?