starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Replace duplicateTab with newTab with arg #13632

New Issue
Open
opened 2026-01-31 03:47:51 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 03:47:51 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Apr 26, 2021).

Originally assigned to: @carlos-zamora on GitHub.

Description of the new feature/enhancement

duplicateTab and newTab are two different actions whereas splitPane accomplishes the functionality of both "duplicate my current pane" and "open a new pane". splitPane also lets the user use NewTerminalArgs to customize a duplicate pane.

I propose we do one of the following:

  1. Deprecate duplicateTab:
    • add a mode arg to newTab. Possible values include duplicateProfile and duplicatePaneStructure (see #4674). Default value is null.
    • duplicateTab still exists, but is just an alias for newTab with mode=duplicateProfile.
    • This gives us NewTerminalArgs for free and creates a consistent design across actions creating new panes and new tabs.
  2. Split splitPane into splitPane and duplicatePane:
    • duplicatePane would have 2 args: size and split (same behavior as from splitPane)
    • This provides a consistent design, but I feel that it doesn't provide adequate NewTerminalArgs benefits.

Other comments

Inspired by a comment made by @lhecker
#4674 Should be kept in mind with the new design.
I'm open to other ideas or different names for these actions/args.

Resources

duplicateTab docs
newTab docs
splitPane docs

Originally created by @carlos-zamora on GitHub (Apr 26, 2021). Originally assigned to: @carlos-zamora on GitHub. # Description of the new feature/enhancement `duplicateTab` and `newTab` are two different actions whereas `splitPane` accomplishes the functionality of both "duplicate my current pane" and "open a new pane". `splitPane` also lets the user use `NewTerminalArgs` to customize a duplicate pane. I propose we do one of the following: 1. Deprecate `duplicateTab`: - add a `mode` arg to `newTab`. Possible values include `duplicateProfile` and `duplicatePaneStructure` (see #4674). Default value is `null`. - `duplicateTab` still exists, but is just an alias for `newTab` with `mode=duplicateProfile`. - This gives us `NewTerminalArgs` for free and creates a consistent design across actions creating new panes and new tabs. 2. Split `splitPane` into `splitPane` and `duplicatePane`: - `duplicatePane` would have 2 args: `size` and `split` (same behavior as from `splitPane`) - This provides a consistent design, but I feel that it doesn't provide adequate `NewTerminalArgs` benefits. ### Other comments _Inspired by a comment made by @lhecker_ #4674 Should be kept in mind with the new design. I'm open to other ideas or different names for these actions/args. # Resources [`duplicateTab` docs](https://docs.microsoft.com/en-us/windows/terminal/customize-settings/actions#duplicate-tab) [`newTab` docs](https://docs.microsoft.com/en-us/windows/terminal/customize-settings/actions#new-tab) [`splitPane` docs](https://docs.microsoft.com/en-us/windows/terminal/customize-settings/actions#split-a-pane)
claunia added the Area-SettingsIssue-TaskProduct-Terminal labels 2026-01-31 03:47:51 +00:00
claunia commented 2026-01-31 03:47:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 26, 2021):

gods I hate this. I already deeply regret making "duplicate pane" an argument to splitPane instead of a separate action. I'm not sure there's anyone using "duplicate pane, but also I want x, y, and z to actually have the values foo, bar, baz". It means that there's this long, verbose action just for duplicate pane, and that's annoying. duplicatePane would have just been easier. Maybe I was just high on adding args to everything because we could. I never considered if we should 😆

I'd definitely prefer the second option, the "make a duplicatePane action" route. We can still throw args in duplicateTab for "duplicatePaneStructure: bool".

@zadjii-msft commented on GitHub (Apr 26, 2021): gods I hate this. I already deeply regret making "duplicate pane" an argument to `splitPane` instead of a separate action. I'm not sure there's anyone using "duplicate pane, but also I want `x`, `y`, and `z` to actually have the values foo, bar, baz". It means that there's this long, verbose action just for duplicate pane, and that's annoying. `duplicatePane` would have just been easier. Maybe I was just high on adding args to everything because we _could_. I never considered if we _should_ 😆 I'd definitely prefer the second option, the "make a `duplicatePane` action" route. We can still throw args in `duplicateTab` for "duplicatePaneStructure: bool".
claunia commented 2026-01-31 03:47:52 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 26, 2021):

Maybe I was just high on adding args to everything because we could. I never considered if we should 😆

And the pendulum swings. 😄

@DHowett commented on GitHub (Apr 26, 2021): > Maybe I was just high on adding args to everything because we _could_. I never considered if we _should_ 😆 And the pendulum swings. :smile:
claunia commented 2026-01-31 03:47:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 29, 2021):

Option 2 sounds cool

@zadjii-msft commented on GitHub (Apr 29, 2021): Option 2 sounds cool
claunia commented 2026-01-31 03:47:53 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Nov 7, 2022):

We've decided on option 1. Mainly because of #10232, #12985, and #14350.

We need to add duplicate: {true|false} to NewTerminalArgs, and make sure that new tab, new window code knows how to handle this.

We can promote that to an enum when we get to #4674.

@carlos-zamora commented on GitHub (Nov 7, 2022): We've decided on option 1. Mainly because of #10232, #12985, and #14350. We need to add `duplicate: {true|false}` to NewTerminalArgs, and make sure that new tab, new window code knows how to handle this. We can promote that to an enum when we get to #4674.
claunia commented 2026-01-31 03:47:53 +00:00
Author
Owner
Copy Link

@Aymkdn commented on GitHub (Jan 3, 2023):

Will this change permit to set the default behavior of the "new" button as a duplicate/clone of the current tab?
image

So when clicking on "new", we could duplicate the current tab instead of using the "Duplicate" menu?
image

@Aymkdn commented on GitHub (Jan 3, 2023): Will this change permit to set the default behavior of the "new" button as a duplicate/clone of the current tab? ![image](https://user-images.githubusercontent.com/946315/210413077-55ff631f-104a-4ed6-bad5-417ed841320a.png) So when clicking on "new", we could duplicate the current tab instead of using the "Duplicate" menu? ![image](https://user-images.githubusercontent.com/946315/210413411-ab75b371-3ac5-420d-8dd4-fbba19fa1f8f.png)
claunia commented 2026-01-31 03:47:53 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 3, 2023):

@Aymkdn This by itself - no. That we're tracking in #445.

@zadjii-msft commented on GitHub (Jan 3, 2023): @Aymkdn This by itself - no. That we're tracking in #445.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13632
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?