starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Sometimes, saving a setting in the UI doesn't actually apply #13642

New Issue
Closed
opened 2026-01-31 03:48:09 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 03:48:09 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Apr 26, 2021).

Originally assigned to: @carlos-zamora on GitHub.

The minimal repro:

  • Install powershell core, at least one of them
  • Close the Terminal.
  • Delete all the settings.json files.
  • Open the Terminal, go to the SUI, go to the "Appearance" of the Powershell Core.
  • Change scrollbar state to hidden.
  • Hit Save.

At this point, the SUI will reload. The scrollbar state didn't apply, and now you've got a mysterious "Default" profile. Also, the setting.json is now corrupted. It's now got

{},
{
  "scrollbarState": "hidden"
}

slammed in the profiles list, which is garbage data.

  • Figure out why the setting is blasting off to space.
  • Add a mitigation to ignore profile snippets without a GUID

/cc @carlos-zamora.

Now, I'm gonna close all the threads we think are a dupe of this one.

Originally created by @zadjii-msft on GitHub (Apr 26, 2021). Originally assigned to: @carlos-zamora on GitHub. The minimal repro: * Install powershell core, at least one of them * Close the Terminal. * Delete all the settings.json files. * Open the Terminal, go to the SUI, go to the "Appearance" of the Powershell Core. * Change scrollbar state to hidden. * Hit Save. At this point, the SUI will reload. The scrollbar state didn't apply, and now you've got a mysterious "Default" profile. Also, the `setting.json` is now corrupted. It's now got ``` {}, { "scrollbarState": "hidden" } ``` slammed in the profiles list, which is garbage data. * [ ] Figure out why the setting is blasting off to space. * [ ] Add a mitigation to ignore profile snippets without a GUID /cc @carlos-zamora. Now, I'm gonna close all the threads we think are a dupe of this one.
claunia commented 2026-01-31 03:48:11 +00:00
Author
Owner
Copy Link

@Krrishdhaneja commented on GitHub (Apr 27, 2021):

hey @zadjii-msft when I deleted the whole setting.json and got a new one generated, then the default profile was removed and it didn't reappear.

@Krrishdhaneja commented on GitHub (Apr 27, 2021): hey @zadjii-msft when I deleted the whole `setting.json` and got a new one generated, then the default profile was removed and it didn't reappear.
claunia commented 2026-01-31 03:48:11 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 27, 2021):

@Krrishdhaneja That sounds like a totally different issue. Mind filing a new issue? (make sure to include version numbers, which profile you were expecting to see generated, your settings.json, etc.)

@zadjii-msft commented on GitHub (Apr 27, 2021): @Krrishdhaneja That sounds like a totally different issue. Mind filing a new issue? (make sure to include version numbers, which profile you were expecting to see generated, your `settings.json`, etc.)
claunia commented 2026-01-31 03:48:11 +00:00
Author
Owner
Copy Link

@Krrishdhaneja commented on GitHub (Apr 27, 2021):

@Krrishdhaneja That sounds like a totally different issue. Mind filing a new issue? (make sure to include version numbers, which profile you were expecting to see generated, your settings.json, etc.)

I don't mind making it, but I am rather saying that it might be the solution to that default json profile maybe, by deleting the settings.json and then make changes in the regenerated one to get back older settings?

Can it be it's solution?

@Krrishdhaneja commented on GitHub (Apr 27, 2021): > > > @Krrishdhaneja That sounds like a totally different issue. Mind filing a new issue? (make sure to include version numbers, which profile you were expecting to see generated, your `settings.json`, etc.) I don't mind making it, but I am rather saying that it might be the solution to that default json profile maybe, by deleting the `settings.json` and then make changes in the regenerated one to get back older settings? Can it be it's solution?
claunia commented 2026-01-31 03:48:11 +00:00
Author
Owner
Copy Link

@htcfreek commented on GitHub (May 3, 2021):

@zadjii-msft
Does the pr fixes the bug that new profiles don't have a guid?

Every new profile I generate doesn't have a guid. So if you ignore these profiles you create a new problem. (How will this be fixed on updating to the new release?)

@htcfreek commented on GitHub (May 3, 2021): @zadjii-msft Does the pr fixes the bug that new profiles don't have a guid? Every new profile I generate doesn't have a guid. So if you ignore these profiles you create a new problem. (How will this be fixed on updating to the new release?)
claunia commented 2026-01-31 03:48:11 +00:00
Author
Owner
Copy Link

@Krrishdhaneja commented on GitHub (May 5, 2021):

Hey, today I encountered the issue again, and I think what could be possible reason for that is maybe when the modifications are made using SUI, the changes aren't registered in the profile we wanted/made changes for, but rather the SUI creates a completely new profile with those properties.

@Krrishdhaneja commented on GitHub (May 5, 2021): Hey, today I encountered the issue again, and I think what could be possible reason for that is maybe when the modifications are made using SUI, the changes aren't registered in the profile we wanted/made changes for, but rather the SUI creates a completely new profile with those properties.
claunia commented 2026-01-31 03:48:11 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 5, 2021):

@Krrishdhaneja Yep, that's basically the root cause of what we fixed in #9964

The "ignore snippets without a guid" mitigation should only apply to snippets without a name or guid. When a profile doesn't have an explicit guid, we generate one for that profile based on the name. in the case of the {} profile, there's no name or guid, so we can be relatively sure that blob isn't actually a valid profile.

I also think we didn't end up doing that, so it's not a big deal.

@zadjii-msft commented on GitHub (May 5, 2021): @Krrishdhaneja Yep, that's basically the root cause of what we fixed in #9964 The "ignore snippets without a guid" mitigation should only apply to snippets without a name or guid. When a profile doesn't have an explicit guid, we generate one for that profile based on the name. in the case of the `{}` profile, there's no name or guid, so we can be relatively sure that blob isn't actually a valid profile. I also think we didn't end up doing that, so it's not a big deal.
claunia commented 2026-01-31 03:48:12 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #9964, which has now been successfully released as Windows Terminal v1.8.1444.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #9964, which has now been successfully released as `Windows Terminal v1.8.1444.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1444.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 03:48:12 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #9964, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #9964, which has now been successfully released as `Windows Terminal Preview v1.9.1445.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1445.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13642
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?