Crash in main when writing settings to disk twice #13680

Open
opened 2026-01-31 03:49:25 +00:00 by claunia · 0 comments
Owner

Originally created by @PankajBhojwani on GitHub (Apr 30, 2021).

Originally assigned to: @zadjii-msft on GitHub.

Windows Terminal version (or Windows build number)

main

Other Software

N/A

Steps to reproduce

  1. Open SUI
  2. Navigate to any profile
  3. Change any setting
  4. Hit 'Save'
  5. Hit 'Save' again
  6. Crash

Alternatively:

  1. Open SUI
  2. Add a new profile
  3. Hit 'Save'
  4. Hit 'Save' again
  5. Crash

Expected Behavior

No crash

Actual Behavior

Terminal crashes. The crash seems to happen in the Model::DefaultTerminal::Current(_currentDefaultTerminal); call in CascadiaSettings::WriteSettingsToDisk(), added in #9907

Originally created by @PankajBhojwani on GitHub (Apr 30, 2021). Originally assigned to: @zadjii-msft on GitHub. ### Windows Terminal version (or Windows build number) main ### Other Software N/A ### Steps to reproduce 1. Open SUI 2. Navigate to any profile 3. Change any setting 4. Hit 'Save' 5. Hit 'Save' again 6. Crash Alternatively: 1. Open SUI 2. Add a new profile 3. Hit 'Save' 4. Hit 'Save' again 5. Crash ### Expected Behavior No crash ### Actual Behavior Terminal crashes. The crash seems to happen in the `Model::DefaultTerminal::Current(_currentDefaultTerminal);` call in `CascadiaSettings::WriteSettingsToDisk()`, added in #9907
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13680