starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Wrong simplified Chinese translation such as "向竖起大拇指移动焦点" #13738

New Issue
Closed
opened 2026-01-31 03:50:47 +00:00 by claunia · 11 comments
claunia commented 2026-01-31 03:50:47 +00:00
Owner
Copy Link

Originally created by @JingHuaMan on GitHub (May 6, 2021).

Windows Terminal version (or Windows build number)

1.7.1033.0

Other Software

No response

Steps to reproduce

Language: Simplified Chinese

设置 (settings) -> 操作

image

Expected Behavior

It seems that some of the translations are wrong:

  1. Not 下面是当前绑定密钥, it should be 下面是当前绑定热键
  2. Not 向 向下移动焦点, it should be 向下移动焦点
  3. Not 向 竖起大拇指移动焦点, it should be 向上移动焦点
  4. Not 打开设置。。。, it should be 打开设置

Actual Behavior

image
image
image

Originally created by @JingHuaMan on GitHub (May 6, 2021). ### Windows Terminal version (or Windows build number) 1.7.1033.0 ### Other Software _No response_ ### Steps to reproduce Language: Simplified Chinese `设置` (settings) -> `操作` ![image](https://user-images.githubusercontent.com/49118946/117235815-0d65d800-ae5a-11eb-9bac-c62fa7bbdef7.png) ### Expected Behavior It seems that some of the translations are wrong: 1. Not `下面是当前绑定密钥`, it should be `下面是当前绑定热键` 2. Not `向 向下移动焦点`, it should be `向下移动焦点` 3. Not `向 竖起大拇指移动焦点`, it should be `向上移动焦点` 4. Not `打开设置。。。`, it should be `打开设置` ### Actual Behavior ![image](https://user-images.githubusercontent.com/49118946/117236233-e3f97c00-ae5a-11eb-9ef7-246490b67e91.png) ![image](https://user-images.githubusercontent.com/49118946/117236245-e8be3000-ae5a-11eb-9d4d-05025acd28b6.png) ![image](https://user-images.githubusercontent.com/49118946/117236257-ecea4d80-ae5a-11eb-8080-104666dfdd6c.png)
claunia added the Needs-TriageNeeds-Tag-FixArea-Localization labels 2026-01-31 03:50:47 +00:00
claunia commented 2026-01-31 03:50:48 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (May 6, 2021):

Thanks for the feedback! I've posted similar localization defects in #9328. Could you also organize these recommendation like that? It could be really helpful for us.

@skyline75489 commented on GitHub (May 6, 2021): Thanks for the feedback! I've posted similar localization defects in #9328. Could you also organize these recommendation like that? It could be really helpful for us.
claunia commented 2026-01-31 03:50:48 +00:00
Author
Owner
Copy Link

@JingHuaMan commented on GitHub (May 6, 2021):

@skyline75489 Sorry, where can I get the key values like Globals_LaunchModeMaximized.Content?

@JingHuaMan commented on GitHub (May 6, 2021): @skyline75489 Sorry, where can I get the key values like `Globals_LaunchModeMaximized.Content`?
claunia commented 2026-01-31 03:50:48 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (May 6, 2021):

Those strings are inside the source code of the terminal repo. If you can't find them, don't worry about it. I can fill up a table later.

@skyline75489 commented on GitHub (May 6, 2021): Those strings are inside the source code of the terminal repo. If you can't find them, don't worry about it. I can fill up a table later.
claunia commented 2026-01-31 03:50:48 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 6, 2021):

In English, those resources can be found here: https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw. I think the translations get patched in later, so the chinese versions aren't anywhere in the repo.

Looks like these are mostly just translations for various different actions, so that's not totally unexpected. @DHowett should we just combine these with the rest in #9328?

@zadjii-msft commented on GitHub (May 6, 2021): In English, those resources can be found here: https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw. I think the translations get patched in later, so the chinese versions aren't anywhere in the repo. Looks like these are mostly just translations for various different actions, so that's not totally unexpected. @DHowett should we just combine these with the rest in #9328?
claunia commented 2026-01-31 03:50:49 +00:00
Author
Owner
Copy Link

@JingHuaMan commented on GitHub (May 7, 2021):

The wrong translation of "密钥" is already mentioned in #9328 .

<html>
Key Recommandation Comment
ResetFontSizeCommandKey Change the translation of "font size" to "字体大小" "字号" is not a wrong translation, but not so accurate
DirectionUp 上 not "竖起大拇指"
DirectionDown 下  not "向下", otherwise there will be two duplicate "向"
OpenSettingsUICommandKey Don't translate "..." or translate it to "......"  In simplified Chinese, the ellipsis is "......" (why ellipsis?)

</html>
@JingHuaMan commented on GitHub (May 7, 2021): The wrong translation of "密钥" is already mentioned in #9328 . <html> <body> <!--StartFragment--><!DOCTYPE html><figure class="md-table-fig" cid="n45" mdtype="table" style="box-sizing: border-box; margin: 1.2em 0px; overflow-x: auto; max-width: calc(100% + 16px); padding: 0px; cursor: default; color: rgb(52, 73, 94); font-family: Ubuntu, &quot;Source Sans Pro&quot;, sans-serif; font-size: 16px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-style: initial; text-decoration-color: initial;"> Key | Recommandation | Comment -- | -- | -- ResetFontSizeCommandKey | Change the translation of "font size" to "字体大小" | "字号" is not a wrong translation, but not so accurate DirectionUp | 上 | not "竖起大拇指" DirectionDown | 下 |  not "向下", otherwise there will be two duplicate "向" OpenSettingsUICommandKey | Don't translate "..." or translate it to "......" |  In simplified Chinese, the ellipsis is "......" (why ellipsis?) </figure><br class="Apple-interchange-newline"><!--EndFragment--> </body> </html>
claunia commented 2026-01-31 03:50:49 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (May 7, 2021):

The internal workitem (MSFT-32515306) associated with #9328 is closed. Maybe we need a new one?

You know what, how about I just double check the localization things when 1.9 is out, to avoid the fragmented reports regarding localization issues. Is it OK with you @JingHuaMan ? Thanks again for catching these.

@skyline75489 commented on GitHub (May 7, 2021): The internal workitem ([MSFT-32515306](https://task.ms/32515306)) associated with #9328 is closed. Maybe we need a new one? You know what, how about I just double check the localization things when 1.9 is out, to avoid the fragmented reports regarding localization issues. Is it OK with you @JingHuaMan ? Thanks again for catching these.
claunia commented 2026-01-31 03:50:49 +00:00
Author
Owner
Copy Link

@JingHuaMan commented on GitHub (May 7, 2021):

Yes, of course!

@JingHuaMan commented on GitHub (May 7, 2021): Yes, of course!
claunia commented 2026-01-31 03:50:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 22, 2021):

@skyline75489 You should be selfhosting 1.9 if you go to the store and update -- can you check your strings? 😄

@DHowett commented on GitHub (May 22, 2021): @skyline75489 You should be selfhosting 1.9 if you go to the store and update -- can you check your strings? :smile:
claunia commented 2026-01-31 03:50:49 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (May 24, 2021):

@DHowett I've received the 1.9 selfhost version and looks like most of my strings are better localized (don't really wanna brag but it is a lot better now). I'll double-check and file another issue to supersede this later. Let's squash those localization bugs before 2.0 😄

@skyline75489 commented on GitHub (May 24, 2021): @DHowett I've received the 1.9 selfhost version and looks like most of my strings are better localized (don't really wanna brag but it is *a lot* better now). I'll double-check and file another issue to supersede this later. Let's squash those localization bugs before 2.0 😄
claunia commented 2026-01-31 03:50:49 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (May 25, 2021):

Hi @JingHuaMan I'm closing this in favor of #10174. Take a look if you like 😄

@skyline75489 commented on GitHub (May 25, 2021): Hi @JingHuaMan I'm closing this in favor of #10174. Take a look if you like 😄
claunia commented 2026-01-31 03:50:50 +00:00
Author
Owner
Copy Link

@sv158 commented on GitHub (Nov 6, 2021):

My Windows Terminal still use "密钥" represent key rather than "热键", does this issue already fixed?

Windows Terminal version: 1.11.2921.0, from Microsft store
OS version: Windows 10 21H1(19043.1288).

@sv158 commented on GitHub (Nov 6, 2021): My Windows Terminal still use "密钥" represent `key` rather than "热键", does this issue already fixed? Windows Terminal version: 1.11.2921.0, from Microsft store OS version: Windows 10 21H1(19043.1288).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Localization Needs-Tag-Fix Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13738
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?