Combine pane taskbar states in the taskbar #13803

Closed
opened 2026-01-31 03:52:31 +00:00 by claunia · 4 comments
Owner

Originally created by @zadjii-msft on GitHub (May 13, 2021).

Originally assigned to: @zadjii-msft on GitHub.

It doesn't seem like a bad idea to combine these states somehow (with a setting), but we'd want to make sure we're clear what happens in cases like:

  • one tab has progress=N%, another tab has no progress
  • one tab has progress=N%, another tab has progress=M%
  • one tab has progress=N%, another tab has progress=indeterminate
  • one tab has progress=N%, another tab has progress=M% AND is in the error state

etc.

Sure, we have to specify this exhaustively.

It is specified in Taskbar API here how progress bars are combined for multiple windows collapsed into single button. For consistency it would be good idea to duplicate the behavior.

Originally posted by @tringi in https://github.com/microsoft/terminal/issues/6700#issuecomment-770590932

Originally created by @zadjii-msft on GitHub (May 13, 2021). Originally assigned to: @zadjii-msft on GitHub. > > It doesn't seem like a bad idea to combine these states somehow (with a setting), but we'd want to make sure we're clear what happens in cases like: > > > > * one tab has progress=N%, another tab has no progress > > * one tab has progress=N%, another tab has progress=M% > > * one tab has progress=N%, another tab has progress=indeterminate > > * one tab has progress=N%, another tab has progress=M% AND is in the error state > > > > etc. > > Sure, we have to specify this exhaustively. It is specified in [Taskbar API here](https://docs.microsoft.com/en-us/windows/win32/api/shobjidl_core/nf-shobjidl_core-itaskbarlist3-setprogressstate#how-the-taskbar-button-chooses-the-progress-indicator-for-a-group) how progress bars are combined for multiple windows collapsed into single button. For consistency it would be good idea to duplicate the behavior. _Originally posted by @tringi in https://github.com/microsoft/terminal/issues/6700#issuecomment-770590932_
Author
Owner

@zadjii-msft commented on GitHub (Jul 14, 2021):

Interesting. There are already some other weird edge cases about the progress state I didn't notice before, but are making testing.... tricky.

first

  • set one pane to indeterminate, the other to warning,75%. If you focus the warning pane, the taskbar will show warning,75%. If you then focus the indeterminate pane, the taskbar will switch to warning,100%. Focus another tab, then back to the tab with the indeterminate pane - correctly shows indeterminate in the TB.
  • same will repro with error,x%.
  • That will not repro with normal,y%. Interesting.

These were fixed in d5a14f9a1.

second

  • Setting the progress in a pane doesn't always update the tab/window? weird though I can't get this one to repro anymore.

more to follow...

@zadjii-msft commented on GitHub (Jul 14, 2021): Interesting. There are already some other weird edge cases about the progress state I didn't notice before, but are making testing.... tricky. #### first * set one pane to indeterminate, the other to warning,75%. If you focus the warning pane, the taskbar will show warning,75%. If you then focus the indeterminate pane, the taskbar will switch to warning,100%. Focus another tab, then back to the tab with the indeterminate pane - correctly shows indeterminate in the TB. * same will repro with error,x%. * That will _not_ repro with normal,y%. Interesting. These were fixed in d5a14f9a1. #### second * Setting the progress in a pane doesn't always update the tab/window? weird though I can't get this one to repro anymore. _more to follow..._
Author
Owner

@zadjii-msft commented on GitHub (Jul 14, 2021):

I'm not sure I totally love this, the way it's exactly specified by the taskbar API. For them, they always combine the states of an entire group of windows, with a priority order. So if there's multiple windows with different states, then "Error" is more important than "Warning", more than "Normal", more than "Indeterminate".

IMO, I'd almost expect more nuance to this. It feels weird to have the focused pane be set to indeterminate, then an adjacent pane set to (normal,25), and have the tab and taskbar show (normal,25).

image

I kinda think that the focused pane should always take priority, if it has progress set at all. If it doesn't, then I think we should fall back to the "combine" behavior. Same with the window itself - if the focused tab has a set progress state, let's use that one. Otherwise, we'll fall back to combining the states of all the other tabs.

Current progress is in dev/migrie/b/progress-bugs

@zadjii-msft commented on GitHub (Jul 14, 2021): I'm not sure I totally love this, the way it's exactly specified by the taskbar API. For them, they always combine the states of an entire group of windows, with a priority order. So if there's multiple windows with different states, then "Error" is more important than "Warning", more than "Normal", more than "Indeterminate". IMO, I'd almost expect more nuance to this. It feels weird to have the focused pane be set to indeterminate, then an adjacent pane set to (normal,25), and have the tab and taskbar show (normal,25). ![image](https://user-images.githubusercontent.com/18356694/125645766-36356dad-f8b7-447f-b11f-925c43b9081b.png) I kinda think that the focused pane should always take priority, if it has progress set at all. If it doesn't, then I think we should fall back to the "combine" behavior. Same with the window itself - if the focused tab has a set progress state, let's use that one. Otherwise, we'll fall back to combining the states of all the other tabs. Current progress is in `dev/migrie/b/progress-bugs`
Author
Owner

@tringi commented on GitHub (Jul 15, 2021):

The Taskbar rules, prioritizing errors, are designed to bring attention to issues the user can solve, or should be notified.

For example: It would be irritating if you had put two copy operations on the background, and once one had finished, the button would turn from green to orange/red, to indicate prompt (e.g. overwrite) at 1%, which you could've solved much sooner and saved time.

@tringi commented on GitHub (Jul 15, 2021): The Taskbar rules, prioritizing errors, are designed to bring attention to issues the user can solve, or should be notified. For example: It would be irritating if you had put two copy operations on the background, and once one had finished, the button would turn from green to orange/red, to indicate prompt (e.g. overwrite) at 1%, which you could've solved much sooner and saved time.
Author
Owner

@ghost commented on GitHub (Aug 31, 2021):

:tada:This issue was addressed in #10755, which has now been successfully released as Windows Terminal Preview v1.11.2421.0.🎉

Handy links:

@ghost commented on GitHub (Aug 31, 2021): :tada:This issue was addressed in #10755, which has now been successfully released as `Windows Terminal Preview v1.11.2421.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.11.2421.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13803