starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Remove "feedback" from the dropdown, and replace with "Command Palette" #13888

New Issue
Closed
opened 2026-01-31 03:54:57 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 03:54:57 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (May 24, 2021).

  • we know for a fact that no one's filed any issues using the feedback button
  • We know that the command palette is terribly undiscoverable
  • the command palette is also a great entry to discover basically every other command we have

so let's yank feedback, and replace with the cmdpal.

In the future, the new tab dropdown will be defaulted to [allProfiles, separator, toggleCommandPalette()] (#1571), so someone can remove it if they want.

Notes: might need to manually toss focus to the cmdpal - let's be careful here

Originally created by @zadjii-msft on GitHub (May 24, 2021). * we know for a fact that no one's filed any issues using the feedback button * We know that the command palette is terribly undiscoverable * the command palette is also a great entry to discover _basically every other command we have_ so let's yank feedback, and replace with the cmdpal. In the future, the new tab dropdown will be defaulted to `[allProfiles, separator, toggleCommandPalette()]` (#1571), so someone can remove it if they want. Notes: might need to manually toss focus to the cmdpal - let's be careful here
claunia commented 2026-01-31 03:54:59 +00:00
Author
Owner
Copy Link

@KnapSac commented on GitHub (May 26, 2021):

I'd like to give this a shot, am I correct that this would need to be changed:
27582a9186/src/cascadia/TerminalApp/TerminalPage.cpp (L686-L696)

@KnapSac commented on GitHub (May 26, 2021): I'd like to give this a shot, am I correct that this would need to be changed: https://github.com/microsoft/terminal/blob/27582a9186c39ea9f5caf070e08fd80e50e1d587/src/cascadia/TerminalApp/TerminalPage.cpp#L686-L696
claunia commented 2026-01-31 03:54:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 27, 2021):

@KnapSac That's exactly the spot! I believe the team consensus was to use the "LightningBolt" icon, which is \xE945

@zadjii-msft commented on GitHub (May 27, 2021): @KnapSac That's exactly the spot! I believe the team consensus was to use the "LightningBolt" icon, which is `\xE945 `
claunia commented 2026-01-31 03:54:59 +00:00
Author
Owner
Copy Link

@KnapSac commented on GitHub (May 27, 2021):

I have a couple uni assignments to finish up, but I expect to have a PR ready by early next week.

In the settings UI, the "Actions" page has a keyboard icon. Wouldn't it make more sense to keep these 2 icons the same? Since the command palette provides access to those actions?

@KnapSac commented on GitHub (May 27, 2021): I have a couple uni assignments to finish up, but I expect to have a PR ready by early next week. In the settings UI, the "Actions" page has a keyboard icon. Wouldn't it make more sense to keep these 2 icons the same? Since the command palette provides access to those actions?
claunia commented 2026-01-31 03:54:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 27, 2021):

That's a good observation!

We're actually only temporarily using the keyboard icon for the actions page. I think in the long run, we're actually planning on moving that to the lightning bolt as well. Right now the actions page only really works for actions that are bound to the keyboard, hence the keyboard icon. We have plans to update that page in the future to support configuring all actions, including everything in the command palette. This ties into some other plans we have for having actions accessible from the keyboard, the command palette, the new tab dropdown, the context menu... basically a ton of places.

I'll also tag in @cinnamon-msft, who can override that decision if they like.

@zadjii-msft commented on GitHub (May 27, 2021): That's a good observation! We're actually only _temporarily_ using the keyboard icon for the actions page. I think in the long run, we're actually planning on moving that to the lightning bolt as well. Right now the actions page only really works for actions that are bound to the keyboard, hence the keyboard icon. We have plans to update that page in the future to support configuring _all_ actions, including everything in the command palette. This ties into some other plans we have for having actions accessible from the keyboard, the command palette, the new tab dropdown, the context menu... basically a ton of places. I'll also tag in @cinnamon-msft, who can override that decision if they like.
claunia commented 2026-01-31 03:54:59 +00:00
Author
Owner
Copy Link

@Chips1234 commented on GitHub (May 29, 2021):

@zadjii-msft If we're going to get rid of the "feedback" menu item, should we then add a "feedback" link in the "About" window that needs to feedback hub or "Visit our GitHub repository" that leads here?

@Chips1234 commented on GitHub (May 29, 2021): @zadjii-msft If we're going to get rid of the "feedback" menu item, should we then add a "feedback" link in the "About" window that needs to feedback hub or "Visit our GitHub repository" that leads here?
claunia commented 2026-01-31 03:55:00 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 14, 2021):

:tada:This issue was addressed in #10297, which has now been successfully released as Windows Terminal Preview v1.10.1933.0.🎉

Handy links:

@ghost commented on GitHub (Jul 14, 2021): :tada:This issue was addressed in #10297, which has now been successfully released as `Windows Terminal Preview v1.10.1933.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.10.1933.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface good first issue Help Wanted Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13888
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?