starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Using 'Toggle command palette' action from palette doesn't close palette #13997

New Issue
Closed
opened 2026-01-31 03:58:00 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 03:58:00 +00:00
Owner
Copy Link

Originally created by @KnapSac on GitHub (May 27, 2021).

Windows Terminal version (or Windows build number)

1.9.1445.0

Other Software

No response

Steps to reproduce

  • Open the command palette
  • Search for: Toggle command palette
  • Hit enter to use that action

Expected Behavior

I'd expect the palette to close when using the Toggle command palette item in the palette. This is also what happens when you use the toggle shortcut while the palette is open.

Actual Behavior

The entered search text is cleared, and the palette remains open. The code responsible seems to be:
b2c2a4c159/src/cascadia/TerminalApp/AppActionHandlers.cpp (L369-L380)

When the command palette is open, and you use the shortcut to toggle its visibility, CommandPalette().Visibility() correctly returns Visibility::Visible and the palette is closed. On the other hand, when using the entry in the palette, CommandPalette().Visibility() returns Visibility::Collapsed, which causes the palette to remain open.

Originally created by @KnapSac on GitHub (May 27, 2021). ### Windows Terminal version (or Windows build number) 1.9.1445.0 ### Other Software _No response_ ### Steps to reproduce - Open the command palette - Search for: `Toggle command palette` - Hit enter to use that action ### Expected Behavior I'd expect the palette to close when using the `Toggle command palette` item in the palette. This is also what happens when you use the toggle shortcut while the palette is open. ### Actual Behavior The entered search text is cleared, and the palette remains open. The code responsible seems to be: https://github.com/microsoft/terminal/blob/b2c2a4c159b7e918ea8aabc9e22f83d58a479002/src/cascadia/TerminalApp/AppActionHandlers.cpp#L369-L380 When the command palette is open, and you use the shortcut to toggle its visibility, `CommandPalette().Visibility()` correctly returns `Visibility::Visible` and the palette is closed. On the other hand, when using the entry in the palette, `CommandPalette().Visibility()` returns `Visibility::Collapsed`, which causes the palette to remain open.
claunia commented 2026-01-31 03:58:03 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 28, 2021):

Huh. Good catch!

@zadjii-msft commented on GitHub (May 28, 2021): Huh. Good catch!
claunia commented 2026-01-31 03:58:03 +00:00
Author
Owner
Copy Link

@KnapSac commented on GitHub (May 28, 2021):

I'll see if I can track down what's causing this.

@KnapSac commented on GitHub (May 28, 2021): I'll see if I can track down what's causing this.
claunia commented 2026-01-31 03:58:03 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 14, 2021):

:tada:This issue was addressed in #10423, which has now been successfully released as Windows Terminal v1.9.1942.0.🎉

Handy links:

@ghost commented on GitHub (Jul 14, 2021): :tada:This issue was addressed in #10423, which has now been successfully released as `Windows Terminal v1.9.1942.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1942.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 03:58:03 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 14, 2021):

:tada:This issue was addressed in #10423, which has now been successfully released as Windows Terminal Preview v1.10.1933.0.🎉

Handy links:

@ghost commented on GitHub (Jul 14, 2021): :tada:This issue was addressed in #10423, which has now been successfully released as `Windows Terminal Preview v1.10.1933.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.10.1933.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CmdPal Help Wanted Issue-Bug Needs-Tag-Fix Needs-Triage Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#13997
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?