starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

C1 control characters break SetConsoleTitleW API #14088

New Issue
Closed
opened 2026-01-31 04:00:35 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 04:00:35 +00:00
Owner
Copy Link

Originally created by @alabuzhev on GitHub (Jun 2, 2021).

Windows Terminal version (or Windows build number)

1.9.1445.0

Other Software

No response

Steps to reproduce

  • Compile and run the following code:
#include <windows.h>

int main()
{
	if (!SetConsoleTitleW(L"\x80 Spanish Inquisition"))
		return 1;

	MessageBox(0, "I didn't expect that", 0, 0);
}
  • Look at the screen and listen.

Expected Behavior

The title is set.

Actual Behavior

  • Terminal beeps and prints the string on the screen. MSDN doesn't mention any such visual or sound effects.
  • The console title is not set, yet the function returns TRUE.

This is true for other C1 characters as well, not only 0x80.

P.S. The example is not synthetic: these characters can appear in directory and file names and applications can display the current path, the name of the opened file etc. in the console title.

Originally created by @alabuzhev on GitHub (Jun 2, 2021). ### Windows Terminal version (or Windows build number) 1.9.1445.0 ### Other Software _No response_ ### Steps to reproduce - Compile and run the following code: ```C++ #include <windows.h> int main() { if (!SetConsoleTitleW(L"\x80 Spanish Inquisition")) return 1; MessageBox(0, "I didn't expect that", 0, 0); } ``` - Look at the screen and listen. ### Expected Behavior The title is set. ### Actual Behavior - Terminal *beeps* and prints the string *on the screen*. [MSDN](https://docs.microsoft.com/en-us/windows/console/setconsoletitle) doesn't mention any such visual or sound effects. - The console title is not set, yet the function returns TRUE. This is true for other C1 characters as well, not only 0x80. P.S. The example is not synthetic: these characters can appear in directory and file names and applications can display the current path, the name of the opened file etc. in the console title.
claunia commented 2026-01-31 04:00:38 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jun 2, 2021):

I can't reproduce this in conhost - even a current build of OpenConsole - so I think this one is actually just a conpty issue. It looks like we sanitize the string before passing it through, but only strip out C0 controls and not C1 controls. See here:
b3775bc2b0/src/host/getset.cpp (L1929-L1945)

@j4james commented on GitHub (Jun 2, 2021): I can't reproduce this in conhost - even a current build of OpenConsole - so I _think_ this one is actually just a conpty issue. It looks like we sanitize the string before passing it through, but only strip out C0 controls and not C1 controls. See here: https://github.com/microsoft/terminal/blob/b3775bc2b0b46f9bca873594d47a739223211f21/src/host/getset.cpp#L1929-L1945
claunia commented 2026-01-31 04:00:38 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 31, 2021):

:tada:This issue was addressed in #10847, which has now been successfully released as Windows Terminal Preview v1.10.2383.0.🎉

Handy links:

@ghost commented on GitHub (Aug 31, 2021): :tada:This issue was addressed in #10847, which has now been successfully released as `Windows Terminal Preview v1.10.2383.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.10.2383.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 04:00:38 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 31, 2021):

:tada:This issue was addressed in #10847, which has now been successfully released as Windows Terminal Preview v1.11.2421.0.🎉

Handy links:

@ghost commented on GitHub (Aug 31, 2021): :tada:This issue was addressed in #10847, which has now been successfully released as `Windows Terminal Preview v1.11.2421.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.11.2421.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Area-VT Help Wanted In-PR Issue-Bug Priority-2 Product-Conpty
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14088
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?