starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Make the TabView span the entire window width #14096

New Issue
Closed
opened 2026-01-31 04:00:45 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 04:00:45 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Jun 3, 2021).

Description of the new feature/enhancement

The TabView currently stops after the add button. This is a problem because it has a shadow which gets interrupted.
It's harder to see with the default gray titlebar, but if you could change it to white it would be noticeable.

It would be ideal if the TabView would span the entire window.

tabviewcurrent
tabviewfixed

Proposed technical implementation details

It can be achieved by moving the drag bar and caption buttons inside the TabStripFooter.

Originally created by @ghost on GitHub (Jun 3, 2021). # Description of the new feature/enhancement The TabView currently stops after the add button. This is a problem because it has a shadow which gets interrupted. It's harder to see with the default gray titlebar, but if you could change it to white it would be noticeable. It would be ideal if the TabView would span the entire window. ![tabviewcurrent](https://user-images.githubusercontent.com/84711285/120685914-14a7f200-c4a9-11eb-8f80-8e38ecc09f9c.png) ![tabviewfixed](https://user-images.githubusercontent.com/84711285/120685920-15d91f00-c4a9-11eb-9318-e36599cb817f.png) # Proposed technical implementation details It can be achieved by moving the drag bar and caption buttons inside the TabStripFooter.
claunia commented 2026-01-31 04:00:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 6, 2021):

So this is a cool idea, but also fraught with peril. We're doing all sorts of wonky Win32 hacks to let the user drag that region as it is. I'd love to have the shadow work across that entire region, but we'll need to be careful to not break that behavior.

@zadjii-msft commented on GitHub (Jul 6, 2021): So this is a cool idea, but also fraught with peril. We're doing all sorts of wonky Win32 hacks to let the user drag that region as it is. I'd love to have the shadow work across that entire region, but we'll need to be careful to not break that behavior.
claunia commented 2026-01-31 04:00:47 +00:00
Author
Owner
Copy Link

@orcmid commented on GitHub (Jul 6, 2021):

@zadjii-msft > ... let the user drag that region

Yes, I have already become seriously frustrated by applications that shrink the draggable part of the title bar because of other cruft piling up there. (I confess that I have become fond of Edge's shrinkiable vertical tabs and how it leaves a wide title bar with the title of the tab for the current focus.)

@orcmid commented on GitHub (Jul 6, 2021): @zadjii-msft > ... let the user drag that region Yes, I have already become seriously frustrated by applications that shrink the draggable part of the title bar because of other cruft piling up there. (I confess that I have become fond of Edge's shrinkiable vertical tabs and how it leaves a wide title bar with the title of the tab for the current focus.)
claunia commented 2026-01-31 04:00:47 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 6, 2021):

Yep -- if we do this, we'll need to make sure that AppHost can still communicate with NonClientIslandWindow to let it know where the draggable region is.

We used to do this because we had to punch a hole in the XAML window where no content could be displayed -- now it's just an implementation of convenience (read: software engineering is lazy and optimizes around local maxima sometimes 😁) since we have a different drag bar implementation. 😄

@DHowett commented on GitHub (Jul 6, 2021): Yep -- if we do this, we'll need to make sure that AppHost can still communicate with NonClientIslandWindow to let it know where the draggable region is. We used to do this because we had to punch a hole in the XAML window where no content could be displayed -- now it's just an implementation of convenience (read: software engineering is lazy and optimizes around local maxima sometimes :grin:) since we have a different drag bar implementation. :smile:
claunia commented 2026-01-31 04:00:48 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 23, 2023):

Oh hey we did this in #12916

@zadjii-msft commented on GitHub (Aug 23, 2023): Oh hey we did this in #12916
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Task Needs-Tag-Fix Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14096
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?