starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Crash when creating two tabs from within a batch script launched in the same terminal window #14110

New Issue
Open
opened 2026-01-31 04:01:13 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 04:01:13 +00:00
Owner
Copy Link

Originally created by @kaetemi on GitHub (Jun 4, 2021).

Originally assigned to: @zadjii-msft on GitHub.

Windows Terminal version (or Windows build number)

1.8.1444

Other Software

No response

Steps to reproduce

Crash when creating two tabs from within a batch script launched in the same terminal window.

Create the following files.

test1.bat:

wt -w test -d . -p "Command Prompt" test2.bat

test2.bat:

wt -w test -d . -p "Command Prompt" test3.bat
wt -w test -d . -p "Command Prompt" test3.bat

test3.bat:

echo Test
pause

There should be no window named "test" at first.

Double click on test1.bat.

Expected Behavior

A window with two tabs showing the "Test" output.

Actual Behavior

Terminal crashes as it attempts to launch the additional tab.

Originally created by @kaetemi on GitHub (Jun 4, 2021). Originally assigned to: @zadjii-msft on GitHub. ### Windows Terminal version (or Windows build number) 1.8.1444 ### Other Software _No response_ ### Steps to reproduce Crash when creating two tabs from within a batch script launched in the same terminal window. Create the following files. test1.bat: ``` wt -w test -d . -p "Command Prompt" test2.bat ``` test2.bat: ``` wt -w test -d . -p "Command Prompt" test3.bat wt -w test -d . -p "Command Prompt" test3.bat ``` test3.bat: ``` echo Test pause ``` There should be no window named "test" at first. Double click on test1.bat. ### Expected Behavior A window with two tabs showing the "Test" output. ### Actual Behavior Terminal crashes as it attempts to launch the additional tab.
claunia added the Issue-BugNeeds-Tag-FixProduct-TerminalPriority-2Area-Remoting labels 2026-01-31 04:01:14 +00:00
claunia commented 2026-01-31 04:01:15 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 7, 2021):

Huh, so what's going on here.

wt.exe is a WINDOWS subsystem application. So when cmd.exe launches that process, it doesn't wait for it to finish to return - it immediately moves on to the next command. So launching test1.bat will spawn a conhost running cmd, and that'll launch wt.exe, then find the end of test1.bat, exit cmd, then conhost will immediately exit.

Now, a first WT is launched, and it runs cmd.exe to process test2.bat. That wt window is named "test". That window now spawns cmd.exe to run test2.bat. Same deal, cmd starts, launches wt.exe, launches wt.exe, then exits. Now here's the tricky part - cmd is faster at running those commands than wt is at starting. So the cmd running in the first WT.exe window exits before either of the other wt.exe's spawn. That results in the first WT.exe exiting immediately, because the child process has exited.

This can be visualized easier by adding a sleep 5 to the end of test2.bat. If you do that, the subsequent tabs will open correctly.

Now we've gotten into a weird edge case - both these subsequent wt.exe's are launching at about the same time. I actually found that it was totally possible for the monarch to assign both these windows the name "test", which is NOT GOOD. That also popped open a post-mortem windbg for me, but that didn't actually end up breaking into anything? I wonder if it was attached to a COM thread that we just ate the exception from and kept going.

I'm gonna re-purpose this issue to tracking down whatever allowed both windows to have the name "test", and preventing that in the future, since this is a great test case.

@ future me: I put these scripts in %~%\bin

@zadjii-msft commented on GitHub (Jul 7, 2021): Huh, so what's going on here. `wt.exe` is a WINDOWS subsystem application. So when `cmd.exe` launches that process, it doesn't wait for it to finish to return - it immediately moves on to the next command. So launching `test1.bat` will spawn a conhost running cmd, and that'll launch wt.exe, then find the end of `test1.bat`, exit `cmd`, then conhost will immediately exit. Now, a first WT is launched, and it runs cmd.exe to process `test2.bat`. That wt window is named "test". That window now spawns cmd.exe to run `test2.bat`. Same deal, `cmd` starts, launches `wt.exe`, launches `wt.exe`, then exits. Now here's the tricky part - cmd is faster at running those commands than `wt` is at starting. So the `cmd` running in the first WT.exe window exits _before_ either of the other `wt.exe`'s spawn. That results in the first WT.exe exiting immediately, because the child process has exited. This can be visualized easier by adding a `sleep 5` to the end of `test2.bat`. If you do that, the subsequent tabs _will_ open correctly. Now we've gotten into a weird edge case - both these subsequent `wt.exe`'s are launching at about the same time. I actually found that it was totally possible for the monarch to assign _both_ these windows the name "test", which is _NOT GOOD_. That also popped open a post-mortem windbg for me, but that didn't actually end up breaking into anything? I wonder if it was attached to a COM thread that we just ate the exception from and kept going. I'm gonna re-purpose this issue to tracking down whatever allowed both windows to have the name "test", and preventing that in the future, since this is a great test case. @ future me: I put these scripts in `%~%\bin`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Remoting Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14110
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?