starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Unclear wording: "Open JSON file" #14149

New Issue
Closed
opened 2026-01-31 04:02:13 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 04:02:13 +00:00
Owner
Copy Link

Originally created by @vadimkantorov on GitHub (Jun 7, 2021).

Originally assigned to: @cinnamon-msft on GitHub.

Windows Terminal version (or Windows build number)

10.0.19041.985

Other Software

No response

Steps to reproduce

Open settings

Expected Behavior

No response

Actual Behavior

Not clear what "Open JSON file" means.

If it said "Open JSON settings file" or "Open settings.json file", it would be much clearer.

I was quite surprised to see a very generic "Open JSON file" function in the settings when I just opened it for the first time

Originally created by @vadimkantorov on GitHub (Jun 7, 2021). Originally assigned to: @cinnamon-msft on GitHub. ### Windows Terminal version (or Windows build number) 10.0.19041.985 ### Other Software _No response_ ### Steps to reproduce Open settings ### Expected Behavior _No response_ ### Actual Behavior Not clear what "Open JSON file" means. If it said "Open JSON settings file" or "Open settings.json file", it would be much clearer. I was quite surprised to see a very generic "Open JSON file" function in the settings when I just opened it for the first time
claunia commented 2026-01-31 04:02:14 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Jun 7, 2021):

I always found it intuitive. The json file clearly mean it was for settings or it wouldn't be presented as an option. If you want something more specific then it would be "Open settings.json".

@WSLUser commented on GitHub (Jun 7, 2021): I always found it intuitive. The json file clearly mean it was for settings or it wouldn't be presented as an option. If you want something more specific then it would be "Open settings.json".
claunia commented 2026-01-31 04:02:14 +00:00
Author
Owner
Copy Link

@vadimkantorov commented on GitHub (Jun 7, 2021):

Yep, "Open settings.json" would be clear that it's talking about precise settings.json, not just some arbitrary-format JSON format.

It also should be clear what "Open settings.json" does. Does it open the current settings.json in a text editor? Or will it show a file dialog for opening pre-saved settings.json (e.g. for import of settings from another machine)?

@vadimkantorov commented on GitHub (Jun 7, 2021): Yep, "Open settings.json" would be clear that it's talking about precise settings.json, not just some arbitrary-format JSON format. It also should be clear what "Open settings.json" does. Does it open the current settings.json in a text editor? Or will it show a file dialog for opening pre-saved settings.json (e.g. for import of settings from another machine)?
claunia commented 2026-01-31 04:02:14 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 7, 2021):

There's limited space. Do you want it to say "Open the settings document, which is actually a JSON file called settings.json, in a text editor, so that you might observe its raw structure?"

@DHowett commented on GitHub (Jun 7, 2021): There's limited space. Do you want it to say "Open the settings document, which is actually a JSON file called settings.json, in a text editor, so that you might observe its raw structure?"
claunia commented 2026-01-31 04:02:14 +00:00
Author
Owner
Copy Link

@vadimkantorov commented on GitHub (Jun 7, 2021):

I want the button text to indicate clearly what it does. Currently it says very generic "Open JSON file"

There are at least two legitimate functions to be expected in this context:

  • open an external user-provided settings.json (file dialog)
  • open a current settings.json (text editor)

I'm sure one can find a concise enough wording much shorter than your proposal, e.g. "Open active settings.json"

But I'm not a native English speaker, so I don't take responsibility for telling actual native speakers what the exact wording should be. I'm sure other people would have better ideas.

@vadimkantorov commented on GitHub (Jun 7, 2021): I want the button text to indicate clearly what it does. Currently it says very generic "Open JSON file" There are at least two legitimate functions to be expected in this context: - open an external user-provided settings.json (file dialog) - open a current settings.json (text editor) I'm sure one can find a concise enough wording much shorter than your proposal, e.g. "Open active settings.json" But I'm not a native English speaker, so I don't take responsibility for telling actual native speakers what the exact wording should be. I'm sure other people would have better ideas.
claunia commented 2026-01-31 04:02:14 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Jun 7, 2021):

open an external user-provided settings.json (file dialog)

In the old days, that one would have a label ending with an ellipsis ("Open JSON file…") because it must ask for more information before it can do what it says. But I don't know if Microsoft has changed its guidelines since then.

@KalleOlaviNiemitalo commented on GitHub (Jun 7, 2021): > open an external user-provided settings.json (file dialog) In the old days, that one would have a label ending with an ellipsis ("Open JSON file…") because it must ask for more information before it can do what it says. But I don't know if Microsoft has changed its guidelines since then.
claunia commented 2026-01-31 04:02:15 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 8, 2021):

After a long discussion with the team, we realized that there's a tooltip that explains what it does. While I agree that the "Open" verb typically means "get external content into my application," we're choosing to accept the tooltip as a disambiguator.

Thanks/sorry!

@DHowett commented on GitHub (Jul 8, 2021): After a long discussion with the team, we realized that there's a tooltip that explains what it does. While I agree that the "Open" verb typically means "get external content into my application," we're choosing to accept the tooltip as a disambiguator. Thanks/sorry!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Question Product-Terminal Resolution-Answered
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14149
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?