starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Saving in the Settings UI breaks "iterateOn" #14166

New Issue
Closed
opened 2026-01-31 04:02:48 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 04:02:48 +00:00
Owner
Copy Link

Originally created by @ffes on GitHub (Jun 8, 2021).

Originally assigned to: @carlos-zamora on GitHub.

Windows Terminal version (or Windows build number)

1.9.1523.0

Other Software

No response

Steps to reproduce

I have written a blogpost on how to add the profiles to the command palette.

When I copy-paste the code mentioned on that page directly in settings.json everything works as expected.

When I open the Settings UI and press save the key iterateOn is deleted, even without changing anything.

For reference, this is a snippet:

{
	"iterateOn": "profiles",
	"icon": "${profile.icon}",
	"name": "${profile.name}: New tab",
	"command": {
		"action": "newTab",
		"profile": "${profile.name}"
	}
}

Expected Behavior

Saving from the Settings UI doesn't remove anything.

Actual Behavior

Saving from the UI removes the iterateOn key-values pair from settings.json.

Originally created by @ffes on GitHub (Jun 8, 2021). Originally assigned to: @carlos-zamora on GitHub. ### Windows Terminal version (or Windows build number) 1.9.1523.0 ### Other Software _No response_ ### Steps to reproduce I have [written a blogpost](https://www.fesevur.com/2021/02/17/windows-terminal-command-palette/) on how to add the profiles to the command palette. When I copy-paste the code mentioned on that page directly in `settings.json` everything works as expected. When I open the Settings UI and press save the key `iterateOn` is deleted, even without changing anything. For reference, this is a snippet: ```json { "iterateOn": "profiles", "icon": "${profile.icon}", "name": "${profile.name}: New tab", "command": { "action": "newTab", "profile": "${profile.name}" } } ``` ### Expected Behavior Saving from the Settings UI doesn't remove anything. ### Actual Behavior Saving from the UI removes the `iterateOn` key-values pair from `settings.json`.
claunia commented 2026-01-31 04:02:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 8, 2021):

/cc @carlos-zamora this will stop us from shipping action serialization out of preview.

@DHowett commented on GitHub (Jun 8, 2021): /cc @carlos-zamora this will stop us from shipping action serialization out of preview.
claunia commented 2026-01-31 04:02:50 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 8, 2021):

(user settings loss bugs are no joke.)

@DHowett commented on GitHub (Jun 8, 2021): (user settings loss bugs are no joke.)
claunia commented 2026-01-31 04:02:50 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 14, 2021):

:tada:This issue was addressed in #10373, which has now been successfully released as Windows Terminal v1.9.1942.0.🎉

Handy links:

@ghost commented on GitHub (Jul 14, 2021): :tada:This issue was addressed in #10373, which has now been successfully released as `Windows Terminal v1.9.1942.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1942.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 04:02:50 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 14, 2021):

:tada:This issue was addressed in #10373, which has now been successfully released as Windows Terminal Preview v1.10.1933.0.🎉

Handy links:

@ghost commented on GitHub (Jul 14, 2021): :tada:This issue was addressed in #10373, which has now been successfully released as `Windows Terminal Preview v1.10.1933.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.10.1933.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Priority-0 Product-Terminal Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14166
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?