starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Pencil icon (Edit button) on Actions page is invisible with light theme #14207

New Issue
Closed
opened 2026-01-31 04:03:47 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 04:03:47 +00:00
Owner
Copy Link

Originally created by @KalleOlaviNiemitalo on GitHub (Jun 11, 2021).

Originally assigned to: @carlos-zamora on GitHub.

Windows Terminal version (or Windows build number)

Windows Terminal Preview 1.9.1445.0 on Windows 10.0.19043.1052

Other Software

N/A

Steps to reproduce

  1. Select the light theme in Windows settings (Personalization, Colors).
  2. Start Windows Terminal Preview.
  3. Open the Settings tab.
  4. Close the session tab. (Only to exclude it from screen shots.)
  5. Select the Actions page of the Settings tab.
  6. Press the Tab key a few times, to select one of the actions listed.

Expected Behavior

Should have a pencil icon at the right side of the description of the key binding.

The pencil icon would show up all right with a dark theme:

image

Actual Behavior

No pencil icon is visible, but if you press Tab once more, the focus rectangle moves to the invisible pencil icon anyway.

image

image

Originally created by @KalleOlaviNiemitalo on GitHub (Jun 11, 2021). Originally assigned to: @carlos-zamora on GitHub. ### Windows Terminal version (or Windows build number) Windows Terminal Preview 1.9.1445.0 on Windows 10.0.19043.1052 ### Other Software N/A ### Steps to reproduce 1. Select the light theme in Windows settings (Personalization, Colors). 2. Start Windows Terminal Preview. 3. Open the Settings tab. 4. Close the session tab. (Only to exclude it from screen shots.) 5. Select the Actions page of the Settings tab. 6. Press the Tab key a few times, to select one of the actions listed. ### Expected Behavior Should have a pencil icon at the right side of the description of the key binding. The pencil icon would show up all right with a dark theme: ![image](https://user-images.githubusercontent.com/46201428/121649597-65b77780-caa1-11eb-99c2-0c635d4aa4ea.png) ### Actual Behavior No pencil icon is visible, but if you press Tab once more, the focus rectangle moves to the invisible pencil icon anyway. ![image](https://user-images.githubusercontent.com/46201428/121649232-0bb6b200-caa1-11eb-94c0-425f5abef94c.png) ![image](https://user-images.githubusercontent.com/46201428/121649267-16714700-caa1-11eb-90a6-5e1dd4b2ea65.png)
claunia commented 2026-01-31 04:03:49 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Jun 11, 2021):

This belongs to the https://github.com/microsoft/terminal/issues/6900 epic.

The pencil icon is likewise invisible when the mouse pointer hovers on an action while using a light theme.

@KalleOlaviNiemitalo commented on GitHub (Jun 11, 2021): This belongs to the <https://github.com/microsoft/terminal/issues/6900> epic. The pencil icon is likewise invisible when the mouse pointer hovers on an action while using a light theme.
claunia commented 2026-01-31 04:03:49 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Jun 11, 2021):

I guess it is caused by the white foreground color here: https://github.com/microsoft/terminal/blob/227ec3777a216613c3796991d9bc01db6d184d24/src/cascadia/TerminalSettingsEditor/Actions.xaml#L243-L250

@KalleOlaviNiemitalo commented on GitHub (Jun 11, 2021): I guess it is caused by the white foreground color here: <https://github.com/microsoft/terminal/blob/227ec3777a216613c3796991d9bc01db6d184d24/src/cascadia/TerminalSettingsEditor/Actions.xaml#L243-L250>
claunia commented 2026-01-31 04:03:49 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Jun 11, 2021):

Should be using Theme Resources so the colour changes as the theme does

@mdtauk commented on GitHub (Jun 11, 2021): Should be using Theme Resources so the colour changes as the theme does
claunia commented 2026-01-31 04:03:49 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Jun 11, 2021):

@mdtauk, when I first noticed the invisible icon, I had been using the light theme for several days (perhaps weeks) and even restarted Windows for the June security updates. That makes this bug different from https://github.com/microsoft/terminal/issues/1230.

@KalleOlaviNiemitalo commented on GitHub (Jun 11, 2021): @mdtauk, when I first noticed the invisible icon, I had been using the light theme for several days (perhaps weeks) and even restarted Windows for the June security updates. That makes this bug different from <https://github.com/microsoft/terminal/issues/1230>.
claunia commented 2026-01-31 04:03:49 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Jun 11, 2021):

I wonder if this is an issue about the buttons which appear on hover, not appearing when the control is focused

@mdtauk commented on GitHub (Jun 11, 2021): I wonder if this is an issue about the buttons which appear on hover, not appearing when the control is **focused**
claunia commented 2026-01-31 04:03:50 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Jun 11, 2021):

@mdtauk, in that case, the bug would occur with the dark theme as well. It doesn't.

@KalleOlaviNiemitalo commented on GitHub (Jun 11, 2021): @mdtauk, in that case, the bug would occur with the dark theme as well. It doesn't.
claunia commented 2026-01-31 04:03:50 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 11, 2021):

/cc @carlos-zamora

I wonder if this is an issue about the buttons which appear on hover, not appearing when the control is focused

They certainly should appear when the control is focused 😄

@DHowett commented on GitHub (Jun 11, 2021): /cc @carlos-zamora > I wonder if this is an issue about the buttons which appear on hover, not appearing when the control is **focused** They certainly should appear when the control is focused :smile:
claunia commented 2026-01-31 04:03:50 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 14, 2021):

:tada:This issue was addressed in #10412, which has now been successfully released as Windows Terminal v1.9.1942.0.🎉

Handy links:

@ghost commented on GitHub (Jul 14, 2021): :tada:This issue was addressed in #10412, which has now been successfully released as `Windows Terminal v1.9.1942.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1942.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 04:03:50 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 14, 2021):

:tada:This issue was addressed in #10412, which has now been successfully released as Windows Terminal Preview v1.10.1933.0.🎉

Handy links:

@ghost commented on GitHub (Jul 14, 2021): :tada:This issue was addressed in #10412, which has now been successfully released as `Windows Terminal Preview v1.10.1933.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.10.1933.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Bug Needs-Triage Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14207
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?