starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Move delete button theme resources into CommonResources.xaml #14258

New Issue
Closed
opened 2026-01-31 04:05:16 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 04:05:16 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Jun 18, 2021).

There's a few places in the Settings UI where we have a "delete button":

We should move these over to CommonResources.xaml.

Examples of what this would look like:

If we have any other theme resources that we use in a few places, we should do the same. I'm also open to the idea of having a separate file named something like CommonThemeResources.xaml if we wanted to take that route.

Originally created by @carlos-zamora on GitHub (Jun 18, 2021). There's a few places in the Settings UI where we have a "delete button": - [Actions Page](https://github.com/microsoft/terminal/blob/b6593216f2f10c6e2b9922c22bcd22e4618020c5/src/cascadia/TerminalSettingsEditor/Actions.xaml#L317-L364) - [Color Schemes Page](https://github.com/microsoft/terminal/blob/b6593216f2f10c6e2b9922c22bcd22e4618020c5/src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml#L290-L337) - [Profiles Page - Delete Profile](https://github.com/microsoft/terminal/blob/b6593216f2f10c6e2b9922c22bcd22e4618020c5/src/cascadia/TerminalSettingsEditor/Profiles.xaml#L161-L208) - (PR #10317) Profiles Page - Delete Appearance: (just look up "Firebrick") We should move these over to [CommonResources.xaml](https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsEditor/CommonResources.xaml). Examples of what this would look like: - https://github.com/microsoft/terminal/blob/b6593216f2f10c6e2b9922c22bcd22e4618020c5/src/cascadia/TerminalSettingsEditor/CommonResources.xaml#L14-L32 - https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/Common_themeresources.xaml If we have any other theme resources that we use in a few places, we should do the same. I'm also open to the idea of having a separate file named something like `CommonThemeResources.xaml` if we wanted to take that route.
claunia commented 2026-01-31 04:05:18 +00:00
Author
Owner
Copy Link

@sourabh112 commented on GitHub (Aug 24, 2021):

Hi @miniksa @carlos-zamora, Can I work on this issue? As I'm quite new to open-source, I might need your guidance.

@sourabh112 commented on GitHub (Aug 24, 2021): Hi @miniksa @carlos-zamora, Can I work on this issue? As I'm quite new to open-source, I might need your guidance.
claunia commented 2026-01-31 04:05:18 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 24, 2021):

@sourabh112 Go right ahead!

@zadjii-msft commented on GitHub (Aug 24, 2021): @sourabh112 Go right ahead!
claunia commented 2026-01-31 04:05:18 +00:00
Author
Owner
Copy Link

@sourabh112 commented on GitHub (Aug 25, 2021):

Thanks @zadjii-msft , for the opportunity and sorry for late reply. I'm starting with making myself familiar with the code, so that my changes won't affect anything else.

@sourabh112 commented on GitHub (Aug 25, 2021): Thanks @zadjii-msft , for the opportunity and sorry for late reply. I'm starting with making myself familiar with the code, so that my changes won't affect anything else.
claunia commented 2026-01-31 04:05:18 +00:00
Author
Owner
Copy Link

@jelonmusk commented on GitHub (Aug 31, 2021):

Hi
@miniksa @carlos-zamora, I would also like to work on this issue.
p.s. I'm a first-time contributor!

@jelonmusk commented on GitHub (Aug 31, 2021): Hi @miniksa @carlos-zamora, I would also like to work on this issue. p.s. I'm a first-time contributor!
claunia commented 2026-01-31 04:05:19 +00:00
Author
Owner
Copy Link

@jelonmusk commented on GitHub (Aug 31, 2021):

https://github.com/jelonmusk/terminal/blob/main/src/cascadia/TerminalSettingsEditor/CommonResources.xaml

Here's the link to changes made in CommonResource.xaml file.
@miniksa Could you please review it?

@jelonmusk commented on GitHub (Aug 31, 2021): https://github.com/jelonmusk/terminal/blob/main/src/cascadia/TerminalSettingsEditor/CommonResources.xaml Here's the link to changes made in CommonResource.xaml file. @miniksa Could you please review it?
claunia commented 2026-01-31 04:05:19 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Sep 1, 2021):

I will look at the PR.

@miniksa commented on GitHub (Sep 1, 2021): I will look at the PR.
claunia commented 2026-01-31 04:05:19 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 24, 2022):

:tada:This issue was addressed in #12973, which has now been successfully released as Windows Terminal v1.13.1143.🎉

Handy links:

@ghost commented on GitHub (May 24, 2022): :tada:This issue was addressed in #12973, which has now been successfully released as `Windows Terminal v1.13.1143`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.13.1143) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 04:05:20 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 24, 2022):

:tada:This issue was addressed in #12973, which has now been successfully released as Windows Terminal Preview v1.14.143.🎉

Handy links:

@ghost commented on GitHub (May 24, 2022): :tada:This issue was addressed in #12973, which has now been successfully released as `Windows Terminal Preview v1.14.143`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.14.143) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth good first issue Help Wanted Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14258
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?