starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

OpenConsole.psm1 -- Set-MsbuildDevEnvironment doesn't check for the existence of VS140COMNTOOLS #1427

New Issue
Closed
opened 2026-01-30 22:26:50 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:26:50 +00:00
Owner
Copy Link

Originally created by @strega-nil on GitHub (May 30, 2019).

Environment

...
VCIDEInstallDir                C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\IDE\VC\
VCINSTALLDIR                   C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\
VCToolsInstallDir              C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.20.27508\
VCToolsRedistDir               C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Redist\MSVC\14.20.27508\
VCToolsVersion                 14.20.27508
VisualStudioVersion            16.0
VS160COMNTOOLS                 C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\Tools\
VSCMD_ARG_app_plat             Desktop
VSCMD_ARG_HOST_ARCH            x64
VSCMD_ARG_TGT_ARCH             x64
VSCMD_VER                      16.0
VSINSTALLDIR                   C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\
...

Microsoft Windows [Version 10.0.18362.145]
pscore-6

Steps to reproduce

Don't install version 14x of MSVC when you're installing VS 2019, then follow the build instructions.

Expected behavior

Find MSVC 160, compile using that version; or, give an error and tell the user to install a version of MSVC which is compatible with terminal.

Actual behavior

PS C:\Users\npmaz\src\misc\terminal> Set-MsbuildDevEnvironment
pushd : The path 'C:\..\..' referred to an item that was outside the base 'C:'.
At C:\Users\npmaz\src\misc\terminal\tools\OpenConsole.psm1:11 char:5
+     pushd $path
+     ~~~~~~~~~~~
+ CategoryInfo          : InvalidArgument: (:) [Push-Location], PSArgumentException
+ FullyQualifiedErrorId : System.Management.Automation.PSArgumentException,Microsoft.PowerShell.Commands.PushLocationCommand

pushd : The path 'C:\..\..' referred to an item that was outside the base 'C:'.
At C:\Users\npmaz\src\misc\terminal\tools\OpenConsole.psm1:11 char:5
+     pushd $path
+     ~~~~~~~~~~~
+ CategoryInfo          : InvalidArgument: (:) [Push-Location], PSArgumentException
+ FullyQualifiedErrorId : System.Management.Automation.PSArgumentException,Microsoft.PowerShell.Commands.PushLocationCommand

'vcvarsall.bat' is not recognized as an internal or external command,
operable program or batch file.
Dev environment variables set

Note that no errors happen.

Originally created by @strega-nil on GitHub (May 30, 2019). <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none ... VCIDEInstallDir C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\IDE\VC\ VCINSTALLDIR C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\ VCToolsInstallDir C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.20.27508\ VCToolsRedistDir C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Redist\MSVC\14.20.27508\ VCToolsVersion 14.20.27508 VisualStudioVersion 16.0 VS160COMNTOOLS C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\Tools\ VSCMD_ARG_app_plat Desktop VSCMD_ARG_HOST_ARCH x64 VSCMD_ARG_TGT_ARCH x64 VSCMD_VER 16.0 VSINSTALLDIR C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\ ... Microsoft Windows [Version 10.0.18362.145] pscore-6 ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> Don't install version 14x of MSVC when you're installing VS 2019, then follow the build instructions. # Expected behavior Find MSVC 160, compile using that version; or, give an error and tell the user to install a version of MSVC which is compatible with terminal. <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior ``` PS C:\Users\npmaz\src\misc\terminal> Set-MsbuildDevEnvironment pushd : The path 'C:\..\..' referred to an item that was outside the base 'C:'. At C:\Users\npmaz\src\misc\terminal\tools\OpenConsole.psm1:11 char:5 + pushd $path + ~~~~~~~~~~~ + CategoryInfo : InvalidArgument: (:) [Push-Location], PSArgumentException + FullyQualifiedErrorId : System.Management.Automation.PSArgumentException,Microsoft.PowerShell.Commands.PushLocationCommand pushd : The path 'C:\..\..' referred to an item that was outside the base 'C:'. At C:\Users\npmaz\src\misc\terminal\tools\OpenConsole.psm1:11 char:5 + pushd $path + ~~~~~~~~~~~ + CategoryInfo : InvalidArgument: (:) [Push-Location], PSArgumentException + FullyQualifiedErrorId : System.Management.Automation.PSArgumentException,Microsoft.PowerShell.Commands.PushLocationCommand 'vcvarsall.bat' is not recognized as an internal or external command, operable program or batch file. Dev environment variables set ``` Note that no errors happen. <!-- What's actually happening? -->
claunia commented 2026-01-30 22:26:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 30, 2019):

@adiviness who owns these scripts

@zadjii-msft commented on GitHub (May 30, 2019): @adiviness who owns these scripts
claunia commented 2026-01-30 22:26:52 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 30, 2019):

Moving to #930

@DHowett-MSFT commented on GitHub (May 30, 2019): Moving to #930
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Issue-Question Needs-Triage Product-Meta Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1427
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?