starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Settings Page Animation Restarts When Switching To Settings Tab #14489

New Issue
Closed
opened 2026-01-31 04:11:39 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 04:11:39 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Jul 12, 2021).

When you have a setting tab already open and switch back and forth between the Settings tab and any other tab, the animation of the page (where the page content appears vertically centered and moves upward - which is a bit of an odd animation itself) will restart again, even though this isn't the first time opening the page.

It might have been intended, but I find it a little.... odd.

Proposed technical implementation details (optional)

A different animation might make this appear less odd. Like fade, or any number of animations.

https://user-images.githubusercontent.com/4098042/125307353-9a635c80-e2f5-11eb-896f-d39a75b7345c.mp4

Originally created by @ghost on GitHub (Jul 12, 2021). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> When you have a setting tab already open and switch back and forth between the Settings tab and any other tab, the animation of the page (where the page content appears vertically centered and moves upward - which is a bit of an odd animation itself) will restart again, even though this isn't the first time opening the page. It might have been intended, but I find it a little.... odd. <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) A different animation might make this appear less odd. Like fade, or any number of animations. <!-- A clear and concise description of what you want to happen. --> https://user-images.githubusercontent.com/4098042/125307353-9a635c80-e2f5-11eb-896f-d39a75b7345c.mp4
claunia commented 2026-01-31 04:11:40 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 12, 2021):

I wonder if this is because of us doing a Navigate to the root content view when the settings page comes visible. Perhaps there's something we can do to bind the root content such that it doesn't animate at all on first / subsequent launches. @carlos-zamora this might be related to the view model stuff we were talking about (since doing the navigation in the "code behind" versus as an intrinsic part of the page state may be to blame).

@DHowett commented on GitHub (Jul 12, 2021): I wonder if this is because of us doing a `Navigate` to the root content view when the settings page comes visible. Perhaps there's something we can do to bind the root content such that it doesn't animate at all on first / subsequent launches. @carlos-zamora this might be related to the view model stuff we were talking about (since doing the navigation in the "code behind" versus as an intrinsic part of the page state may be to blame).
claunia commented 2026-01-31 04:11:40 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 12, 2021):

(Thanks for filing this!)

@DHowett commented on GitHub (Jul 12, 2021): (Thanks for filing this!)
claunia commented 2026-01-31 04:11:40 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jul 12, 2021):

I wonder if this is because of us doing a Navigate to the root content view when the settings page comes visible. Perhaps there's something we can do to bind the root content such that it doesn't animate at all on first / subsequent launches. @carlos-zamora this might be related to the view model stuff we were talking about (since doing the navigation in the "code behind" versus as an intrinsic part of the page state may be to blame).

I did a trace because I was curious. Looks something like this:

  • TerminalPage::_OpenSettingsUI(): select the settings tab and update content
  • MainPage::SettingsNav_Loaded():
    • if (SettingsNav().SelectedItem() == nullptr) --> false
    • nothing happens. Surprisingly, _Navigate() is not called!

So yeah, looks like XAML is just doing it for us.

Playing with the XAML controls gallery, I agree that perhaps a DrillIn or Suppress may work best. Definitely odd!

@carlos-zamora commented on GitHub (Jul 12, 2021): > I wonder if this is because of us doing a `Navigate` to the root content view when the settings page comes visible. Perhaps there's something we can do to bind the root content such that it doesn't animate at all on first / subsequent launches. @carlos-zamora this might be related to the view model stuff we were talking about (since doing the navigation in the "code behind" versus as an intrinsic part of the page state may be to blame). I did a trace because I was curious. Looks something like this: - `TerminalPage::_OpenSettingsUI()`: select the settings tab and update content - `MainPage::SettingsNav_Loaded()`: - `if (SettingsNav().SelectedItem() == nullptr)` --> `false` - _nothing happens_. Surprisingly, `_Navigate()` is not called! So yeah, looks like XAML is just doing it for us. Playing with the XAML controls gallery, I agree that perhaps a [DrillIn](https://docs.microsoft.com/en-us/windows/apps/design/motion/page-transitions#drill) or [Suppress](https://docs.microsoft.com/en-us/windows/apps/design/motion/page-transitions#suppress) may work best. Definitely odd!
claunia commented 2026-01-31 04:11:40 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Aug 12, 2021):

@carlos-zamora - do you have a preference between Drill in or Surpress? 😊

@Don-Vito commented on GitHub (Aug 12, 2021): @carlos-zamora - do you have a preference between Drill in or Surpress? :blush:
claunia commented 2026-01-31 04:11:41 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Aug 12, 2021):

@carlos-zamora - do you have a preference between Drill in or Surpress? 😊

Let's try DrillIn!

@carlos-zamora commented on GitHub (Aug 12, 2021): > @carlos-zamora - do you have a preference between Drill in or Surpress? 😊 Let's try DrillIn!
claunia commented 2026-01-31 04:11:41 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Aug 12, 2021):

DrillIn

@Don-Vito commented on GitHub (Aug 12, 2021): ![DrillIn](https://user-images.githubusercontent.com/4639110/129257459-d9d868ba-541c-4809-adf8-c1a7ae116552.gif)
claunia commented 2026-01-31 04:11:41 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Aug 12, 2021):

@carlos-zamora - WDYT?

@Don-Vito commented on GitHub (Aug 12, 2021): @carlos-zamora - WDYT?
claunia commented 2026-01-31 04:11:41 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Aug 12, 2021):

OK. Committing :)

@Don-Vito commented on GitHub (Aug 12, 2021): OK. Committing :)
claunia commented 2026-01-31 04:11:41 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 31, 2021):

:tada:This issue was addressed in #10934, which has now been successfully released as Windows Terminal Preview v1.10.2383.0.🎉

Handy links:

@ghost commented on GitHub (Aug 31, 2021): :tada:This issue was addressed in #10934, which has now been successfully released as `Windows Terminal Preview v1.10.2383.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.10.2383.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 04:11:41 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 31, 2021):

:tada:This issue was addressed in #10934, which has now been successfully released as Windows Terminal Preview v1.11.2421.0.🎉

Handy links:

@ghost commented on GitHub (Aug 31, 2021): :tada:This issue was addressed in #10934, which has now been successfully released as `Windows Terminal Preview v1.11.2421.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.11.2421.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Help Wanted Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14489
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?