Settings sometimes don't load when rapidly clicking save #14555

Closed
opened 2026-01-31 04:13:31 +00:00 by claunia · 2 comments
Owner

Originally created by @mimvdb on GitHub (Jul 16, 2021).

Windows Terminal version (or Windows build number)

1.8.1521.0

Other Software

No response

Steps to reproduce

Rapidly click on save in the settings menu.

Discovered while reporting a memory leak issue #10609, at 13 seconds in the video below you can see this issue.

https://user-images.githubusercontent.com/2277504/125179830-a31f3a00-e1f2-11eb-8b6f-6f6aa07896c5.mp4

Expected Behavior

Settings stay the same

Actual Behavior

Settings fail to load (possibly already corrupted or overriding on next save? not sure)

Originally created by @mimvdb on GitHub (Jul 16, 2021). ### Windows Terminal version (or Windows build number) 1.8.1521.0 ### Other Software _No response_ ### Steps to reproduce Rapidly click on save in the settings menu. Discovered while reporting a memory leak issue #10609, at 13 seconds in the video below you can see this issue. https://user-images.githubusercontent.com/2277504/125179830-a31f3a00-e1f2-11eb-8b6f-6f6aa07896c5.mp4 ### Expected Behavior Settings stay the same ### Actual Behavior Settings fail to load (possibly already corrupted or overriding on next save? not sure)
Author
Owner

@zadjii-msft commented on GitHub (Feb 2, 2022):

I can't get this warning to happen anymore on Terminal 1.13. I suspect it was fixed by some locking changes to how we write the settings file, which I think landed even before 1.12. Slamming on the Save button quickly seems to hang for a second, I bet we're saving on the UI thread. But we're definitely not accidentally failing to load the settings file anymore.

@mimvdb can you confirm you aren't seeing this anymore?

@zadjii-msft commented on GitHub (Feb 2, 2022): I can't get this warning to happen anymore on Terminal 1.13. I suspect it was fixed by some locking changes to how we write the settings file, which I think landed even before 1.12. Slamming on the Save button quickly seems to hang for a second, I bet we're saving on the UI thread. But we're definitely not accidentally failing to load the settings file anymore. @mimvdb can you confirm you aren't seeing this anymore?
Author
Owner

@mimvdb commented on GitHub (Feb 2, 2022):

Indeed cannot reproduce (only saw it the one time, it might be dependent on moon alignment), I did find this while trying #12333

EDIT: Now that I think about it, I think I could reproduce this before, so this can be closed now

@mimvdb commented on GitHub (Feb 2, 2022): Indeed cannot reproduce ~~(only saw it the one time, it might be dependent on moon alignment)~~, I did find this while trying #12333 EDIT: Now that I think about it, I think I could reproduce this before, so this can be closed now
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14555