starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Print Dialog Shown Off Screen #14559

New Issue
Closed
opened 2026-01-31 04:13:35 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 04:13:35 +00:00
Owner
Copy Link

Originally created by @juvtib on GitHub (Jul 17, 2021).

Windows Terminal version (or Windows build number)

Windows Terminal Version: 1.9.1942.0

Other Software

vim 8.2 outside WSL

Steps to reproduce

  1. Install Windows Terminal 1.9 and Vim 8.2 on a new Windows 10 box.
  2. Execute "C:\Program Files (x86)\Vim\vim82\vim.exe"
  3. Print via :hardcopy

Expected Behavior

I expect the print dialog to be centered on the screen or on the shell like console host.

Actual Behavior

The print dialog is positioned past the top-left of the screen.

To bring the dialog into view:

  1. Click to focus on the dialog.
  2. Press Alt + Space
  3. Press m
  4. Press Up Arrow to attach the dialog to the mouse cursor.
  5. Move the mouse cursor to drag the dialog into view.
Originally created by @juvtib on GitHub (Jul 17, 2021). ### Windows Terminal version (or Windows build number) Windows Terminal Version: 1.9.1942.0 ### Other Software vim 8.2 outside WSL ### Steps to reproduce 1. Install Windows Terminal 1.9 and Vim 8.2 on a new Windows 10 box. 1. Execute `"C:\Program Files (x86)\Vim\vim82\vim.exe"` 2. Print via `:hardcopy` ### Expected Behavior I expect the print dialog to be centered on the screen or on the shell like console host. ### Actual Behavior The print dialog is positioned past the top-left of the screen. To bring the dialog into view: 1. Click to focus on the dialog. 2. Press Alt + Space 3. Press m 4. Press Up Arrow to attach the dialog to the mouse cursor. 5. Move the mouse cursor to drag the dialog into view.
claunia added the Resolution-ExternalNeeds-Tag-Fix labels 2026-01-31 04:13:35 +00:00
claunia commented 2026-01-31 04:13:36 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 19, 2021):

I'm gonna guess that this is /dup #2988. This just has all the same hallmarks of that bug.

@zadjii-msft commented on GitHub (Jul 19, 2021): I'm gonna guess that this is /dup #2988. This just has all the same hallmarks of that bug.
claunia commented 2026-01-31 04:13:37 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 19, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Jul 19, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 04:13:37 +00:00
Author
Owner
Copy Link

@juvtib commented on GitHub (Jul 20, 2021):

I don't think this is a duplicate. I'm talking about x,y not z. When I type start . I don't have the same problem as reported in 2988. My issue reproduces today.

@juvtib commented on GitHub (Jul 20, 2021): I don't think this is a duplicate. I'm talking about x,y not z. When I type `start .` I don't have the same problem as reported in 2988. My issue reproduces today.
claunia commented 2026-01-31 04:13:37 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 20, 2021):

Okay yea, I see how that was confusing. Lemme try to explain better:

I'm guessing the root cause of your issue here is that vim can't reliably find the HWND of the Terminal. It probably wants to display the print dialog relative to the window that it's running in. I'm guessing that they use GetConsoleWindow for that value. However, when running in the Terminal, that value is a garbage value. So instead of it opening near the Terminal, it just defaults to (some location).

The start . repro for #2988 is intermittent, but shares the same root cause.

@zadjii-msft commented on GitHub (Jul 20, 2021): Okay yea, I see how that was confusing. Lemme try to explain better: I'm guessing the root cause of your issue here is that `vim` can't reliably find the HWND of the Terminal. It probably wants to display the print dialog relative to the window that it's running in. I'm guessing that they use `GetConsoleWindow` for that value. However, when running in the Terminal, that value is a garbage value. So instead of it opening near the Terminal, it just defaults to (some location). The `start .` repro for #2988 is intermittent, but shares the same root cause.
claunia commented 2026-01-31 04:13:37 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 18, 2022):

Okay, even after investigating down all the other leads in #2988, :hardcopy is still busted. I'm quite confident that vim.exe is getting the actual position of the console window here to try and center the print dialog on top of it. Problem is, GetConsoleWindow in any ConPTY session (read: terminal) is going to have a 0x0 sized window as the result of that API.

This is gonna require some changes on the part of vim.exe. They'll need to do some combo of

  • maybe use GetAncestor() to try and find the Terminal's HWND as a ROOTOWNER of the console HWND
  • Before 1.14, detect that the HWND that's returned is totally transparent (WS_TRANSPARENT), or 0x0 and then just display the print dialog in the center of the screen

So this is no longer a duplicate issue, it's actually something we can't solve. Sorry!

@zadjii-msft commented on GitHub (May 18, 2022): Okay, even after investigating down all the other leads in #2988, `:hardcopy` is still busted. I'm quite confident that `vim.exe` is getting the actual position of the console window here to try and center the print dialog on top of it. Problem is, `GetConsoleWindow` in any ConPTY session (read: terminal) is going to have a 0x0 sized window as the result of that API. This is gonna require some changes on the part of `vim.exe`. They'll need to do some combo of * maybe use GetAncestor() to try and find the Terminal's HWND as a ROOTOWNER of the console HWND * Before 1.14, detect that the HWND that's returned is totally transparent (WS_TRANSPARENT), or 0x0 and then just display the print dialog in the center of the screen So this is no longer a duplicate issue, it's actually something we can't solve. Sorry!
claunia commented 2026-01-31 04:13:37 +00:00
Author
Owner
Copy Link

@juvtib commented on GitHub (May 19, 2022):

Thanks for checking into this.

@juvtib commented on GitHub (May 19, 2022): Thanks for checking into this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Resolution-External
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14559
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?