starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

URL detection: False positive for links where port number contains non-numeric characters #14574

New Issue
Closed
opened 2026-01-31 04:13:56 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 04:13:56 +00:00
Owner
Copy Link

Originally created by @Sominemo on GitHub (Jul 18, 2021).

Windows Terminal version (or Windows build number)

1.9.1942.0

Other Software

No response

Steps to reproduce

  1. Make a terminal display a described link, for example https://example.com:test
  2. Hover on link

Expected Behavior

Only the https://example.com part is being underlined, since it's correct

Actual Behavior

The whole https://example.com:test is being underlined, despite it being a non-valid URL.
image

Originally created by @Sominemo on GitHub (Jul 18, 2021). ### Windows Terminal version (or Windows build number) 1.9.1942.0 ### Other Software _No response_ ### Steps to reproduce 1. Make a terminal display a described link, for example `https://example.com:test` 2. Hover on link ### Expected Behavior Only the `https://example.com` part is being underlined, since it's correct ### Actual Behavior The whole `https://example.com:test` is being underlined, despite it being a non-valid URL. ![image](https://user-images.githubusercontent.com/19842935/126072922-fd36fe97-0b89-4e4d-b99b-9802c48226ce.png)
claunia added the Resolution-Duplicate label 2026-01-31 04:13:56 +00:00
claunia commented 2026-01-31 04:13:57 +00:00
Author
Owner
Copy Link

@orcmid commented on GitHub (Jul 19, 2021):

Steps to reproduce

  1. Make a terminal display a described link, for example https://example.com:test
  2. Hover on link

Expected Behavior

Only the https://example.com part is being underlined, since it's correct

I doubted that Terminal was the source of this until I reproduced it and I could not get it with cmd.exe outside of Terminal. The on-hover "press ctrl-click" to follow the URL does end up with a response that the underlined text is not of a valid URL.

With regard to the underlining of a URL detection, there are conventions for unambiguosly delimiting URLs in texts and these are covered in the IETF specifications. This is demonstrated with <https://example.com>:test although ( ... ) is doubtless preferable, just as in Markdown. It will also be necessary to %-encode spaces and some other characters that might appear in the intended URL.

I suggest that we not expect Terminal to do much about detecting something that might be intended to be followable or not. You can tell from the hover-underline whether it got all, too little, or too much of an intended one. That additional checking occurs only on attempting to use it makes the most sense to me. (I can't imagine how this works with respect to accessibility though.)

@orcmid commented on GitHub (Jul 19, 2021): > ### Steps to reproduce > 1. Make a terminal display a described link, for example `https://example.com:test` > 2. Hover on link > > ### Expected Behavior > Only the `https://example.com` part is being underlined, since it's correct I doubted that Terminal was the source of this until I reproduced it and I could not get it with cmd.exe outside of Terminal. The on-hover "press ctrl-click" to follow the URL does end up with a response that the underlined text is not of a valid URL. With regard to the underlining of a URL detection, there are conventions for unambiguosly delimiting URLs in texts and these are covered in the IETF specifications. This is demonstrated with `<https://example.com>:test` although `( ... )` is doubtless preferable, just as in Markdown. It will also be necessary to %-encode spaces and some other characters that might appear in the intended URL. I suggest that we not expect Terminal to do much about detecting something that might be intended to be followable or not. You can tell from the hover-underline whether it got all, too little, or too much of an intended one. That additional checking occurs only on attempting to use it makes the most sense to me. (I can't imagine how this works with respect to accessibility though.)
claunia commented 2026-01-31 04:13:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 19, 2021):

The regex we're currently using is here:
f68324cd09/src/cascadia/TerminalCore/Terminal.hpp (L23)

We've got more discussion over in #8321, so I'm gonna redirect this thread there

/dup #8321

@zadjii-msft commented on GitHub (Jul 19, 2021): The regex we're currently using is here: https://github.com/microsoft/terminal/blob/f68324cd099f2d76321f1889f8de504e67a7c797/src/cascadia/TerminalCore/Terminal.hpp#L23 We've got more discussion over in #8321, so I'm gonna redirect this thread there /dup #8321
claunia commented 2026-01-31 04:13:58 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 19, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Jul 19, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14574
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?