starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add mouse navigation button support for actions #14697

New Issue
Open
opened 2026-01-31 04:17:11 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 04:17:11 +00:00
Owner
Copy Link

Originally created by @FWest98 on GitHub (Jul 27, 2021).

Description of the new feature/enhancement

Follow-up on #10801: the added browser_back and _forward keys are the keyboard keys, not the mouse buttons. It might be nice to add support for these buttons as well, usually they are VK_XBUTTON1 and VK_XBUTTON2.

Proposed technical implementation details (optional)

The implementation will be a bit more complicated than just adding the key definitions, as now the mouse handlers should also check for keychord bindings. My proposal would be to add this to TermControl::_PointerPressedHandler. This would limit the support to when hovering the terminal control, so that might not be ideal. I am not sure what is actually desirable here.

Things to consider:

  • Add support for "just" XBUTTON1/2, or also for other buttons?
  • What should the textual representation of these buttons be? Make them coincide with browser_back and _forward, or separate names mouse_back and _forward?
  • How do mouses with more macro buttons operate?
Originally created by @FWest98 on GitHub (Jul 27, 2021). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement Follow-up on #10801: the added `browser_back` and `_forward` keys are the keyboard keys, not the mouse buttons. It might be nice to add support for these buttons as well, usually they are `VK_XBUTTON1` and `VK_XBUTTON2`. # Proposed technical implementation details (optional) The implementation will be a bit more complicated than just adding the key definitions, as now the mouse handlers should also check for keychord bindings. My proposal would be to add this to `TermControl::_PointerPressedHandler`. This would limit the support to when hovering the terminal control, so that might not be ideal. I am not sure what is actually desirable here. Things to consider: - Add support for "just" XBUTTON1/2, or also for other buttons? - What should the textual representation of these buttons be? Make them coincide with `browser_back` and `_forward`, or separate names `mouse_back` and `_forward`? - How do mouses with more macro buttons operate?
claunia added the Issue-TaskProduct-TerminalArea-TerminalControl labels 2026-01-31 04:17:11 +00:00
claunia commented 2026-01-31 04:17:11 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 5, 2021):

Team decision: We're cool with these being allowed as keys in actions _if they come through as keys in PreviewKeyDown, where keybindings are processed. In 1.11, we thought you might just be able to get away with vk(5) (for VK_XBUTTON1 for example).

However, our cursory investigation makes us think that these don't come through as keys. This might be better off being dealt with by #1553. Probably as a sub-task of the bigger feature over there.

Thanks!

@zadjii-msft commented on GitHub (Aug 5, 2021): Team decision: We're cool with these being allowed as `keys` in actions _if they come through as keys in `PreviewKeyDown`, where keybindings are processed. In 1.11, we thought you might just be able to get away with `vk(5)` (for `VK_XBUTTON1` for example). However, our cursory investigation makes us think that these _don't_ come through as _keys_. This might be better off being dealt with by #1553. Probably as a sub-task of the bigger feature over there. Thanks!
claunia commented 2026-01-31 04:17:12 +00:00
Author
Owner
Copy Link

@FWest98 commented on GitHub (Aug 5, 2021):

I tried myself by adding these VK_XBUTTON1 entries, but those are not registered through any KeyDown or similar methods. I think it would be much neater to combine it with the issue you linked indeed.

@FWest98 commented on GitHub (Aug 5, 2021): I tried myself by adding these `VK_XBUTTON1` entries, but those are not registered through any KeyDown or similar methods. I think it would be much neater to combine it with the issue you linked indeed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14697
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?