starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

We log entirely too frequently from Terminal::CursorLineFeed #14803

New Issue
Closed
opened 2026-01-31 04:19:56 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 04:19:56 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Aug 5, 2021).

This is a follow-up for an internal bug. There's two pieces here:

  • (A) Change the CATCH_LOG_RETURN_FALSE to a newly authored CATCH_LOG_RETURN_FALSE_EXPECTED. We're expecting this exception, so make it less noisy. This will fix MSFT:33310649
  • (B) Get to the bottom of why Terminal::CursorLineFeed is throwing so often. It's an E_ABORT from rectangle.h:840, though that line of code is nothing in main, so we might need to look at what it is in 1.9. Presumably something in _AdjustCursorPosition throws, though impossible to say what exactly.
Originally created by @zadjii-msft on GitHub (Aug 5, 2021). This is a follow-up for an internal bug. There's two pieces here: * [x] (**A**) Change the `CATCH_LOG_RETURN_FALSE` to a newly authored `CATCH_LOG_RETURN_FALSE_EXPECTED`. We're expecting this exception, so make it less noisy. This will fix MSFT:33310649 - Done in #10901 * [ ] (**B**) Get to the bottom of why `Terminal::CursorLineFeed` is throwing so often. It's an `E_ABORT` from `rectangle.h:840`, though that line of code is nothing in main, so we might need to look at what it is in 1.9. Presumably something in `_AdjustCursorPosition` throws, though impossible to say what exactly.
claunia commented 2026-01-31 04:19:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 9, 2021):

Huh well, I slapped a DebugBreak() in the exception handler in Terminal::CursorLineFeed and tried printing 1000000000 lines of text to see if that triggers the exception. No luck.

Tried with a 9000001 size buffer (which would be clamped to SHORT_MAX) - no luck.

Tried with cmatrix - again, no luck.

Resizing wildly also didn't seem to trigger the debugbreak. So I'm a little lost as to what would cause this one. Someone would actually need to find where we're doing the til::rectangle math in that function and track it down, but with the logging suppressed I think we can move B out to 2.0.

@zadjii-msft commented on GitHub (Aug 9, 2021): Huh well, I slapped a `DebugBreak()` in the exception handler in `Terminal::CursorLineFeed` and tried printing 1000000000 lines of text to see if that triggers the exception. No luck. Tried with a 9000001 size buffer (which would be clamped to `SHORT_MAX`) - no luck. Tried with `cmatrix` - again, no luck. Resizing wildly also didn't seem to trigger the debugbreak. So I'm a little lost as to what would cause this one. Someone would actually need to find where we're doing the `til::rectangle` math in that function and track it down, but with the logging suppressed I think we can move **B** out to 2.0.
claunia commented 2026-01-31 04:19:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 7, 2023):

We got rid of this entirely a while back. Not sure this is still relevant.

@zadjii-msft commented on GitHub (Sep 7, 2023): We got rid of this entirely a while back. Not sure this is still relevant.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14803
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?