starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Inconsistent handling of built-in color schemes #14806

New Issue
Closed
opened 2026-01-31 04:19:58 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 04:19:58 +00:00
Owner
Copy Link

Originally created by @mrjoel on GitHub (Aug 6, 2021).

Windows Terminal version (or Windows build number)

1.9.1942.0

Other Software

No response

Steps to reproduce

  • Edit a built-in color scheme through the UI
  • Save settings

Expected Behavior

I would expect that built-in color schemes are protected/invariant/read-only. Further, I store my settings.json in a dotfiles git repo and the built-in color schemes are a) just fine for my needs, but b) amount to nothing but litter in the config file.

In my mind, ideally the following changes would address this apparent inconsistency.

  • Don't save the built-in color schemes to settings.json (they're built-in, why pollute the user config file?)
  • Don't allow editing of a built-in color scheme.
  • Provide an option to save a copy of a built-in (or any) color scheme as a different user name.

At the very least an option should be provided to revert a modified built-in color scheme back to the built-in defaults (i.e. reset to match the original), but that seems odd because all of the potential time using a derivative built-in.

Actual Behavior

The color scheme settings UI section indicates that "This color scheme cannot be deleted or renamed because it is included by default.". However the schemes are saved out to the settings.json, and editing of the scheme is allowed. However once a built-in color scheme is edited, it a) doesn't match the expected colors and yet still proclaims the same built-in name, and b) there is no way to reset the color scheme to the originals expect removing the named color scheme from the array in settings.json.

Originally created by @mrjoel on GitHub (Aug 6, 2021). ### Windows Terminal version (or Windows build number) 1.9.1942.0 ### Other Software _No response_ ### Steps to reproduce * Edit a built-in color scheme through the UI * Save settings ### Expected Behavior I would expect that built-in color schemes are protected/invariant/read-only. Further, I store my settings.json in a dotfiles git repo and the built-in color schemes are a) just fine for my needs, but b) amount to nothing but litter in the config file. In my mind, ideally the following changes would address this apparent inconsistency. * Don't save the built-in color schemes to settings.json (they're built-in, why pollute the user config file?) * Don't allow editing of a built-in color scheme. * Provide an option to save a copy of a built-in (or any) color scheme as a different user name. At the very least an option should be provided to revert a modified built-in color scheme back to the built-in defaults (i.e. reset to match the original), but that seems odd because all of the potential time using a derivative built-in. ### Actual Behavior The color scheme settings UI section indicates that "This color scheme cannot be deleted or renamed because it is included by default.". However the schemes are saved out to the settings.json, and editing of the scheme is allowed. However once a built-in color scheme is edited, it a) doesn't match the expected colors and yet still proclaims the same built-in name, and b) there is no way to reset the color scheme to the originals expect removing the named color scheme from the array in settings.json.
claunia added the Resolution-DuplicateProduct-Terminal labels 2026-01-31 04:19:58 +00:00
claunia commented 2026-01-31 04:19:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 16, 2021):

Okay after re-reading this, I actually think this is just going to get fixed by #8100. I know it doesn't sound like it, but with 8100, we won't need to keep reserializing builtin schemes back out. Sorry for the delay getting back here!

/dup #8100

@zadjii-msft commented on GitHub (Nov 16, 2021): Okay after re-reading this, I actually think this is just going to get fixed by #8100. I know it doesn't _sound_ like it, but with 8100, we won't need to keep reserializing builtin schemes back out. Sorry for the delay getting back here! /dup #8100
claunia commented 2026-01-31 04:19:59 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 16, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Nov 16, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14806
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?