starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

VKey assertion failure #14854

New Issue
Closed
opened 2026-01-31 04:21:19 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 04:21:19 +00:00
Owner
Copy Link

Originally created by @Rosefield on GitHub (Aug 12, 2021).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version (or Windows build number)

dev origin/main

Other Software

I use the colemak keyboard layout primarily, but it also seems to happen with regular qwerty too.

Steps to reproduce

Launch the application, assert at line https://github.com/microsoft/terminal/pull/10917/files#diff-ac308dd6d23797c02f8be4591060500c2474856a7c3f483ac5cff219b3fc16a2R720 fails

Expected Behavior

terminal actually loads

Actual Behavior

exception thrown.

Originally created by @Rosefield on GitHub (Aug 12, 2021). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version (or Windows build number) dev origin/main ### Other Software I use the colemak keyboard layout primarily, but it also seems to happen with regular qwerty too. ### Steps to reproduce Launch the application, assert at line https://github.com/microsoft/terminal/pull/10917/files#diff-ac308dd6d23797c02f8be4591060500c2474856a7c3f483ac5cff219b3fc16a2R720 fails ### Expected Behavior terminal actually loads ### Actual Behavior exception thrown.
claunia commented 2026-01-31 04:21:20 +00:00
Author
Owner
Copy Link

@Rosefield commented on GitHub (Aug 12, 2021):

@lhecker sorry :(

@Rosefield commented on GitHub (Aug 12, 2021): @lhecker sorry :(
claunia commented 2026-01-31 04:21:20 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 12, 2021):

Ha! Never apologize for that. It's an excellent catch. 😄

@lhecker will def. need to take a look at this one.

@DHowett commented on GitHub (Aug 12, 2021): Ha! Never apologize for that. It's an excellent catch. :smile: @lhecker will def. need to take a look at this one.
claunia commented 2026-01-31 04:21:20 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 12, 2021):

@Rosefield Can you post the "actions" array from your settings.json? While I know exactly what I forgot to keep in mind (not all scan-codes have virtual keys), I'm unfortunately unable to reproduce this and thus can't test if my fix is correct.

@lhecker commented on GitHub (Aug 12, 2021): @Rosefield Can you post the "actions" array from your settings.json? While I know exactly what I forgot to keep in mind (not all scan-codes have virtual keys), I'm unfortunately unable to reproduce this and thus can't test if my fix is correct.
claunia commented 2026-01-31 04:21:21 +00:00
Author
Owner
Copy Link

@Rosefield commented on GitHub (Aug 12, 2021):

This is my settings.json
https://gist.github.com/Rosefield/b7765da9fb8aa6aee7518b4d59d329cb

@Rosefield commented on GitHub (Aug 12, 2021): This is my settings.json https://gist.github.com/Rosefield/b7765da9fb8aa6aee7518b4d59d329cb
claunia commented 2026-01-31 04:21:21 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 12, 2021):

You can fix the crash by removing this invalid action:

{
    "command": "unbound",
    "keys": ""
},

I find it a bit puzzling that we don't check for such mistakes. 😯

@lhecker commented on GitHub (Aug 12, 2021): You can fix the crash by removing this invalid action: ```json { "command": "unbound", "keys": "" }, ``` I find it a bit puzzling that we don't check for such mistakes. 😯
claunia commented 2026-01-31 04:21:21 +00:00
Author
Owner
Copy Link

@Rosefield commented on GitHub (Aug 12, 2021):

Interesting, I definitely didn't add that myself so there might be a bug in the settings UI that set it? It sounds like there might be a bug still, but maybe not the bug that I thought it was.

@Rosefield commented on GitHub (Aug 12, 2021): Interesting, I definitely didn't add that myself so there might be a bug in the settings UI that set it? It sounds like there might be a bug still, but maybe not the bug that I thought it was.
claunia commented 2026-01-31 04:21:22 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 31, 2021):

:tada:This issue was addressed in #10945, which has now been successfully released as Windows Terminal Preview v1.11.2421.0.🎉

Handy links:

@ghost commented on GitHub (Aug 31, 2021): :tada:This issue was addressed in #10945, which has now been successfully released as `Windows Terminal Preview v1.11.2421.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.11.2421.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Product-Terminal Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14854
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?