starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add and use snmalloc, mimalloc for allocation performance #14899

New Issue
Open
opened 2026-01-31 04:22:44 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 04:22:44 +00:00
Owner
Copy Link

Originally created by @WSLUser on GitHub (Aug 18, 2021).

Description of the new feature/enhancement

Github randomly revealed a project from Microsoft that upon investigation seems like it would be pretty useful here to possibly boost performance for allocations. https://github.com/microsoft/snmalloc

Proposed technical implementation details (optional)

Originally created by @WSLUser on GitHub (Aug 18, 2021). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> Github randomly revealed a project from Microsoft that upon investigation seems like it would be pretty useful here to possibly boost performance for allocations. https://github.com/microsoft/snmalloc # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. -->
claunia added the Help WantedIssue-TaskProduct-MetaArea-Performance labels 2026-01-31 04:22:45 +00:00
claunia commented 2026-01-31 04:22:46 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Aug 20, 2021):

https://github.com/microsoft/mimalloc is more general purpose while snmalloc is for message-passing specifically. Use both as needed in places where allocations need to occur and can't simply be removed.

@WSLUser commented on GitHub (Aug 20, 2021): https://github.com/microsoft/mimalloc is more general purpose while snmalloc is for message-passing specifically. Use both as needed in places where allocations need to occur and can't simply be removed.
claunia commented 2026-01-31 04:22:46 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Aug 20, 2021):

So it looks all we need to do here is add it to the build steps. https://github.com/contour-terminal/contour/pull/341/ shows how it's done for cmake. MSVC makes it bit more difficult as you need to ensure build steps are done properly in order and while I'd like to take a stab at this, I'm concerned about messing the build up trying to add this. I'd start with mimalloc first in this case and follow all of it's recommendations for flags for C++:

For best performance in C++ programs, it is also recommended to override the global new and delete operators. For convience, mimalloc provides mimalloc-new-delete.h which does this for you -- just include it in a single(!) source file in your project. In C++, mimalloc also provides the mi_stl_allocator struct which implements the std::allocator interface.

Also see https://github.com/microsoft/mimalloc#override-on-windows for Windows specific optimizing.

@WSLUser commented on GitHub (Aug 20, 2021): So it looks all we need to do here is add it to the build steps. https://github.com/contour-terminal/contour/pull/341/ shows how it's done for cmake. MSVC makes it bit more difficult as you need to ensure build steps are done properly in order and while I'd like to take a stab at this, I'm concerned about messing the build up trying to add this. I'd start with mimalloc first in this case and follow all of it's recommendations for flags for C++: > For best performance in C++ programs, it is also recommended to override the global new and delete operators. For convience, mimalloc provides mimalloc-new-delete.h which does this for you -- just include it in a single(!) source file in your project. In C++, mimalloc also provides the mi_stl_allocator struct which implements the std::allocator interface. Also see https://github.com/microsoft/mimalloc#override-on-windows for Windows specific optimizing.
claunia commented 2026-01-31 04:22:46 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Aug 20, 2021):

@skyline75489 Are you comfortable with messing with the build steps to see how much of a boost we get in Process Explorer?

@WSLUser commented on GitHub (Aug 20, 2021): @skyline75489 Are you comfortable with messing with the build steps to see how much of a boost we get in Process Explorer?
claunia commented 2026-01-31 04:22:46 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 21, 2021):

Chester is unfortunately currently already preoccupied.
Since the benefits in Contour were rather significant I'll look into this in his stead.

@lhecker commented on GitHub (Aug 21, 2021): Chester is unfortunately currently already preoccupied. Since the benefits in Contour were rather significant I'll look into this in his stead.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Performance Help Wanted Issue-Task Product-Meta
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14899
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?