starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Unify pane splitting and new tab creation #14953

New Issue
Closed
opened 2026-01-31 04:24:08 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 04:24:08 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Aug 23, 2021).

In my eyes, spawning a new tab is a special case of splitting a nonexistent window into one pane.

Right now, we have a lot of divergence between opening a tab (1) and opening a pane (2); in both cases we spawn a new control, but the way it gets propagated into the tree is vastly different. The same applies for duplicating an active pane; the code in pane splitting suggests that duplicating a pane keeps the working directory but a tab does not (!) (see 3) EDIT: No, we accounted for it. Double the code, double the places to look 😉

1

10992b77a0/src/cascadia/TerminalApp/TabManagement.cpp (L242-L272)

2

10992b77a0/src/cascadia/TerminalApp/TerminalPage.cpp (L1391-L1416)

Collapsed note 3

3

10992b77a0/src/cascadia/TerminalApp/TerminalPage.cpp (L1359-L1370)

Originally created by @DHowett on GitHub (Aug 23, 2021). In my eyes, spawning a new tab is a special case of splitting a nonexistent window into one pane. Right now, we have a lot of divergence between opening a tab (1) and opening a pane (2); in both cases we spawn a new control, but the way it gets propagated into the tree is vastly different. The same applies for duplicating an active pane; ~the code in pane splitting suggests that duplicating a pane keeps the working directory but a tab does not (!) (see 3)~ EDIT: No, we accounted for it. Double the code, double the places to look 😉 ### 1 https://github.com/microsoft/terminal/blob/10992b77a0aafdaf1166493df3d0c044bf8975ea/src/cascadia/TerminalApp/TabManagement.cpp#L242-L272 ### 2 https://github.com/microsoft/terminal/blob/10992b77a0aafdaf1166493df3d0c044bf8975ea/src/cascadia/TerminalApp/TerminalPage.cpp#L1391-L1416 <details> <summary>Collapsed note 3</summary> ### 3 https://github.com/microsoft/terminal/blob/10992b77a0aafdaf1166493df3d0c044bf8975ea/src/cascadia/TerminalApp/TerminalPage.cpp#L1359-L1370 </details>
claunia commented 2026-01-31 04:24:09 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 23, 2021):

/cc @PankajBhojwani you did some of the work here to make control initialization uniform, but this is the "farther step" i was talking about. You don't need to do this; it's just an FYI. 😄

@DHowett commented on GitHub (Aug 23, 2021): /cc @PankajBhojwani you did some of the work here to make _control_ initialization uniform, but this is the "farther step" i was talking about. You don't need to do this; it's just an FYI. :smile:
claunia commented 2026-01-31 04:24:09 +00:00
Author
Owner
Copy Link

@PankajBhojwani commented on GitHub (Aug 23, 2021):

Ah I like this

@PankajBhojwani commented on GitHub (Aug 23, 2021): Ah I like this
claunia commented 2026-01-31 04:24:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 23, 2021):

I've meant to do this for so long. The TabManagement.cpp PR really highlighted how bad this one is

@zadjii-msft commented on GitHub (Aug 23, 2021): I've meant to do this for so long. The `TabManagement.cpp` PR really highlighted how bad this one is
claunia commented 2026-01-31 04:24:10 +00:00
Author
Owner
Copy Link

@Rosefield commented on GitHub (Aug 24, 2021):

The CreateNewTabFromPane function that I added as part of move pane to tab could probably be used for this. If you look at _SplitPane, you create the profile/control, then in one branch you do the PreCalculate* and then tab.SplitPane and on the other you just CreateNewTabFromPane. That should get you most of the way there, I think. Internally Pane::Split is effectively just auto pane = std::make_shared<Pane>; _Split(pane) so that could just be modified to take a pane directly instead of passing the control/profile down.

@Rosefield commented on GitHub (Aug 24, 2021): The `CreateNewTabFromPane` function that I added as part of move pane to tab could probably be used for this. If you look at `_SplitPane`, you create the profile/control, then in one branch you do the `PreCalculate*` and then `tab.SplitPane` and on the other you just `CreateNewTabFromPane`. That should get you most of the way there, I think. Internally `Pane::Split` is effectively just `auto pane = std::make_shared<Pane>; _Split(pane)` so that could just be modified to take a pane directly instead of passing the control/profile down.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Help Wanted Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14953
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?